| CARVIEW |
Select Language
HTTP/2 200
date: Sun, 27 Jul 2025 05:12:55 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=280.824522,conversation_content-fragment;desc="conversation_content fragment";dur=521.677708,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=249.409641,nginx;desc="NGINX";dur=1.292058,glb;desc="GLB";dur=101.368019
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=AX9f0aE9zvMcz3%2BSWjLyjRqx8minX8DDZwnKbunPrzDidK5piO9aKoPaCAbjb1QqqpRF6Gs0NhvMauT8pumkCoT7HsMsCfn%2FOTyspi4wfnNxz5sbIUtqaGvT2yxWnn88WxBQ76RmjMNgF3aEgAS7mxQy3s8HyQr6QMNvPIkwigUFeSBYVd3oLzncOtJC5XKPjtI7y9twK3JxieKqxmYYO%2FQ62kQpL4hcHYLBunrTxb7nJGWdiwr8T4jh44bkpjJoQG4TLU31hm7ASVOqU01HNQ%3D%3D--Sp2cXGMsOFvMXTKX--KA2p9%2Ba%2FFB26hZEmk76ZyA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.2083056298.1753593174; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 05:12:54 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 05:12:54 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 82FE:5FFA9:AF5F77:E96E88:6885B556
Added shift + click to nodes and notes to remove from current group by johnpierson · Pull Request #12571 · DynamoDS/Dynamo · GitHub
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 658
Added shift + click to nodes and notes to remove from current group #12571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
QilongTang
merged 2 commits into
DynamoDS:master
from
johnpierson:featureAdd_shiftClickForRemoveFromGroup_john
Feb 13, 2022
Merged
Added shift + click to nodes and notes to remove from current group #12571
QilongTang
merged 2 commits into
DynamoDS:master
from
johnpierson:featureAdd_shiftClickForRemoveFromGroup_john
Feb 13, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
just my two cents -
|
|
Thanks for taking a look! Nested groups behave how I would expect/want them to. If the node or note is the last in a group it drops the whole group 2022-01-21.14-37-49.mp4. |
QilongTang
approved these changes
Feb 11, 2022
|
Tested and updated some comments. I found it hard to connect this with a new unit test especially the real-time shift key check. Once the PR check passed, will merge as it is. |
|
😱 oh my gosh. My first real contribution to dynamo's code. |
The first of many hopefully dude 💪 |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Purpose
This PR adds shift-click remove from group features to nodes and notes.
2022-01-21.14-22-43.mp4
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Drag adding nodes to groups is awesome. This adds the ability to remove nodes and notes from groups with shift+left click.
Reviewers
@QilongTang
FYIs
@Amoursol