You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@saintentropy probably best to merge Wire connector UI modifications #12072 before this. We can handle any conflicts in this PR. Also we probably want to profile them separately to understand where we are/aren't getting performance improvements? I've never done that before but will speak to Ollie about getting some basic numbers done.
Description
This PR:
Separates out the connector ContextMenu from Connectors.xaml into a ConnectorContextMenuViewModel and associated view that gets created when right clicked, and set to null when mouse leaves or when an action is complete.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR:
Connectors.xaml
into aConnectorContextMenuViewModel
and associated view that gets created when right clicked, and set tonull
when mouse leaves or when an action is complete.Declarations
Check these if you believe they are true
*.resx
filesReviewers
@saintentropy
@QilongTang
FYIs
@SHKnudsen
@Amoursol