| CARVIEW |
Select Language
HTTP/2 200
date: Sun, 27 Jul 2025 05:12:14 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=296.699004,conversation_content-fragment;desc="conversation_content fragment";dur=669.49628,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=194.322338,nginx;desc="NGINX";dur=1.010933,glb;desc="GLB";dur=101.037938
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=qJdDTXs5Mu7Tz%2BPBYlDhe%2Fqk7%2BTRuCrSiEh%2BKAR%2Feap6gMMUgPfdzGNgX1s2X6py0W4ffeD7E3cbCby%2FWfplk2Q3Vots8ZqOfU1SjLG8Pxtu3y8Z6u6m%2FirMVUdSLrI0ZU12PQU8QNOrWZyXICGVr%2B0vhgtgOAjLm6%2Fq6pmBJ38AavwRttdudHLFltPGkw2F891v0ny7KPRYbCIPn4d3jWWgJ5TUWMBCEgQG5Xy539mP2Btx4JZ8JPlFwDCAS0oI7JiF9X65tspZJ0J3jpjmtQ%3D%3D--GbIT6QpYjMEnIyzv--XneSxgHj%2Bdh1L1w2KNrQ1Q%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.116933171.1753593134; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 05:12:14 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 05:12:14 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 84E4:5FFA9:AF5100:E95AAB:6885B52E
Adjust the node position when a Node-Autocompletion element is connected. by reddyashish · Pull Request #11775 · DynamoDS/Dynamo · GitHub
reddyashish
changed the title
Adjust the position for Node-Autocompletion elements.
Adjust the node position when a Node-Autocompletion element is connected.
Jun 22, 2021
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 658
Adjust the node position when a Node-Autocompletion element is connected. #11775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reddyashish
changed the title
QilongTang
reviewed
Jun 22, 2021
src/DynamoCoreWpf/ViewModels/Search/NodeSearchElementViewModel.cs
Outdated
Show resolved
Hide resolved
QilongTang
reviewed
Jun 22, 2021
| @@ -278,16 +279,22 @@ protected virtual void CreateAndConnectToPort(object parameter) | |||
|
|
|||
| // Create a new node based on node creation name and connection ports | |||
| dynamoViewModel.ExecuteCommand(new DynamoModel.CreateAndConnectNodeCommand(id, initialNode.GUID, | |||
| Model.CreationName, 0, Model.AutoCompletionNodeElementInfo.PortToConnect, adjustedX, 0, createAsDownStreamNode, false, true)); | |||
| Model.CreationName, 0, Model.AutoCompletionNodeElementInfo.PortToConnect, adjustedX, adjustedY, createAsDownStreamNode, false, true)); | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought we made the adjusted Y 0 on purpose, @aparajit-pratap @zeusongit can you confirm? Maybe we thought the auto layout algorithm will simply solve that? Anyway, the solution here looks simple enough to be consistent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was some back-and-forth on this I remember. But I dont recall the problem. Anyway it seems to work fine at the moment.
QilongTang
approved these changes
Jun 22, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small comments, the end results looks quite appealing
|
@reddyashish looks much better! 😊 Can you please check in the zoomed out way on the new PR to see if it still behaves correctly? |
zeusongit
reviewed
Jun 22, 2021
|
@Amoursol yes verified that the new node is created relative to the node sizes in the workspace(zoomed in/out). |
|
Merging this. Will have to verify if these changes cause of any of UI automation tests to fail. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Purpose
This PR is to adjust the position of the new nodes that are created from Node-Autocompletion functionality.
In the current algorithm, the X-axis position of the new node is relative to position of the port and that looks fine. But the Y-axis position of the new node was not being set relative to parent node so that is set accordingly in these changes. If the input node is a slider, we want to adjust the X-axis position(move left) to compensate for the extra width of the slider node. For all other nodes, the current algorithm works fine.
For the output port, we need a solution to handle placement of multiple nodes as it will be hard to compute how many nodes are already connected to that port and based on that we will need to set the location of the new node. @zeusongit are you covering this part in your task?
Before:
NodeAutocomplete_NotHonoringLocationOfNode.mov
After:
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@QilongTang @zeusongit @Amoursol