You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds a new dialog when a user saves the graph while there are unresolved issues in the graph. The Dialog gives two options either continue to save the graph with the issues or cancel the save and show the Graph Status extension.
For unit test purposes a new event SaveWarningOnUnresolvedIssuesShows has been added, this is only meant to be used for the tests to verify that this dialog actually shows. Because the GenericTaskDialog is not owned by the DynamoWindow we cant verify that its opened that way, hence the need for adding this event.
Are there plans to add this idea of "graph type" to primer? @Amoursol@saintentropy@Jingyi-Wen - If I was not aware of GDIR I doubt I would have any idea what this was message was referring to.
Are there plans to add this idea of "graph type" to primer? @Amoursol@saintentropy@Jingyi-Wen - If I was not aware of GDIR I doubt I would have any idea what this was message was referring to.
No plans from the Morpheus/Turbo side as it stands, albeit we do have plans to update the Primer it it's entirety after the Visual Refresh project lands. @saintentropy - any scope on this side from your end in addition to the Repo / Wiki?
The reason will be displayed to describe this comment to others. Learn more.
Overall I think this looks good.
For the test I'm ok with it as it is but I'm not sure how much value we get since we're not going through the same route when user is at the helm and we're adding some code to make that happen.
How about we just test if the LinterView has opened when there are issues and cancel was pressed ?
I'm thinking to do this : we trigger an event for the cancel action for which we have a handler that will check issues and will open linter view if it has to ( this event will be triggered from both user mode and test mode ).
And this would be the testable part, we will just raise this event from the test, no pressing on Cancel button since we don't have access/can't control it.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR adds a new dialog when a user saves the graph while there are unresolved issues in the graph. The Dialog gives two options either continue to save the graph with the issues or cancel the save and show the Graph Status extension.
For unit test purposes a new event
SaveWarningOnUnresolvedIssuesShowshas been added, this is only meant to be used for the tests to verify that this dialog actually shows. Because theGenericTaskDialogis not owned by the DynamoWindow we cant verify that its opened that way, hence the need for adding this event.Declarations
Check these if you believe they are true
*.resxfilesReviewers
@saintentropy @BogdanZavu @nate-peters
FYIs
@mjkkirschner