You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enhance existing ReadyParams API so that we can have better control over graph opening and closing operations as part of an extension. We will use this in LintingViewExtension where we want to do some cleanup when a graph is closed and allow an extension developer to perform cleanup operations on their listing rules.
Hi @BogdanZavu, thank you for addressing the comments.
I wanted to clarify what I stated above a bit.
There are times we do break the API and document it like you originally had done. But this should only be done when theres no good alternative solution that does not break the API - or there is good enough reason to intentionally break an API.
For example - we broke (and probably will again) the Helix 3d graphics APIs within a minor release:
external types had leaked in the public Dynamo API.
use was very low.
most importantly, the experience for regular dynamo users was severely degraded in the older version of helix, and updating meant they no longer needed to install directX10.
In general I think principles like this should be used to judge API breaks.
What API is being broken/what is the benefit?
how many users will it effect negatively, how many positively?
can we do it some other way and keep both apis working for a bit longer?
Is the API popular? Is it an API we actively advertise (extensions) or just something that is public because of historical reasons.(helix)
I was thinking of this more as a fix rather than an API change. Whoever subscribes to the clearing event most likely will get the workspace from somewhere else.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Enhance existing ReadyParams API so that we can have better control over graph opening and closing operations as part of an extension. We will use this in LintingViewExtension where we want to do some cleanup when a graph is closed and allow an extension developer to perform cleanup operations on their listing rules.
Declarations
Check these if you believe they are true
*.resx
files