| CARVIEW |
Select Language
HTTP/2 200
date: Sun, 27 Jul 2025 05:58:23 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=330.61936,conversation_content-fragment;desc="conversation_content fragment";dur=820.035632,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=249.791433,nginx;desc="NGINX";dur=0.551931,glb;desc="GLB";dur=101.383995
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=jDOavsi6ub9RaRG019vDGYryDmaFUo3g0wpkoetE7SrNfi%2BZT3r4eW1dmEhaZiRVyIamh3ctsTs6QbONwMhiOj1shppColU8bmM6WksHGXohIMxXzrEqSfRouuM0swsfkrXx6gqxYSOQx07eYPxlZTjnA9G3wVlJJSBSQTNyrXtSz7GQTR2q%2FiYMhsRZ5L5dOoADGdIv12YAVXfqCDXb%2BrvNV1dMjZGK914V8QkiBUw2YxAwGxtlBsnc%2B6wc4%2F3pLmoLVBeRxGufxdxJ%2Ft5mvg%3D%3D--1OSsUN8pAPVQ58kv--GCrF938tfLKYLor2%2FblafQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1066009868.1753595902; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 05:58:22 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 05:58:22 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: CEF6:3240E6:B2C9A9:EE4C62:6885BFFE
Analytics Change for Preferences View by QilongTang · Pull Request #11696 · DynamoDS/Dynamo · GitHub
QilongTang
changed the title
Analytics Change for Preferences View
[WIP] Analytics Change for Preferences View
May 19, 2021
QilongTang
changed the title
[WIP] Analytics Change for Preferences View
Analytics Change for Preferences View
May 19, 2021
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 658
Analytics Change for Preferences View #11696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QilongTang
commented
May 19, 2021
| Dynamo.Logging.Analytics.TrackEvent( | ||
| Actions.Switch, | ||
| Categories.Preferences, | ||
| Res.PreferencesViewLanguageLabel); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pattern introduce some repeated code but will be most accurate to avoid logging dialog initialization
QilongTang
commented
May 19, 2021
| Dynamo.Logging.Analytics.TrackEvent( | ||
| Actions.Switch, | ||
| Categories.Preferences, | ||
| description); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This way of logging is more code efficient.. But can't seem to rule out the cases for dialog initialization, because in those cases Dynamo raise property changes regardless if it's user change.. Will look a bit more on best way
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I take it back, since Model_PropertyChanged bind after dialog initialization, this approach should be accurate
QilongTang
changed the title
QilongTang
commented
May 19, 2021
| @@ -552,10 +552,6 @@ | |||
| <value>Number Format</value> | |||
| <comment>Setting menu | Number format</comment> | |||
| </data> | |||
| <data name="DynamoViewSettingMenuRenderPrecision" xml:space="preserve"> | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is duplicate of PreferencesViewVisualSettingsRenderPrecision. @RobertGlobant20 @Astul-Betizagasti when you have time, let's review the resource strings we touched and make sure no duplicates were left.
QilongTang
changed the title
zeusongit
approved these changes
May 19, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
After some thoughts on expanders, seems tracking the clicking there provide minimum value to us. I feel it is reasonable to leave out as part of this PR because at least all working controls in preferences panel works already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Please Note:
DynamoRevitrepo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after aLGTMlabel is added to the PR.Purpose
Analytics Change for Preferences View.
This PR covers analytics for the following area
TODO: Should we track actions on expanders?
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@DynamoDS/dynamo
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of