You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds a new extension that enables setting graph properties from a UI, the extension currently supports these properties:
Description
Author
GraphDocumentationURL
Thumbnail
in addition to the above graph properties, the extension also allows storing CustomProperties in the graphs ExtensionWorkspaceData. The UI adds simple controls to add new custom key/value properties.
UI
Opening graph with properties set
json sample after setting properties
{"Uuid": "bd2ba3e8-f006-409b-a34e-98aaeea3e5fe","IsCustomNode": false,"Description": "Some description about the graph.......","Name": "CustompropertyTest","ElementResolver": {"ResolutionMap": {}},"Inputs": [],"Outputs": [],"Nodes": [],"Connectors": [],"Dependencies": [],"NodeLibraryDependencies": [],"Thumbnail": "/9j/4AAQSkZJRgABAQEASABIAAD/2wBDAAMCAgMCAgMDAwMEAwMEBQgFBQQEBQoHBwYIDAoMDAsKCwsNDhIQDQ4RDgsLEBYQERMUFRUVDA8XGBYUGBIUFRTUDQsNFBQ..... "GraphDocumentationURL": "https://dynamobim.org/","ExtensionWorkspaceData": [{"ExtensionGuid": "28992e1d-abb9-417f-8b1b-05e053bee670","Name": "Properties","Version": "1.0","Data": {"My prop 1": "My value 1","My prop 2": "My Value 2","Custom Property 3": ""}}],"Author": "Name of author","Bindings": [],"View": {"Dynamo": {"ScaleFactor": 1.0,"HasRunWithoutCrash": true,"IsVisibleInDynamoLibrary": true,"Version": "2.12.0.4955","RunType": "Automatic","RunPeriod": "1000"},"Camera": {"Name": "Background Preview","EyeX": -17.0,"EyeY": 24.0,"EyeZ": 50.0,"LookX": 12.0,"LookY": -13.0,"LookZ": -58.0,"UpX": 0.0,"UpY": 1.0,"UpZ": 0.0},"NodeViews": [],"Annotations": [],"X": 0.0,"Y": 0.0,"Zoom": 1.0}}
@SHKnudsen@BogdanZavu just a few minor UI comments and then I think we're good to go on the design side.
Let's use thinner icons for the X and + symbols. I'll send you the files in Slack.
It looks like the text in the custom properties is slightly misaligned with the section above - can you left-justify all of the labels in that section?
There were a few more items from our last discussion but we can make a different PR for them.
One small issue : the dirty flag is not set when a custom property value or name is changed.
@BogdanZavu it looks okay to me - one thing - are you all sure you want this called Graph Properties? I ask because other extensions that mention a graph/workspace/dyn file seem to call it Workspace?
@BogdanZavu it looks okay to me - one thing - are you all sure you want this called Graph Properties? I ask because other extensions that mention a graph/workspace/dyn file seem to call it Workspace?
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR adds a new extension that enables setting graph properties from a UI, the extension currently supports these properties:
Description
Author
GraphDocumentationURL
Thumbnail
in addition to the above graph properties, the extension also allows storing CustomProperties in the graphs ExtensionWorkspaceData. The UI adds simple controls to add new custom key/value properties.
UI
Opening graph with properties set
json sample after setting properties
Declarations
Check these if you believe they are true
*.resx
filesReviewers
@BogdanZavu @mjkkirschner
FYIs
@saintentropy @nate-peters