You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR is to fix the crash that was happening when Autocompletion was triggered on output port of watch node. The reason for the crash was the output port type returned for the Watch node is something like "Node Output:var". When this was passed into the parser, it would throw an exception. So we will just be stripping that unnecessary string from the port type. Aabishkar has found that this was happening only for this particular node. I tried looking any other similar nodes but couldn't find any.
For now, we will be showing the default output suggestions for the Watch node.
reddyashish
changed the title
Fix the crash when Autocompletion was triggered on output port of watch node.
Fix the crash when Autocompletion is triggered on output port of watch node.
May 5, 2021
Yes that would be much better. @QilongTang Do you think changing the output port type of the watch node to just "var" cause any behavior change. I wasn't completely sure about it.
Yes that would be much better. @QilongTang Do you think changing the output port type of the watch node to just "var" cause any behavior change. I wasn't completely sure about it.
I think it should be fine. We can open a different PR for that and use self serve to validate
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR is to fix the crash that was happening when Autocompletion was triggered on output port of watch node. The reason for the crash was the output port type returned for the Watch node is something like "Node Output:var". When this was passed into the parser, it would throw an exception. So we will just be stripping that unnecessary string from the port type. Aabishkar has found that this was happening only for this particular node. I tried looking any other similar nodes but couldn't find any.
For now, we will be showing the default output suggestions for the Watch node.
Declarations
Check these if you believe they are true
*.resx
filesReviewers
@QilongTang @zeusongit @mjkkirschner