You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi @reddyashish - Looking pretty awesome so far! A few comments on what can be improved:
It looks like the Search icon in the bar is truncated at the top and bottom (Flattened off). We probably need a little more breathing room here? [Orange]
Looks like the search text is also not centre justified? Would it look better if so? Or maybe center justified and a little smaller? [Green]
Looks like we have a lot of white space (Grey in this case) on the left hand margin of the results, and no white space (Grey space) on the right. Can we shift the results more to the left, and build in the same border / white space for the results? [Lilac]
Can we make the "X" in the upper right white please? And also the same overall size as the "Autocomplete" header text? Also confirm they are justified the same. [Pink]
Awesome, thank you @reddyashish! Search icon and bar text looks great now.
Would it be possible to give a little more breathing room (i.e. grey/white space) for both sides of the results? It's very close, I'm thinking only a few pixels here.
@Jingyi-Wen are you able to provide a white cross Icon for this work? We don't currently have one π
@Amoursol@Jingyi-Wen@reddyashish I found Search all nodes misleading in this case because what it really does is searching through all autocomplete suggestions, anyway we can capture that?
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR is to make Node Autocomplete UI match the Dynamo Visual Refresh styling.
Task: https://jira.autodesk.com/browse/DYN-3359
Things to do:
Declarations
Check these if you believe they are true
*.resx
filesReviewers
@QilongTang @mjkkirschner @zeusongit @Amoursol