You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR is to update the Helix Toolkit (and by association the Cyotek.Drawing.BitmapFont dependency) from version 2.11 to version 2.15. The purpose of this PR is to address a memory optimization related to the #11395 PR (Generating a single render package per node). Specifically the helix-toolkit/helix-toolkit#1494 PR modifies the behavior of the VertexArrayBuffer which was being retained in memory as a sparse array based on the largest size mesh to be rendered in the session. In 2.15 this buffer is not pinned to the largest allocation size in session.
I must be misunderstanding that PR - because it still looks like the behavior is to create a buffer(vertexCount) ?
Also since the default for isTransient is false, we're not taking advantage of the buffer being cleared - and if we were, then hit testing would be broken it seems.
@mjkkirschner for our purposes the new ThreadBufferManager is what affects us. Here are the relevant changes to the MeshBufferModel and LineBufferModel:
and
The original local vertexArrayBuffer was always retained and would just keeping getting larger based on the largest array of the session. Now per their documentation -> per their notes /// If requested size is larger than this value, buffer will be temporary instead of being retained for reuse.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR is to update the Helix Toolkit (and by association the Cyotek.Drawing.BitmapFont dependency) from version 2.11 to version 2.15. The purpose of this PR is to address a memory optimization related to the #11395 PR (Generating a single render package per node). Specifically the helix-toolkit/helix-toolkit#1494 PR modifies the behavior of the
VertexArrayBuffer
which was being retained in memory as a sparse array based on the largest size mesh to be rendered in the session. In 2.15 this buffer is not pinned to the largest allocation size in session.As a point of interest. This Helix PR fix was triggered due to the issue filed by @aparajit-pratap. helix-toolkit/helix-toolkit#1449
Declarations
Check these if you believe they are true
*.resx
filesReviewers
@aparajit-pratap @mmisol
FYIs
@mjkkirschner