You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DYN-3572 std.lib should be visible in manage node and package path UI
Note: This will also fix DYN-3570 and partially fix DYN-3571 as it will stop Packet manager from downloading packages to the Standard Library directory (but it is till possible to download to the %ProgramData% directory).
This pull request does:
filters out the standard library directory token from the directory list in in PathManager.
add the standard library directory token as the first folder in DynamoModel.
insert the standard library directory token as the first folder if missing in DynamoModel.
add Standard Library to the resources in PackagePathViewModel so it can be translated.
substitute the standard library token with the Standard Library resource when the dialog initializes.
prevent the standard library entry from being deleted in PackagePathViewModel.
prevent the standard library entry from being updated in PackagePathViewModel.
update the wording in the Package Path dialog.
show the Standard Library with Italic font type if Standard Library is disabled.
substitute the translated Standard Library resource with the standard library token when changes are committed in the dialog.
make sure that the DefaultPackagesDirectory property points to the first non standard library entry in PackageLoader
add standard library first if missing in PackageLoader
substitute the standard library token with the runtime standard library directory in PackageLoader
sm6srw
changed the title
WIP: DYN-3572
WIP: DYN-3572 std.lib should be visible in manage node and package path UI
Apr 20, 2021
sm6srw
changed the title
WIP: DYN-3572 std.lib should be visible in manage node and package path UI
DYN-3572 std.lib should be visible in manage node and package path UI
Apr 20, 2021
In this dialog, can we change the description to say that the first path below "Standard Library" is the default save location. Can we also explain that the Standard Library is the location from where packages will be loaded first followed by the rest of the paths.
In this dialog, can we change the description to say that the first path below "Standard Library" is the default save location. Can we also explain that the Standard Library is the location from where packages will be loaded first followed by the rest of the paths.
Good point. I totally missed that text. I will try to come up with some wording that covers the new behavior.
In this dialog, can we change the description to say that the first path below "Standard Library" is the default save location. Can we also explain that the Standard Library is the location from where packages will be loaded first followed by the rest of the paths.
Good point. I totally missed that text. I will try to come up with some wording that covers the new behavior.
@sm6srw - theres one AC that was included in the task that I don't see in your description: if std.lib is disabled, the entry in the ui should appear disabled - what do you think of this one? We could also leave this for later depending on if we expose those options to the UI as well.
This looks pretty solid to me - one thought that occurs to me is that depending on our final strategy for dealing with conflicts during package install (as opposed to Dynamo startup) - that we may reevaluate std.lib's location (first or last), additionally feedback from UX may lead us to rethink this anyway.
Given that, do you think the position is difficult to change after this PR or it will be pretty straightforward? - I was wondering if the logic could be abstracted into a position field somewhere we could set.
@sm6srw - theres one AC that was included in the task that I don't see in your description: if std.lib is disabled, the entry in the ui should appear disabled - what do you think of this one? We could also leave this for later depending on if we expose those options to the UI as well.
This looks pretty solid to me - one thought that occurs to me is that depending on our final strategy for dealing with conflicts during package install (as opposed to Dynamo startup) - that we may reevaluate std.lib's location (first or last), additionally feedback from UX may lead us to rethink this anyway.
Given that, do you think the position is difficult to change after this PR or it will be pretty straightforward? - I was wondering if the logic could be abstracted into a position field somewhere we could set.
It is a small change. It happens in two places right now. But I have been thinking that it might be possible to remove that logic all together now from the PackageLoader with these changes. I think I will take a look at that.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
DYN-3572 std.lib should be visible in manage node and package path UI
Note: This will also fix DYN-3570 and partially fix DYN-3571 as it will stop Packet manager from downloading packages to the Standard Library directory (but it is till possible to download to the
%ProgramData%
directory).This pull request does:
PathManager
.DynamoModel
.DynamoModel
.Standard Library
to the resources inPackagePathViewModel
so it can be translated.Standard Library
resource when the dialog initializes.PackagePathViewModel
.PackagePathViewModel
.Standard Library
resource with the standard library token when changes are committed in the dialog.DefaultPackagesDirectory
property points to the first non standard library entry inPackageLoader
PackageLoader
PackageLoader
Normal dialog:

Dialog when Standard Library is disabled:

Declarations
Check these if you believe they are true
*.resx
files