| CARVIEW |
Select Language
HTTP/2 200
date: Sun, 27 Jul 2025 11:42:09 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=299.694122,conversation_content-fragment;desc="conversation_content fragment";dur=615.470101,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=190.176292,nginx;desc="NGINX";dur=1.155534,glb;desc="GLB";dur=100.770619
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=I9om2BN4%2F4oJydrVSWZhK3jlYc3KZK83tnj2XAqkjh7zYeBxnd5%2F8vUdo3ROzWEEFcHw0H3s3kEMs%2BbW7yHy3vnutpKwws6P6Q2RM0pJrynUXLL3LOYuU%2F3zle7kSUFn0cGCA6MY25CbFrPY1xDMlKnrrxWMjUzUK9FME9zA0pyHrt4gib99%2BWVXjR3vklzv2KSZ6c75vZZTRwO%2B3zWWiUOdV2EWi%2Fs3jm7L87EitKejJARXgu6RfHOupdn0X%2BTcye14RIUJAj9Cow4b4xnlsg%3D%3D--c9G%2Bkb5EIw5UnTk3--tzNbM1G2MRReR8uPRWPwLQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.599532020.1753616528; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 11:42:08 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 11:42:08 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 862C:10904:4567D0:5D2CE9:68861090
Change DefaultWatch3DViewModel property - Active to virtual by ZiyunShang · Pull Request #11597 · DynamoDS/Dynamo · GitHub
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 658
Change DefaultWatch3DViewModel property - Active to virtual #11597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
QilongTang
merged 2 commits into
DynamoDS:master
from
ZiyunShang:t_shanz/UpdateDefaultWatch3DViewModel
Apr 12, 2021
Merged
Change DefaultWatch3DViewModel property - Active to virtual #11597
QilongTang
merged 2 commits into
DynamoDS:master
from
ZiyunShang:t_shanz/UpdateDefaultWatch3DViewModel
Apr 12, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
ZiyunShang
commented
Apr 8, 2021
| @@ -699,7 +699,10 @@ private void RenderPackageFactoryViewModel_PropertyChanged(object sender, Proper | |||
| // A full regeneration is required to get the edge geometry. | |||
| foreach (var vm in Watch3DViewModels) | |||
| { | |||
| vm.RegenerateAllPackages(); | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, I have used Dynamo 2.12.0 when I debug Dynamo code, I found that "Settings" had disappeared from the menu. I don't know how to toggle "ShowEdges" now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @ZiyunShang , we are doing a lot of UI improvements in Dynamo and indeed show edges are currently hidden. It will be back later but pending for implementation now.
QilongTang
reviewed
Apr 11, 2021
| @@ -699,7 +699,10 @@ private void RenderPackageFactoryViewModel_PropertyChanged(object sender, Proper | |||
| // A full regeneration is required to get the edge geometry. | |||
| foreach (var vm in Watch3DViewModels) | |||
| { | |||
| vm.RegenerateAllPackages(); | |||
| if (vm is HelixWatch3DViewModel) | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @ZiyunShang Can you add comment to this type check as to why?
QilongTang
approved these changes
Apr 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than one comment
QilongTang
approved these changes
Apr 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Purpose
REVIT-166657
Some more info :
#9934
#9377
I have the same opinion with alfarok that when toggling "Revit Background Preview", it has no need to force a regeneration of the render packages for all nodes.
I think we can change "Active" to virtual, so it can be overridden in inherited classes.
I just have a change in DynamoRevit - DynamoDS/DynamoRevit#2687 and override Active property.
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@mjkkirschner @QilongTang @aparajit-pratap
FYIs