| CARVIEW |
Select Language
HTTP/2 200
date: Sun, 27 Jul 2025 05:11:44 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=240.998002,conversation_content-fragment;desc="conversation_content fragment";dur=809.724725,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=230.989142,nginx;desc="NGINX";dur=0.898554,glb;desc="GLB";dur=101.69551
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=cQMTQMaN4%2BCsGs7cAO8li6v2X6Lg2z7TQhCPHxV4iz5I6rMPkLgFSHRgHwf08a5RM9XCaaiZDHOmx87JbsxF9p6tXmnccumu4voNPzT%2BpiEPD4pcU1sjzn2mxVXGyYGx70JkEnpdxI3RMvL%2Fz4dHNB9Lzplj%2FNZZcNTNbEaeioj013acpPvAdS%2BE4iqLxgenIRT03aPmiLsmPIpUxKtawHuf1m798PirnF%2Bfe6l8g6%2B9pWTGvCJnKC%2FSbaSl%2FfxyoiC6IkyGhy4XmZtW1SIPtQ%3D%3D--in1SWv3bYDEMzidv--IRglm229MQHY50Nt8BRDIA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.415044209.1753593103; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 05:11:43 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 05:11:43 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: A594:242CC6:AE2ED5:E83588:6885B50F
set IsFirstRun to false if hide report options is true by mjkkirschner · Pull Request #11530 · DynamoDS/Dynamo · GitHub
mjkkirschner
changed the title
Update DynamoView.xaml.cs
set IsFirstRun to false if hide report options is true
Mar 3, 2021
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 658
set IsFirstRun to false if hide report options is true #11530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjkkirschner
changed the title
QilongTang
reviewed
Mar 8, 2021
| @@ -914,6 +914,11 @@ private void DynamoView_Loaded(object sender, EventArgs e) | |||
| // If first run, Collect Info Prompt will appear | |||
| UsageReportingManager.Instance.CheckIsFirstRun(this, dynamoViewModel.BrandingResourceProvider); | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a bit hard to understand from first glance, to me it seems we may want to fold the dynamoViewModel.HideReportOptions check into CheckIsFirstRun() at https://github.com/DynamoDS/Dynamo/blob/master/src/DynamoCoreWpf/Services/UsageReportingManager.cs#L154 so we do not skip the check/setting FirstRun entirely but only skip the usage prompt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@QilongTang let me give that a shot.
|
@QilongTang PTAL |
QilongTang
approved these changes
Mar 8, 2021
|
@mjkkirschner I think this one will need cherry-pick right? |
|
doing it now 😉 |
mjkkirschner
added a commit
to mjkkirschner/Dynamo
that referenced
this pull request
Mar 8, 2021
* Update DynamoView.xaml.cs * add test add internal setter * review comments Co-authored-by: michael kirschner <michael.kirschner@autodesk.com>
mjkkirschner
added a commit
that referenced
this pull request
Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Purpose
when
hide report optionsis enabled, the prompt to request user analytics is also hidden - this function has the side effect thatIsFirstRunis set to false so the gallery is not shown again.If
hide report optionsis enabled we setIsFirstRunto false after this check, but before trying to raise a gallery window.TODO
Declarations
Check these if you believe they are true
*.resxfiles