You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason will be displayed to describe this comment to others. Learn more.
I'll approve, but I guess at some point we should change our approach for marking a node as preview-disabled. This is not the first issue we see regarding that semi transparent box added on top, preventing normal node usage. It probably makes more sense to simply change the colour of the node instead. Copying @mjkkirschner@aparajit-pratap@Amoursol to get some feedback.
This was the problem submitted in the Problem Report, but I agree @mmisol that rather than bespoke solutions we should simply enable all node interactions when the Preview State is turned off with the exception of showing the Geometry in the background preview.
I'm not quite sure I understood why we needed to add another UI element for the tooltip when we already have it. Like @mmisol says, it should be a matter of keeping the existing tooltip enabled even in the preview-off state.
Well, the existing tooltip element was part of the rectangle, and disabling the preview adds a border on top of the node with its bg color set to light blue, and that did not have the tooltip element, which I added. I don't know if there is a way to create a separate tooltip element and bind it to both the rectangle and border.
And as @Amoursol said in standup today that right now the existing solution takes care of all the scenarios, but in future if we get some more update related to preview state we should look into extending the node to handle all the events without needing an extra layer on top.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
DYN-3074
Add description, out-ports, in-ports tooltip to nodes which had their preview disabled.
Declarations
Check these if you believe they are true
Reviewers
@DynamoDS/dynamo