| CARVIEW |
Select Language
HTTP/2 200
date: Sun, 27 Jul 2025 05:48:22 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=350.336402,conversation_content-fragment;desc="conversation_content fragment";dur=796.138391,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=225.723567,nginx;desc="NGINX";dur=0.640352,glb;desc="GLB";dur=101.262327
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=khfTYew9NNljJaTfJKcH347onqT9ajfUsnOh%2BVqzKshFV4aJk0gypA%2FqEoOzdKmw9Ema24BcKZfF4XDYhbh3YQj2BsS%2Fl1KotUAju6ThTNp2nTKKGq2PCVCn%2FC1ddm5lgP4WSdHwDsK1%2FFsi%2FD3UXCUuB8rgnpQDq2gpkoF4eXojmesPMnWArtmcJA8eoJ1%2FpqCwvCI%2FacTyVbNvm4HgLYJFXqvKIFaQaZ4tJLtCZofubQCvhhpAvQf8QZSf%2BEHSJPfoDOg1Avc7j4BO7voLGw%3D%3D--GGRP%2Focp5dKAhc8U--j%2BO7bYNhs8T%2BYQKUTCjTcQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.286941989.1753595301; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 05:48:21 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 05:48:21 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: DA40:37D5F1:B0F6E0:EC24EE:6885BDA5
add no changes state to diff viewer by SHKnudsen · Pull Request #11001 · DynamoDS/Dynamo · GitHub
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 658
add no changes state to diff viewer #11001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mmisol
merged 3 commits into
DynamoDS:master
from
SHKnudsen:add-no-changes-state-to-diff-viewer
Aug 17, 2020
Merged
add no changes state to diff viewer #11001
mmisol
merged 3 commits into
DynamoDS:master
from
SHKnudsen:add-no-changes-state-to-diff-viewer
Aug 17, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Amoursol if you guys are happy with this approach, some feedback on the text would be much appropriated. |
|
I love the style! Still, I think we could make it clearer that they should click "accept" , so that the engine is changed. How does something like |
mmisol
reviewed
Aug 14, 2020
| @@ -145,6 +145,9 @@ There will be a time of transition where both versions of Python node will work | |||
| <data name="IronPythonNotificationShortMessage" xml:space="preserve"> | |||
| <value>This graph currently contains nodes that are using the old IronPython2 (Python 2) engine which will be deprecated in later versions. A new CPython3 (Python 3) has been implemented and is accessible inside the Python editor.</value> | |||
| </data> | |||
| <data name="MigrationAssisantNoChangesStateMessage" xml:space="preserve"> | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo Assisant => Assistant
|
hah, we just talked about this - chiming in to say this looks great. |
|
LGTM! |
mmisol
approved these changes
Aug 17, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @SHKnudsen . Looks good to me!
mmisol
pushed a commit
to mmisol/Dynamo
that referenced
this pull request
Aug 17, 2020
* add has changes state to diff viewer * update text + change engine on accept * typo
8 tasks
mmisol
added a commit
that referenced
this pull request
Aug 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Purpose
When the Migration Assistant is used on code that is already Python 3 compatible the diff viewer will still show the code. This can lead to confusion as it looks like the Migration Assistant isnt working/doing anything.
This PR adds a
No Changesstate to the Diff viewer which will let the user know if no changes are needed.Declarations
Check these if you believe they are true
*.resxfilesReviewers
@mmisol
FYIs
@mjkkirschner
@QilongTang
@Amoursol