| CARVIEW |
Select Language
HTTP/2 200
date: Sun, 27 Jul 2025 05:13:13 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=293.102572,conversation_content-fragment;desc="conversation_content fragment";dur=604.275351,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=243.511994,nginx;desc="NGINX";dur=1.496924,glb;desc="GLB";dur=102.743034
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=BTC%2BYGwivcyQdcuTgatGGFzYdEeG9%2BDiVO6IJD9tMCuoco4v57%2FjLl6qvQBkmZ9AFYcXO7GlDbRqfcM8mdqsmvjnJ16vHsEBC4Ry9lTzNp296PwgwBjRnONkl7r7FdQaI9X1cz5hTSVx07SR7T%2FOn700n3%2BepoSwg4ugPEq7HYjPdjTRC%2FRKC0XxhujCn4EWMPNeI74Zmo1L93BWSZS%2Fxa2mnp%2F5hSicO5l2%2FigByrOg3cxSTF6KVSi8C6a7UsxC8qpDEprXVp0Q%2FBBOAw6GHw%3D%3D--XwK%2FZWeTrcS6aZA8--zT%2BQU1dweEKLz%2FGk0gGUAA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1499962581.1753593192; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 05:13:12 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 05:13:12 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: D764:3B05D7:AD56A9:E767A7:6885B568
add try catch to CLR Object Marshaler getStringValue by mjkkirschner · Pull Request #10952 · DynamoDS/Dynamo · GitHub
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 658
add try catch to CLR Object Marshaler getStringValue #10952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mjkkirschner
merged 2 commits into
DynamoDS:master
from
mjkkirschner:protectCLRtostring
Jul 30, 2020
Merged
add try catch to CLR Object Marshaler getStringValue #10952
mjkkirschner
merged 2 commits into
DynamoDS:master
from
mjkkirschner:protectCLRtostring
Jul 30, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add test
|
@mjkkirschner can we verify that the ToString calls on these Revit/AutoCAD objects are throwing the exceptions and that they are the reason for the crash? |
|
I can try to reproduce locally with Revit, but the stack trace seems to imply that: |
aparajit-pratap
approved these changes
Jul 29, 2020
|
crashed before - after seems to execute ok. |
|
@mjkkirschner it looks like the exception was occurring for only certain parameters and not all. In cases, where the exception is being thrown and caught, there should be empty strings, am I right? |
|
yep! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Purpose
Address the situation where a
ToStringcall on a clr object that is not null results in an exception - it turns out this happens quite frequently in Autocad and Revit.Declarations
Check these if you believe they are true
*.resxfiles