| CARVIEW |
Select Language
HTTP/2 200
date: Sun, 27 Jul 2025 15:19:10 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=341.478831,conversation_content-fragment;desc="conversation_content fragment";dur=765.774259,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=281.254203,nginx;desc="NGINX";dur=1.163715,glb;desc="GLB";dur=101.607705
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=CuZsfDku%2Bpy2kg71usLIxc4wtllJgCMv5VKcX%2BrzUIfc%2FkOCsrXYNf9rvP2L2sbDhW4QIShUdIRuEdQZ8t1f1bVQMe4DVyqs6316O6fsmyVFusJ2CsDnYtoliL8NQtZWnhzlfjxpy7EoHh2LPjW745HoemmEx%2FwS67btE02JRrlenHV9wLLfJEXijdtItillTBpUkkaeqOp1MY7J9STIPb0yn5Wqr8vFgWzfEWhZ9NUDHePfZz6epyHK56wGLNz8tzfSX9s%2BP5%2FCHGDqElGf%2Fg%3D%3D--lEZY5X7NGTvdZY6n--q4BfXe2F%2FQdub%2BnQOyvGTQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.971404000.1753629550; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 15:19:10 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 15:19:10 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 9CBA:5FFA9:F7D1CB:1450E43:6886436D
Fix transpose bug and handle executive revert by mmisol · Pull Request #10656 · DynamoDS/Dynamo · GitHub
mmisol
changed the title
[WIP] Executive fepRun mismatch on graph update
Fix transpose bug and handle executive revert
May 15, 2020
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 658
Fix transpose bug and handle executive revert #10656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Under circumstances related to multiple node deletion, the current executive of the runtime core can present a mismatch on the value of the fepRun field. This is used to indicate that an execution is part of a function endpoint call. This mismatch is circumvented by following a pattern already being used in BuiltInFunctionEndpoint and other places, where an interpreter is created, resulting in a cloned executive but with the fepRun using a value provided in the interpreter constructor. There is also another problem fixed here related to the built-in transpose function not behaving correctly when provided values that are a mix of empty arrays and scalar values.
|
@mmisol can you explain the context of this fix. Which bug are you trying to fix? |
|
Hi @aparajit-pratap . First of all, just wanted to make clear this is not yet ready for review. I just created the PR to get the tests run against this branch. This is related to internal ticket 2674. I'll be happy to share details in standup. |
mmisol
changed the title
| int execStateSize = procedureNode.GraphNodeList.Count; | ||
| stackFrame.ExecutionStateSize = execStateSize; | ||
| for (int n = execStateSize - 1; n >= 0; --n) | ||
| try | ||
| { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ahh, this PR is so much easier to review with white space changes turned off đź‘Ť
| { | ||
| runtimeCore.CurrentExecutive.CurrentDSASMExec = oldDSASMExec; | ||
| if (runtimeCore.CurrentExecutive != null) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay, I think I get it -
when transpose thew an exception (or rather any function would throw an exception - I'm curious if transpose was special in some way? or the way it failed was special?)
then this switch back to the executive which I guess represents the original calling scope is never set back and chaos ensues.
Does this sound about right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You got it @mjkkirschner ! I guess this would have happened with any exception during the lapse the executive is replaced. Now with try/finally the executive should be switched back in any case.
mjkkirschner
approved these changes
May 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Purpose
Under circumstances related to multiple node deletion in the graph
provided, the current executive of the runtime core can present a
mismatch on the value of the fepRun field. This later caused a crash
when the VM, assuming that it was calling a function endpoint, tried
to get a procedure node at an invalid index.
The cause of the this anomaly was an incorrect error handling at
JILFunctionEndPoint.Execute, where an error in a downstream call would
cause the revert of the replaced executive never to happen.
Also, the function that caused the improperly handled error is fixed.
Now the built-in transpose function should behave correctly when
provided values that are a mix of empty arrays and scalar values.
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@DynamoDS/dynamo