You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for regression caused by #10544 - crash when installing an empty package like LunchBox. Changes to new package version API's on the PM (I think) return the PackageVersion whose contents can be null for an empty package. Prior to the API change, the contents would be an empty string for an empty package. Thus it was necessary to add a null check.
The UI automation test DynamoTests.dll.DynamoTests.Tests.SmokeTestPackage was failing, which signaled this regression.
The reason will be displayed to describe this comment to others. Learn more.
PackageManagerClient.PackageContainsPythonScriptsConstant and PackageManagerClient.PackageContainsBinariesConstant are deprecated so I'm not sure if we should use these or something else.
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure either, but the package header only contains one boolean field -contains binaries which is true if the package contains binaries or python...
The reason will be displayed to describe this comment to others. Learn more.
There are 41 versions across 22 packages that are still using this "obsolete" method of marking packages. We could theoretically update those version records in the database to have the contains_binaries field set to true and then we could remove these constants.
@alfredo-pozo the DynamoSelfServe job is failing with this error:
Exception: hudson.AbortException: UT & IT stage: hudson.AbortException: Fail to exec CI test scripts. Please check build log for detail.
Internal error message: script returned exit code 1
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fix for regression caused by #10544 - crash when installing an empty package like LunchBox. Changes to new package version API's on the PM (I think) return the
PackageVersionwhose contents can benullfor an empty package. Prior to the API change, the contents would be an empty string for an empty package. Thus it was necessary to add a null check.The UI automation test DynamoTests.dll.DynamoTests.Tests.SmokeTestPackage was failing, which signaled this regression.
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@mmisol
@mjkkirschner
FYIs
@alfredo-pozo