| CARVIEW |
Select Language
HTTP/2 200
date: Sun, 27 Jul 2025 12:18:27 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=359.074919,conversation_content-fragment;desc="conversation_content fragment";dur=727.765587,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=301.126016,nginx;desc="NGINX";dur=1.270369,glb;desc="GLB";dur=100.927338
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=Tsux0vsqbNmK7My4rtDZVW4%2BVEimLEM7AlvvhgonUbt2n1VgMGEwiR37dUSSumMktdVWZo%2BY2q5EXcB%2BLEFi1gGNTjH%2BEePJFrrNuWrTwv%2Fo8seJoYg8s8NYtcj12fKCfC95RKgVzGPZtn72UIFda3AV2c4ew2TXrWa4W4ObZ%2BFVgkvlOpXo6ksoQBTBfXhv5nsZsTonk99W2xVGC1jlHZ8fW7Z2nsUdSlIGZo%2BIg1gjqM%2F20To0Z3kkXaw5WNefFKhkRAiM%2BhbMbdkptGK7nA%3D%3D--XavUuOMThUpmGf6E--kO1pBcvklCIkTJIVz%2FWLfQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.275428755.1753618707; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 12:18:27 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 12:18:27 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: C900:0A67:347121:42AED2:68861913
DYN-4228 Convert StrongConnectComponent to use List vs Dictionary input type by saintentropy · Pull Request #10355 · DynamoDS/Dynamo · GitHub
saintentropy
changed the title
WIP: Convert StrongConnectComponent to use List vs Dictionary input type
Convert StrongConnectComponent to use List vs Dictionary input type
Oct 18, 2021
saintentropy
changed the title
Convert StrongConnectComponent to use List vs Dictionary input type
[DYN-4228] Convert StrongConnectComponent to use List vs Dictionary input type
Oct 18, 2021
saintentropy
changed the title
[DYN-4228] Convert StrongConnectComponent to use List vs Dictionary input type
DYN-4228 Convert StrongConnectComponent to use List vs Dictionary input type
Oct 18, 2021
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 658
DYN-4228 Convert StrongConnectComponent to use List vs Dictionary input type #10355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
aparajit-pratap
merged 3 commits into
DynamoDS:master
from
saintentropy:DictionaryAllocationOptimization
Apr 26, 2022
Merged
DYN-4228 Convert StrongConnectComponent to use List vs Dictionary input type #10355
aparajit-pratap
merged 3 commits into
DynamoDS:master
from
saintentropy:DictionaryAllocationOptimization
Apr 26, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rough perf comparison for a the compilation step for a sample graph of 320 nodes |
| @@ -337,18 +337,17 @@ private bool CyclicDependencyTest(ProtoCore.AssociativeGraph.GraphNode node, ref | |||
| return true; | |||
| } | |||
|
|
|||
| var indexMap = new Dictionary<GraphNode, int>(); | |||
| var lowlinkMap = new Dictionary<GraphNode, int>(); | |||
| var indexList = new int[codeBlock.instrStream.dependencyGraph.GraphList.Count]; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the actual place where we're getting the perf improvement; since you are pre-allocating the size of the array in this case rather than initializing an empty dictionary that needs to be expanded every other time values are added to it?
saintentropy
changed the title
saintentropy
changed the title
saintentropy
changed the title
aparajit-pratap
approved these changes
Apr 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Waiting for PR checks and tests to pass before merging.
aparajit-pratap
approved these changes
Apr 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Waiting for PR checks and tests to pass before merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Purpose
https://jira.autodesk.com/browse/DYN-4228
The purpose of this PR is to remove a performance bottleneck that affect graphs with larger node quantities. In the graph compilation phase, cyclic dependencies in the graph logic are detected for error and warning purpose. Part of this detection process creates a numerous Dictionary collections which incurred significant time and memory allocation. This PR refactors the
StrongConnectComponentmethod to utilize existing data found in the GraphNode object (specifically thedependencyGraphListIDproperty) vs the creation of new Map data structure for a lookup key.Declarations
Check these if you believe they are true
*.resxfilesReviewers
@mjkkirschner @aparajit-pratap
FYIs
@reddyashish