You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@aparajit-pratap , my memory fading. Can you describe null node a bit?
aparajit-pratap
changed the title
DYN-2273 - Fix crash by compiling null input to null node
DYN-2273 - Fix crash by compiling null input to null AST node
Nov 12, 2019
@QilongTang by nullnode, I meant Null AST node, sorry for not making that clear before. We have a special AST node to represent null. In the case where an input AST is null, we would rather propagate the null than throw an exception either at the time of AST compilation or at runtime, which was what was happening before.
#10391)
* fix crash by compiling null input to null node
* add test
* update recorded test to reflect null value of downstream node
* remove unused usings
Co-authored-by: aparajit-pratap <aparajit.pratap@autodesk.com>
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
JIRA: https://jira.autodesk.com/browse/DYN-2273
Declarations
Check these if you believe they are true
*.resx
filesReviewers
@DynamoDS/dynamo