DYN-8512: Fix multiple globalization and UI adjustments (#16020)

zeusongit · web-flow · commit ff82e54651f2 · 2025-03-28T14:49:35.000-04:00
diff --git a/doc/distrib/NodeHelpFiles/en-US/GV5KUSHDGL7YVBZAR4HEGY5NIXFIG3XTV6ZQPHC5MWWGEVOSRJ4Q_img.jpg b/doc/distrib/NodeHelpFiles/en-US/GV5KUSHDGL7YVBZAR4HEGY5NIXFIG3XTV6ZQPHC5MWWGEVOSRJ4Q_img.jpg
diff --git a/doc/distrib/xml/en-US/GeometryColor.xml b/doc/distrib/xml/en-US/GeometryColor.xml
diff --git a/src/DynamoCoreWpf/Properties/Resources.Designer.cs b/src/DynamoCoreWpf/Properties/Resources.Designer.cs
diff --git a/src/DynamoCoreWpf/Properties/Resources.en-US.resx b/src/DynamoCoreWpf/Properties/Resources.en-US.resx
@@ -4146,4 +4146,10 @@ To make this file into a new template, save it to a different folder, then move
   <data name="ExportWorkspaceAs3DImage" xml:space="preserve">
     <value>Workspace has been exported as a 3D image to </value>
   </data>
-</root>
+  <data name="PackageDetailsViewExtensionName" xml:space="preserve">
+    <value>Package Details</value>
+  </data>
+  <data name="PublishPackageBackToFileButton" xml:space="preserve">
+    <value>Back to File Selection</value>
+  </data>
+</root>
diff --git a/src/DynamoCoreWpf/Properties/Resources.resx b/src/DynamoCoreWpf/Properties/Resources.resx
@@ -4133,4 +4133,10 @@ To make this file into a new template, save it to a different folder, then move
   <data name="ExportWorkspaceAs3DImage" xml:space="preserve">
     <value>Workspace has been exported as a 3D image to </value>
   </data>
-</root>
+  <data name="PackageDetailsViewExtensionName" xml:space="preserve">
+    <value>Package Details</value>
+  </data>
+  <data name="PublishPackageBackToFileButton" xml:space="preserve">
+    <value>Back to File Selection</value>
+  </data>
+</root>
diff --git a/src/DynamoCoreWpf/PublicAPI.Unshipped.txt b/src/DynamoCoreWpf/PublicAPI.Unshipped.txt
@@ -5154,6 +5154,7 @@ static Dynamo.Wpf.Properties.Resources.PackageDetailsSize.get -> string
 static Dynamo.Wpf.Properties.Resources.PackageDetailsUnknownCompatibilityVersionTooltip.get -> string
 static Dynamo.Wpf.Properties.Resources.PackageDetailsVersions.get -> string
 static Dynamo.Wpf.Properties.Resources.PackageDetailsVersionsAndPackageRequirements.get -> string
+static Dynamo.Wpf.Properties.Resources.PackageDetailsViewExtensionName.get -> string
 static Dynamo.Wpf.Properties.Resources.PackageDetailsXCompatibilityWithSetup.get -> string
 static Dynamo.Wpf.Properties.Resources.PackageDownloadConfirmMessageBoxTitle.get -> string
 static Dynamo.Wpf.Properties.Resources.PackageDownloadErrorMessageBoxTitle.get -> string
@@ -5460,6 +5461,7 @@ static Dynamo.Wpf.Properties.Resources.psDynamoLine.get -> byte[]
 static Dynamo.Wpf.Properties.Resources.psDynamoMesh.get -> byte[]
 static Dynamo.Wpf.Properties.Resources.psDynamoPoint.get -> byte[]
 static Dynamo.Wpf.Properties.Resources.PublishPackage.get -> string
+static Dynamo.Wpf.Properties.Resources.PublishPackageBackToFileButton.get -> string
 static Dynamo.Wpf.Properties.Resources.PublishPackageDialogCaption.get -> string
 static Dynamo.Wpf.Properties.Resources.PublishPackageDocTooltipText.get -> string
 static Dynamo.Wpf.Properties.Resources.PublishPackageExternalPackageDependencies.get -> string
diff --git a/src/DynamoCoreWpf/UI/Themes/Modern/DynamoModern.xaml b/src/DynamoCoreWpf/UI/Themes/Modern/DynamoModern.xaml
@@ -4546,7 +4546,7 @@
                                     VerticalAlignment="Stretch"
                                     Orientation="Horizontal">
                             <Grid Name="TabPanel"
-                                  Width="165"
+                                  Width="180"
                                   Height="30"
                                   Margin="5">
                                 <Grid.ColumnDefinitions>
diff --git a/src/DynamoCoreWpf/Views/Core/DynamoView.xaml b/src/DynamoCoreWpf/Views/Core/DynamoView.xaml
@@ -1076,7 +1076,7 @@
                                                 CornerRadius="0,0,0,0">
                                             <Border.ToolTip>
                                                 <uictrls:DynamoToolTip AttachmentSide="Bottom" Style="{DynamicResource ResourceKey=SLightToolTip}">
-                                                    <StackPanel MaxWidth="250" Margin="5">
+                                                    <StackPanel MaxWidth="300" Margin="5">
                                                         <TextBlock x:Name="FileName"
                                                                    Margin="0,0,0,5"
                                                                    Text="{Binding Path=FileName, Converter={StaticResource PathToFileNameConverter}}"
diff --git a/src/DynamoCoreWpf/Views/PackageManager/Controls/PackageManagerPackagesControl.xaml b/src/DynamoCoreWpf/Views/PackageManager/Controls/PackageManagerPackagesControl.xaml
@@ -587,7 +587,7 @@
                                     <ColumnDefinition Width="68" />
                                     <ColumnDefinition Width="85" />
                                     <ColumnDefinition Width="94" />
-                                    <ColumnDefinition Width="60" />
+                                    <ColumnDefinition Width="*" />
                                 </Grid.ColumnDefinitions>
 
                                 <!--  Number of Favorites Label  -->
@@ -643,7 +643,6 @@
                                 <!--  View Details Button  -->
                                 <Button Name="viewDetailsButton"
                                         Grid.Column="3"
-                                        Width="60"
                                         HorizontalAlignment="Right"
                                         Click="ViewDetailsButton_OnClick"
                                         Content="{x:Static p:Resources.PackageSearchResultViewDetails}">
diff --git a/src/DynamoCoreWpf/Views/PackageManager/Controls/PackageManagerPublishControl.xaml b/src/DynamoCoreWpf/Views/PackageManager/Controls/PackageManagerPublishControl.xaml
@@ -235,7 +235,7 @@
                                     <Setter Property="Grid.Row" TargetName="contentPanel" Value="0"/>
                                     <Setter Property="Grid.Column" TargetName="headerPanel" Value="0"/>
                                     <Setter Property="Grid.Column" TargetName="contentPanel" Value="1"/>
-                                    <Setter Property="Width" TargetName="ColumnDefinition0" Value="Auto"/>
+                                    <Setter Property="Width" TargetName="ColumnDefinition0" Value="185"/>
                                     <Setter Property="Width" TargetName="ColumnDefinition1" Value="*"/>
                                     <Setter Property="Height" TargetName="RowDefinition0" Value="*"/>
                                     <Setter Property="Height" TargetName="RowDefinition1" Value="0"/>
@@ -478,7 +478,7 @@
                             Orientation="Horizontal">
 
                     <!--  Back to Selection -->
-                    <Button Content="Back to File Selection"
+                    <Button Content="{x:Static p:Resources.PublishPackageBackToFileButton}"
                             Tag="Back"
                             Click="BreadcrumbButton_Click"
                             DockPanel.Dock="Right"
diff --git a/src/DynamoCoreWpf/Views/PackageManager/Controls/PackageManagerSearchControl.xaml b/src/DynamoCoreWpf/Views/PackageManager/Controls/PackageManagerSearchControl.xaml
@@ -250,7 +250,7 @@
                         <!--  When clicked, the filter button displays a ContextMenu of options to the user  -->
                         <Button.ContextMenu>
                             <ContextMenu Name="HostFilter"
-                                         Width="180"
+                                         Width="205"
                                          Background="{StaticResource GenericBorderBackgroundColorBrush}"
                                          DataContext="{Binding PlacementTarget.DataContext, RelativeSource={RelativeSource Mode=Self}}"
                                          DisplayMemberPath="FilterName"
@@ -393,7 +393,6 @@
 
                 <!--  Clear Filter Button  -->
                 <Button x:Name="ClearFiltersButton"
-                        Width="60"
                         Margin="0,3,5,15"
                         HorizontalAlignment="Right"
                         Command="{Binding ClearFiltersCommand}"
diff --git a/src/Libraries/CoreNodeModels/Input/ColorPalette.cs b/src/Libraries/CoreNodeModels/Input/ColorPalette.cs
@@ -1,4 +1,4 @@
-﻿using System;
+using System;
 using System.Collections.Generic;
 using System.Linq;
 using System.Text.RegularExpressions;
@@ -21,7 +21,8 @@ namespace CoreNodeModels.Input
     [IsDesignScriptCompatible]
     [OutPortNames("Color")]
     [OutPortTypes("DSCore.Color")]
-    [OutPortDescriptions("Selected Color.")]
+    [OutPortDescriptions(typeof(Resources),
+        "ColorPalettePortDataResultToolTip")]
     public class ColorPalette : NodeModel
     {
         private DSColor dscolor = DSColor.ByARGB(255, 0, 0, 0);
@@ -171,4 +172,4 @@ public override IEnumerable<AssociativeNode> BuildOutputAst(List<AssociativeNode
             return new[] { AstFactory.BuildAssignment(GetAstIdentifierForOutputIndex(0), colorNode) };
         }
     }
-}
+}
diff --git a/src/Libraries/CoreNodeModels/Properties/Resources.Designer.cs b/src/Libraries/CoreNodeModels/Properties/Resources.Designer.cs
diff --git a/src/Libraries/CoreNodeModels/Properties/Resources.en-US.resx b/src/Libraries/CoreNodeModels/Properties/Resources.en-US.resx
@@ -772,4 +772,7 @@ double</value>
 
 double[]</value>
   </data>
+  <data name="ColorPalettePortDataResultToolTip" xml:space="preserve">
+    <value>Selected color</value>
+  </data>
 </root>
diff --git a/src/Libraries/CoreNodeModels/Properties/Resources.resx b/src/Libraries/CoreNodeModels/Properties/Resources.resx
@@ -745,4 +745,7 @@ double</value>
 
 double[]</value>
   </data>
+  <data name="ColorPalettePortDataResultToolTip" xml:space="preserve">
+    <value>Selected color</value>
+  </data>
 </root>
diff --git a/src/Libraries/GeometryColor/GeometryColor.cs b/src/Libraries/GeometryColor/GeometryColor.cs
@@ -196,7 +196,7 @@ public static GeometryColor ByPointsColors([KeepReferenceAttribute]Point[] point
         /// <summary>
         /// Display mesh by single color, per-face colors, per-vertex colors, or per-face-vertex colors.
         /// </summary>
-        /// <param name="mesh"></param>The Mesh on which to apply the colors
+        /// <param name="mesh">The Mesh on which to apply the colors</param>
         /// <param name="colors">The color count must equal 1 (single color), or equal the face count (per-face color), or equal the vertex count (per-vertex color), or equal the triangle count multiplied by three (per-triangle-vertex color)</param>
         /// <param name="smoothShading">If true, shading will look smooth instead of faceted, useful for visualizing smooth continuous surfaces</param>
         /// <returns>A Display object.</returns>
diff --git a/src/PackageDetailsViewExtension/PackageDetailsView.xaml b/src/PackageDetailsViewExtension/PackageDetailsView.xaml
@@ -169,7 +169,7 @@
         </Grid.RowDefinitions>
         <DockPanel Margin="0,8,0,0">
             <Label Margin="10,0,0,0"
-                   Content="Package Details"
+                   Content="{x:Static p:Resources.PackageDetailsViewExtensionName}"
                    FontSize="14"
                    FontWeight="Regular"
                    Foreground="#f5f5f5" />
