REVIT-215698: Restrict where OnNodeModified is called. (#14656)

twastvedt · web-flow · commit f1f9b7436153 · 2023-12-04T15:15:01.000-06:00
* Restrict where OnNodeModified is called.

* Clean up.

* Dispose

* No SuppressFinalize
diff --git a/src/Libraries/CoreNodeModels/DropDown.cs b/src/Libraries/CoreNodeModels/DropDown.cs
@@ -59,7 +59,7 @@ public ObservableCollection<DynamoDropDownItem> Items
             set
             {
                 items = value;
-                RaisePropertyChanged("Items");
+                RaisePropertyChanged(nameof(Items));
             }
         }
 
@@ -106,7 +106,6 @@ public int SelectedIndex
                     selectedString = GetSelectedStringFromItem(Items.ElementAt(value));
                 }
 
-                OnNodeModified();
                 RaisePropertyChanged("SelectedIndex");
                 RaisePropertyChanged("SelectedString");
             }
@@ -137,12 +136,12 @@ public string SelectedString
                     if (item != null)
                     {
                         selectedIndex = Items.IndexOf(item);
-                        RaisePropertyChanged("SelectedIndex");
+                        RaisePropertyChanged(nameof(SelectedIndex));
                     }
                 }
 
                 selectedString = value;
-                RaisePropertyChanged("SelectedString");
+                RaisePropertyChanged(nameof(SelectedString));
             }
         }
 
@@ -203,6 +202,8 @@ protected override bool UpdateValueCore(UpdateValueParams updateValueParams)
                     Warning(Dynamo.Properties.Resources.NothingIsSelectedWarning);
                 }
 
+                OnNodeModified();
+
                 return true;
             }
 
diff --git a/src/Libraries/CoreNodeModelsWpf/NodeViewCustomizations/DSDropDownBase.cs b/src/Libraries/CoreNodeModelsWpf/NodeViewCustomizations/DSDropDownBase.cs
@@ -15,61 +15,69 @@ namespace CoreNodeModelsWpf.Nodes
     public class DropDownNodeViewCustomization : INodeViewCustomization<DSDropDownBase>
     {
         private DSDropDownBase model;
+        private ComboBox comboBox;
 
         public void CustomizeView(DSDropDownBase model, NodeView nodeView)
         {
             this.model = model;
 
-            //add a drop down list to the window
-            var combo = new ComboBox
+            // Add a drop down list to the window
+            comboBox = new ComboBox
             {
-                Width = System.Double.NaN,
-                MinWidth= 150,
+                Width = double.NaN,
+                MinWidth = 150,
                 Height = Configurations.PortHeightInPixels,
                 HorizontalAlignment = HorizontalAlignment.Stretch,
-                VerticalAlignment = VerticalAlignment.Center
+                VerticalAlignment = VerticalAlignment.Center,
+                Style = (Style)SharedDictionaryManager.DynamoModernDictionary["RefreshComboBox"]
             };
 
+            nodeView.inputGrid.Children.Add(comboBox);
+            Grid.SetColumn(comboBox, 0);
+            Grid.SetRow(comboBox, 0);
 
-            combo.Style = (Style)SharedDictionaryManager.DynamoModernDictionary["RefreshComboBox"];
+            comboBox.DropDownOpened += DropDownOpened;
+            comboBox.SelectionChanged += SelectionChanged;
 
-            nodeView.inputGrid.Children.Add(combo);
-            System.Windows.Controls.Grid.SetColumn(combo, 0);
-            System.Windows.Controls.Grid.SetRow(combo, 0);
+            comboBox.DataContext = model;
 
-            combo.DropDownOpened += combo_DropDownOpened;
-
-            combo.DataContext = model;
-
-            // bind this combo box to the selected item hash
-            var bindingVal = new System.Windows.Data.Binding("Items")
+            // Bind this combo box to the selected item hash.
+            var bindingVal = new Binding(nameof(DSDropDownBase.Items))
             {
                 Mode = BindingMode.TwoWay,
                 Source = model
             };
-            combo.SetBinding(ItemsControl.ItemsSourceProperty, bindingVal);
+            comboBox.SetBinding(ItemsControl.ItemsSourceProperty, bindingVal);
             
-            // bind the selected index to the model property SelectedIndex
-            var indexBinding = new Binding("SelectedIndex")
+            // Bind the selected index to the model property SelectedIndex.
+            var indexBinding = new Binding(nameof(DSDropDownBase.SelectedIndex))
             {
                 Mode = BindingMode.TwoWay,
                 Source = model
             };
-            combo.SetBinding(Selector.SelectedIndexProperty, indexBinding);
+            comboBox.SetBinding(Selector.SelectedIndexProperty, indexBinding);
+        }
+
+        private void SelectionChanged(object sender, SelectionChangedEventArgs e)
+        {
+            if (comboBox.SelectedIndex != -1)
+            {
+                model.OnNodeModified();
+            }
         }
 
         public void Dispose()
         {
+            comboBox.DropDownOpened -= DropDownOpened;
+            comboBox.SelectionChanged -= SelectionChanged;
         }
 
         /// <summary>
         /// When the dropdown is opened, the node's implementation of PopulateItems is called
         /// </summary>
-        /// <param name="sender"></param>
-        /// <param name="e"></param>
-        void combo_DropDownOpened(object sender, EventArgs e)
+        void DropDownOpened(object sender, EventArgs e)
         {
-            this.model.PopulateItems();
+            model.PopulateItems();
         }
 
     }

Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,7 @@ public ObservableCollection<DynamoDropDownItem> Items`
`59`	`59`	`set`
`60`	`60`	`{`
`61`	`61`	`items = value;`
`62`		`- RaisePropertyChanged("Items");`
	`62`	`+ RaisePropertyChanged(nameof(Items));`
`63`	`63`	`}`
`64`	`64`	`}`
`65`	`65`
`@@ -106,7 +106,6 @@ public int SelectedIndex`
`106`	`106`	`selectedString = GetSelectedStringFromItem(Items.ElementAt(value));`
`107`	`107`	`}`
`108`	`108`
`109`		`- OnNodeModified();`
`110`	`109`	`RaisePropertyChanged("SelectedIndex");`
`111`	`110`	`RaisePropertyChanged("SelectedString");`
`112`	`111`	`}`
`@@ -137,12 +136,12 @@ public string SelectedString`
`137`	`136`	`if (item != null)`
`138`	`137`	`{`
`139`	`138`	`selectedIndex = Items.IndexOf(item);`
`140`		`- RaisePropertyChanged("SelectedIndex");`
	`139`	`+ RaisePropertyChanged(nameof(SelectedIndex));`
`141`	`140`	`}`
`142`	`141`	`}`
`143`	`142`
`144`	`143`	`selectedString = value;`
`145`		`- RaisePropertyChanged("SelectedString");`
	`144`	`+ RaisePropertyChanged(nameof(SelectedString));`
`146`	`145`	`}`
`147`	`146`	`}`
`148`	`147`
`@@ -203,6 +202,8 @@ protected override bool UpdateValueCore(UpdateValueParams updateValueParams)`
`203`	`202`	`Warning(Dynamo.Properties.Resources.NothingIsSelectedWarning);`
`204`	`203`	`}`
`205`	`204`
	`205`	`+ OnNodeModified();`
	`206`	`+`
`206`	`207`	`return true;`
`207`	`208`	`}`
`208`	`209`