DYN-8310 - speed up graph open by caching category getter (#16151)

mjkkirschner · bendikberg · web-flow · commit de327bae7f7d · 2025-04-21T17:31:51.000-04:00
Co-authored-by: Bendik Tobias Berg &lt;bendik@reope.com&gt;
diff --git a/src/DynamoCore/Library/FunctionDescriptor.cs b/src/DynamoCore/Library/FunctionDescriptor.cs
@@ -1,5 +1,6 @@
 using System;
 using System.Collections.Generic;
+using System.Diagnostics;
 using System.IO;
 using System.Linq;
 using System.Reflection;
@@ -68,7 +69,9 @@ public FunctionDescriptorParams()
         }
 
         /// <summary>
-        ///     Returns full path to the assembly the defined this function
+        ///     Returns full path to the assembly the defined this function.
+        ///     This is not always an assembly path, it might be a path to a .ds file
+        ///     or builtin token like 'operators'.
         /// </summary>
         public string Assembly { get; set; }
 
@@ -221,7 +224,9 @@ public FunctionDescriptor(FunctionDescriptorParams funcDescParams)
         public bool IsOverloaded { get; set; }
 
         /// <summary>
-        ///     Full path to the assembly which defined this function
+        ///     Returns full path to the assembly the defined this function.
+        ///     This is not always an assembly path, it might be a path to a .ds file
+        ///     or builtin token like 'operators'.
         /// </summary>
         public string Assembly { get; private set; }
 
@@ -318,49 +323,71 @@ public IEnumerable<Tuple<string, string>> InputParameters
             private set;
         }
 
+        private string category;
         /// <summary>
         ///     The category of this function.
         /// </summary>
         public string Category
         {
             get
             {
+                if (category != null)
+                {
+                    return category;
+                }
                 var categoryBuf = new StringBuilder();
                 categoryBuf.Append(GetRootCategory());
 
-                //if this is not BuiltIn function search NodeCategoryAttribute for it
-                if (ClassName != null)
+                //if this is not BuiltIn function and not a function defined in a .ds file
+                //search the containing assembly for the NodeCategoryAttribute.
+                if (ClassName != null &&
+                    Assembly!=null && !Assembly.ToLowerInvariant().EndsWith(".ds"))
                 {
-                    //get function assembly
-                    var asm = AppDomain.CurrentDomain.GetAssemblies()
-                        .Where(x => x.GetName().Name == Path.GetFileNameWithoutExtension(Assembly))
-                        .ToArray();
-
-                    if (asm.Any() && asm.First().GetType(ClassName) != null)
+                    try
                     {
-                        //get class type of function
-                        var type = asm.First().GetType(ClassName);
-
-                        //get NodeCategoryAttribute for this function if it was been defined
-                        var nodeCat = type.GetMethods().Where(x => x.Name == FunctionName)
-                            .Select(x => x.GetCustomAttribute(typeof(NodeCategoryAttribute)))
-                            .Where(x => x != null)
-                            .Cast<NodeCategoryAttribute>()
-                            .Select(x => x.ElementCategory)
-                            .FirstOrDefault();
-
-                        //if attribute is found compose node category string with last part from attribute
-                        if (!string.IsNullOrEmpty(nodeCat) && (
-                            nodeCat == LibraryServices.Categories.Constructors
-                            || nodeCat == LibraryServices.Categories.Properties
-                            || nodeCat == LibraryServices.Categories.MemberFunctions))
+#if DEBUG
+                        var LoadedAssemblyCount = AppDomain.CurrentDomain.GetAssemblies().Length;
+#endif
+                        var asm = AppDomain.CurrentDomain.Load(Path.GetFileNameWithoutExtension(Assembly));
+#if DEBUG
+
+                        Debug.Assert(AppDomain.CurrentDomain.GetAssemblies().Length == LoadedAssemblyCount,
+                            "Assembly count should not have changed, because should not have actually performed a load.");
+
+#endif
+                        if (asm != null)
                         {
-                            categoryBuf.Append("." + UnqualifedClassName + "." + nodeCat);
-                            return categoryBuf.ToString();
+                            //get class type of function
+                            var type = asm.GetType(ClassName);
+                            if (type != null)
+                            {
+                                //get NodeCategoryAttribute for this function if it was defined
+                                var nodeCat = type.GetMethods().Where(x => x.Name == FunctionName)
+                                    .Select(x => x.GetCustomAttribute(typeof(NodeCategoryAttribute)))
+                                    .Where(x => x != null)
+                                    .Cast<NodeCategoryAttribute>()
+                                    .Select(x => x.ElementCategory)
+                                    .FirstOrDefault();
+
+                                //if attribute is found compose node category string with last part from attribute
+                                if (!string.IsNullOrEmpty(nodeCat) && (
+                                    nodeCat == LibraryServices.Categories.Constructors
+                                    || nodeCat == LibraryServices.Categories.Properties
+                                    || nodeCat == LibraryServices.Categories.MemberFunctions))
+                                {
+                                    categoryBuf.Append("." + UnqualifedClassName + "." + nodeCat);
+                                    category = categoryBuf.ToString();
+                                    return category;
+                                }
+                            }
                         }
                     }
+                    catch (Exception e)
+                    {
+                        //TODO ideally this would surface to dynamo logger somehow.
+                        Console.WriteLine($"Error while generating function descriptor category:{Assembly} {ClassName} {FunctionName} {e}");
+                    }
                 }
-
                 switch (Type)
                 {
                     case FunctionType.Constructor:
@@ -583,7 +610,7 @@ private bool CheckIfFunctionIsMarkedExperimentalByPrefs(FunctionDescriptor fd)
             }
             return false;
         }
-        internal bool IsExperimental { get;}
+        internal bool IsExperimental { get; }
     }
 
 }
diff --git a/src/DynamoCore/Models/DynamoModel.cs b/src/DynamoCore/Models/DynamoModel.cs
@@ -3507,6 +3507,7 @@ internal void AddZeroTouchNodesToSearch(IEnumerable<FunctionGroup> functionGroup
         {
             var iDoc = LuceneUtility.InitializeIndexDocumentForNodes();
             List<NodeSearchElement> nodes = new();
+
             foreach (var funcGroup in functionGroups)
             {
                 foreach (var functionDescriptor in funcGroup.Functions)

Original file line number	Diff line number	Diff line change
`@@ -3507,6 +3507,7 @@ internal void AddZeroTouchNodesToSearch(IEnumerable<FunctionGroup> functionGroup`
`3507`	`3507`	`{`
`3508`	`3508`	`var iDoc = LuceneUtility.InitializeIndexDocumentForNodes();`
`3509`	`3509`	`List<NodeSearchElement> nodes = new();`
	`3510`	`+`
`3510`	`3511`	`foreach (var funcGroup in functionGroups)`
`3511`	`3512`	`{`
`3512`	`3513`	`foreach (var functionDescriptor in funcGroup.Functions)`