DYN-8606 : make dna api obsolete (#16123)

BogdanZavu · zavub · web-flow · commit daf4773245d1 · 2025-04-09T12:15:02.000-04:00
Co-authored-by: Bogdan Zavu &lt;bogdan.zavu@autodesk.com&gt;
diff --git a/src/DynamoCoreWpf/Controls/NodeAutoCompleteSearchControl.xaml.cs b/src/DynamoCoreWpf/Controls/NodeAutoCompleteSearchControl.xaml.cs
@@ -25,6 +25,7 @@ namespace Dynamo.UI.Controls
     /// Notice this control shares a lot of logic with InCanvasSearchControl for now
     /// But they will diverge eventually because of UI improvements to auto complete.
     /// </summary>
+    [Obsolete("This class will be removed in a future version of Dynamo")]
     public partial class NodeAutoCompleteSearchControl : IDisposable
     {
         ListBoxItem HighlightedItem;
@@ -38,8 +39,10 @@ public partial class NodeAutoCompleteSearchControl : IDisposable
         /// <summary>
         /// Node AutoComplete Search ViewModel DataContext
         /// </summary>
+        [Obsolete("This method will be removed in a future version of Dynamo")]
         public NodeAutoCompleteSearchViewModel ViewModel => DataContext as NodeAutoCompleteSearchViewModel;
 
+        [Obsolete("This method will be removed in a future version of Dynamo")]
         public NodeAutoCompleteSearchControl()
         {
             InitializeComponent();
@@ -431,6 +434,7 @@ private void OnSuggestion_Click(object sender, RoutedEventArgs e)
         /// <summary>
         /// Dispose the control
         /// </summary>
+        [Obsolete("This method will be removed in a future version of Dynamo")]
         public void Dispose()
         {
             NodeAutoCompleteSearchControl_Unloaded(this,null);
diff --git a/src/DynamoCoreWpf/ViewModels/Search/NodeAutoCompleteSearchViewModel.cs b/src/DynamoCoreWpf/ViewModels/Search/NodeAutoCompleteSearchViewModel.cs
@@ -34,6 +34,7 @@ namespace Dynamo.ViewModels
     /// <summary>
     /// Search View Model for Node AutoComplete Search Bar
     /// </summary>
+    [Obsolete("This class will be removed in a future version of Dynamo")]
     public class NodeAutoCompleteSearchViewModel : SearchViewModel
     {
         internal PortViewModel PortViewModel { get; set; }
@@ -69,6 +70,7 @@ internal LuceneSearchUtility LuceneUtility
         /// <summary>
         /// For checking if the ML method is selected
         /// </summary>
+        [Obsolete("This method will be removed in a future version of Dynamo")]
         public bool IsDisplayingMLRecommendation
         {
             get
@@ -80,6 +82,7 @@ public bool IsDisplayingMLRecommendation
         /// <summary>
         /// If MLAutocompleteTOU is approved
         /// </summary>
+        [Obsolete("This method will be removed in a future version of Dynamo")]
         public bool IsMLAutocompleteTOUApproved
         {
             get
@@ -91,6 +94,7 @@ public bool IsMLAutocompleteTOUApproved
         /// <summary>
         /// If true, autocomplete method options are hidden from UI 
         /// </summary>
+        [Obsolete("This method will be removed in a future version of Dynamo")]
         public bool HideAutocompleteMethodOptions
         {
             get
@@ -102,6 +106,7 @@ public bool HideAutocompleteMethodOptions
         /// <summary>
         /// The No Recommendations or Low Confidence Title
         /// </summary>
+        [Obsolete("This method will be removed in a future version of Dynamo")]
         public string AutocompleteMLTitle
         {
             get { return autocompleteMLTitle; }
@@ -115,6 +120,7 @@ public string AutocompleteMLTitle
         /// <summary>
         /// The No Recommendations or Low Confidence message
         /// </summary>
+        [Obsolete("This method will be removed in a future version of Dynamo")]
         public string AutocompleteMLMessage
         {
             get { return autocompleteMLMessage; }
@@ -128,6 +134,7 @@ public string AutocompleteMLMessage
         /// <summary>
         /// Indicates the No recommendations / Low confidence message should be displayed (image and texts)
         /// </summary>
+        [Obsolete("This method will be removed in a future version of Dynamo")]
         public bool DisplayAutocompleteMLStaticPage
         {
             get { return displayAutocompleteMLStaticPage; }
@@ -141,6 +148,7 @@ public bool DisplayAutocompleteMLStaticPage
         /// <summary>
         /// Indicates if display the Low confidence option and Tooltip
         /// </summary>
+        [Obsolete("This method will be removed in a future version of Dynamo")]
         public bool DisplayLowConfidence
         {
             get { return displayLowConfidence; }
@@ -906,6 +914,7 @@ internal NodeSearchElementComparer(string typeNameToCompareTo, ProtoCore.Core co
                 this.core = core;
             }
 
+            [Obsolete("This method will be removed in a future version of Dynamo")]
             public int Compare(NodeSearchElement x, NodeSearchElement y)
             {
                 return CompareNodeSearchElementByTypeDistance(x, y, typeNameToCompareTo, core);
diff --git a/src/DynamoCoreWpf/ViewModels/Search/NodeSearchElementViewModel.cs b/src/DynamoCoreWpf/ViewModels/Search/NodeSearchElementViewModel.cs
@@ -4,14 +4,11 @@
 using System.Windows;
 using System.Windows.Input;
 using System.Windows.Media;
-using System.Windows.Threading;
 using Dynamo.Configuration;
-using Dynamo.Controls;
 using Dynamo.Graph.Nodes;
 using Dynamo.Graph.Workspaces;
 using Dynamo.Models;
 using Dynamo.Search.SearchElements;
-using Dynamo.Selection;
 using Dynamo.Utilities;
 using Dynamo.ViewModels;
 using Dynamo.Wpf.Utilities;
@@ -249,6 +246,7 @@ public ImageSource LargeIcon
         /// <summary>
         /// Create the search element as node and connect to target port
         /// </summary>
+        [Obsolete("This command will be removed in a future version of Dynamo")]
         public ICommand CreateAndConnectCommand { get; }
 
         /// <summary>
diff --git a/src/NodeAutoCompleteViewExtension/NodeAutoCompleteViewExtension.cs b/src/NodeAutoCompleteViewExtension/NodeAutoCompleteViewExtension.cs
@@ -80,7 +80,7 @@ public void Ready(ReadyParams readyParams)
 
         public override void Shutdown()
         {
-            // Do nothing for now
+            WorkspaceView.RequesNodeAutoCompleteBar -= OnNodeAutoCompleteBarRequested;
         }
 
         public override void Startup(ViewStartupParams viewStartupParams)
@@ -145,14 +145,13 @@ public override void Loaded(ViewLoadedParams viewLoadedParams)
             WorkspaceView.RequesNodeAutoCompleteBar += OnNodeAutoCompleteBarRequested;
 
         }
+
         public override void Closed()
         {
             if (this.nodeAutocompleteMenuItem != null)
             {
                 this.nodeAutocompleteMenuItem.IsChecked = false;
             }
-
-            WorkspaceView.RequesNodeAutoCompleteBar -= OnNodeAutoCompleteBarRequested;
         }
 
         internal void ShowClusterNodeAutocompleteResults(MLNodeClusterAutoCompletionResponse results)

Original file line number	Diff line number	Diff line change
`@@ -80,7 +80,7 @@ public void Ready(ReadyParams readyParams)`
`80`	`80`
`81`	`81`	`public override void Shutdown()`
`82`	`82`	`{`
`83`		`- // Do nothing for now`
	`83`	`+ WorkspaceView.RequesNodeAutoCompleteBar -= OnNodeAutoCompleteBarRequested;`
`84`	`84`	`}`
`85`	`85`
`86`	`86`	`public override void Startup(ViewStartupParams viewStartupParams)`
`@@ -145,14 +145,13 @@ public override void Loaded(ViewLoadedParams viewLoadedParams)`
`145`	`145`	`WorkspaceView.RequesNodeAutoCompleteBar += OnNodeAutoCompleteBarRequested;`
`146`	`146`
`147`	`147`	`}`
	`148`	`+`
`148`	`149`	`public override void Closed()`
`149`	`150`	`{`
`150`	`151`	`if (this.nodeAutocompleteMenuItem != null)`
`151`	`152`	`{`
`152`	`153`	`this.nodeAutocompleteMenuItem.IsChecked = false;`
`153`	`154`	`}`
`154`		`-`
`155`		`- WorkspaceView.RequesNodeAutoCompleteBar -= OnNodeAutoCompleteBarRequested;`
`156`	`155`	`}`
`157`	`156`
`158`	`157`	`internal void ShowClusterNodeAutocompleteResults(MLNodeClusterAutoCompletionResponse results)`