Do not aggregate node execution analytics anymore (#11356)

QilongTang · web-flow · commit d812d26215b9 · 2020-12-17T11:34:12.000-05:00
* Do not aggregate node execution analytics anymore

* Update to use new event combo

* Update Comments
diff --git a/src/DynamoCore/Models/DynamoModel.cs b/src/DynamoCore/Models/DynamoModel.cs
@@ -1044,18 +1044,19 @@ private void OnAsyncTaskStateChanged(DynamoScheduler sender, TaskStateChangedEve
 
                         if (Logging.Analytics.ReportingAnalytics)
                         {
-                            var modifiedNodes = "";
                             if (updateTask.ModifiedNodes != null && updateTask.ModifiedNodes.Any())
                             {
-                                modifiedNodes = updateTask.ModifiedNodes
-                                    .Select(n => n.GetOriginalName())
-                                    .Aggregate((x, y) => string.Format("{0}, {1}", x, y));
+                                // Send analytics for each of modified nodes so they are counted individually
+                                foreach (var node in updateTask.ModifiedNodes)
+                                {
+                                    // Tracking node execution as generic event
+                                    // it is distinguished with the legacy aggregated performance event
+                                    Dynamo.Logging.Analytics.TrackEvent(
+                                        Actions.Run, 
+                                        Categories.NodeOperations,
+                                        node.GetOriginalName());
+                                }
                             }
-
-                            Dynamo.Logging.Analytics.TrackTimedEvent(
-                                Categories.Performance,
-                                e.Task.GetType().Name,
-                                executionTimeSpan, modifiedNodes);
                         }
 
                         Debug.WriteLine(String.Format(Resources.EvaluationCompleted, executionTimeSpan));
diff --git a/src/NodeServices/IAnalyticsClient.cs b/src/NodeServices/IAnalyticsClient.cs
@@ -194,7 +194,7 @@ public enum Actions
         Switch,
 
         /// <summary>
-        /// Run event, such as Python node run clicked, Graph run Clicked
+        /// Run event, such as Python node run clicked, Graph run Clicked, generic node run during graph execution
         /// </summary>
         Run,
 
