Hide/Show (Un)Deprecate Button for package owner only (#10091)

zeusongit · QilongTang · commit d7e45e2c8a5f · 2019-10-31T17:42:34.000-04:00
* Edited candeprecate method to check author before activation deprecate button

* removed unnecessary comments

* Applied same logic as can deprecate to can undeprecate

* Update PackageViewModel.cs

* packagemanager specific function bubbled up in packagemanagerclient class and pre check for authorisation required before ownership check

* positive test added
diff --git a/src/DynamoCoreWpf/ViewModels/PackageManager/PackageViewModel.cs b/src/DynamoCoreWpf/ViewModels/PackageManager/PackageViewModel.cs
@@ -194,7 +194,8 @@ private void Deprecate()
 
         private bool CanDeprecate()
         {
-            return dynamoViewModel.Model.AuthenticationManager.HasAuthProvider;
+            if (!dynamoViewModel.Model.AuthenticationManager.HasAuthProvider) return false;
+            return packageManagerClient.DoesCurrentUserOwnPackage(Model, dynamoViewModel.Model.AuthenticationManager.Username);
         }
 
         private void Undeprecate()
@@ -203,13 +204,13 @@ private void Undeprecate()
                                       Resources.UndeprecatingPackageMessageBoxTitle, 
                                       MessageBoxButton.YesNo, MessageBoxImage.Question);
             if (res == MessageBoxResult.No) return;
-
             packageManagerClient.Undeprecate(Model.Name);
         }
 
         private bool CanUndeprecate()
         {
-            return dynamoViewModel.Model.AuthenticationManager.HasAuthProvider;
+            if (!dynamoViewModel.Model.AuthenticationManager.HasAuthProvider) return false;
+            return packageManagerClient.DoesCurrentUserOwnPackage(Model, dynamoViewModel.Model.AuthenticationManager.Username);
         }
 
         private void PublishNewPackageVersion()
diff --git a/src/DynamoPackages/PackageManagerClient.cs b/src/DynamoPackages/PackageManagerClient.cs
@@ -5,6 +5,7 @@
 using Greg;
 using Greg.Requests;
 using Greg.Responses;
+using System.Linq;
 
 namespace Dynamo.PackageManager
 {
@@ -238,5 +239,12 @@ internal PackageManagerResult Undeprecate(string name)
                 return new PackageManagerResult(pkgResponse.message, pkgResponse.success);
             }, new PackageManagerResult("Failed to send.", false));
         }
+
+        internal bool DoesCurrentUserOwnPackage(Package package,string username) 
+        {
+            var pkg = new PackageInfo(package.Name, new Version(package.VersionName));
+            var header = GetPackageHeader(pkg);
+            return (header != null) && (header.maintainers.Any(maintainer => maintainer.username.Equals(username)));
+        }
     }
 }
diff --git a/test/Libraries/PackageManagerTests/PackageManagerClientTests.cs b/test/Libraries/PackageManagerTests/PackageManagerClientTests.cs
@@ -397,6 +397,62 @@ public void Deprecate_ReturnsFailureObjectWhenRequestThrowsException()
             Assert.IsFalse(res.Success);
         }
 
+        [Test]
+        public void DoesCurrentUserOwnPackage_ReturnsFalseWhenCurrentUserIsNotTheOwner()
+        {
+            var id = "1";
+            var username = "abcd";
+
+            var mp = new ResponseWithContentBody<PackageHeader>
+            {
+                content = new PackageHeader()
+                {
+                    _id = id,
+                    maintainers= new List<User>()
+                },
+                success = true
+            };
+
+            var c = new Mock<IGregClient>();
+            c.Setup(x =>
+                x.ExecuteAndDeserializeWithContent<PackageHeader>(It.IsAny<HeaderDownload>()))
+                .Returns(mp);
+
+            var pc = new PackageManagerClient(c.Object, MockMaker.Empty<IPackageUploadBuilder>(), "");
+            var res = pc.DoesCurrentUserOwnPackage(new Package("1","1","2.0.4","1"), username);
+
+            Assert.IsFalse(res);
+        }
+        [Test]
+        public void DoesCurrentUserOwnPackage_ReturnsTrueWhenCurrentUserIsTheOwner()
+        {
+            var id = "1";
+            var usrname = "abcd";
+            User usr = new User {
+                _id = id,
+                username = usrname
+            };
+
+            var mp = new ResponseWithContentBody<PackageHeader>
+            {
+                content = new PackageHeader()
+                {
+                    _id = id,
+                    maintainers = new List<User> { usr }
+                },
+                success = true
+            };
+
+            var c = new Mock<IGregClient>();
+            c.Setup(x =>
+                x.ExecuteAndDeserializeWithContent<PackageHeader>(It.IsAny<HeaderDownload>()))
+                .Returns(mp);
+
+            var pc = new PackageManagerClient(c.Object, MockMaker.Empty<IPackageUploadBuilder>(), "");
+            var res = pc.DoesCurrentUserOwnPackage(new Package("1", "1", "2.0.4", "1"), usrname);
+
+            Assert.IsTrue(res);
+        }
         #endregion
 
         #region Undeprecate

Original file line number	Diff line number	Diff line change
`@@ -194,7 +194,8 @@ private void Deprecate()`
`194`	`194`
`195`	`195`	`private bool CanDeprecate()`
`196`	`196`	`{`
`197`		`- return dynamoViewModel.Model.AuthenticationManager.HasAuthProvider;`
	`197`	`+ if (!dynamoViewModel.Model.AuthenticationManager.HasAuthProvider) return false;`
	`198`	`+ return packageManagerClient.DoesCurrentUserOwnPackage(Model, dynamoViewModel.Model.AuthenticationManager.Username);`
`198`	`199`	`}`
`199`	`200`
`200`	`201`	`private void Undeprecate()`
`@@ -203,13 +204,13 @@ private void Undeprecate()`
`203`	`204`	`Resources.UndeprecatingPackageMessageBoxTitle,`
`204`	`205`	`MessageBoxButton.YesNo, MessageBoxImage.Question);`
`205`	`206`	`if (res == MessageBoxResult.No) return;`
`206`		`-`
`207`	`207`	`packageManagerClient.Undeprecate(Model.Name);`
`208`	`208`	`}`
`209`	`209`
`210`	`210`	`private bool CanUndeprecate()`
`211`	`211`	`{`
`212`		`- return dynamoViewModel.Model.AuthenticationManager.HasAuthProvider;`
	`212`	`+ if (!dynamoViewModel.Model.AuthenticationManager.HasAuthProvider) return false;`
	`213`	`+ return packageManagerClient.DoesCurrentUserOwnPackage(Model, dynamoViewModel.Model.AuthenticationManager.Username);`
`213`	`214`	`}`
`214`	`215`
`215`	`216`	`private void PublishNewPackageVersion()`
Original file line number	Diff line number	Diff line change
`@@ -5,6 +5,7 @@`
`5`	`5`	`using Greg;`
`6`	`6`	`using Greg.Requests;`
`7`	`7`	`using Greg.Responses;`
	`8`	`+using System.Linq;`
`8`	`9`
`9`	`10`	`namespace Dynamo.PackageManager`
`10`	`11`	`{`
`@@ -238,5 +239,12 @@ internal PackageManagerResult Undeprecate(string name)`
`238`	`239`	`return new PackageManagerResult(pkgResponse.message, pkgResponse.success);`
`239`	`240`	`}, new PackageManagerResult("Failed to send.", false));`
`240`	`241`	`}`
	`242`	`+`
	`243`	`+ internal bool DoesCurrentUserOwnPackage(Package package,string username)`
	`244`	`+ {`
	`245`	`+ var pkg = new PackageInfo(package.Name, new Version(package.VersionName));`
	`246`	`+ var header = GetPackageHeader(pkg);`
	`247`	`+ return (header != null) && (header.maintainers.Any(maintainer => maintainer.username.Equals(username)));`
	`248`	`+ }`
`241`	`249`	`}`
`242`	`250`	`}`