PackageManager Lucene Crash (#14179)

RobertGlobant20 · web-flow · commit d037ae2b2b36 · 2023-07-21T12:46:30.000-04:00
* PackageManager Lucene Crash

After opening the Package Manager and closing it was crashing due that the LuceneSearchUtility.Writer was null (the second time we don't reach the PackageManagerSearchViewModel constructor so the InitializeLuceneConfig() was not called).
Then for this fix if the PackageManagerSearchViewModel was already created then we have to call again the InitializeLuceneConfig().

* PackageManager Lucene Crash

Removing empty space
diff --git a/src/DynamoCoreWpf/ViewModels/PackageManager/PackageManagerSearchViewModel.cs b/src/DynamoCoreWpf/ViewModels/PackageManager/PackageManagerSearchViewModel.cs
@@ -483,10 +483,18 @@ public PackageManagerSearchViewModel(PackageManagerClientViewModel client) : thi
         {
             PackageManagerClientViewModel = client;
             HostFilter = InitializeHostFilter();
-            LuceneSearchUtility = new LuceneSearchUtility(PackageManagerClientViewModel.DynamoViewModel.Model);
+            InitializeLuceneForPackageManager();
+        }
+
+        internal void InitializeLuceneForPackageManager()
+        {
+            if(LuceneSearchUtility == null)
+            {
+                LuceneSearchUtility = new LuceneSearchUtility(PackageManagerClientViewModel.DynamoViewModel.Model);
+            }          
             LuceneSearchUtility.InitializeLuceneConfig(LuceneConfig.PackagesIndexingDirectory);
         }
-        
+
         /// <summary>
         /// Sort the default package results in the view based on the sorting key and sorting direction.
         /// </summary>
diff --git a/src/DynamoCoreWpf/Views/Core/DynamoView.xaml.cs b/src/DynamoCoreWpf/Views/Core/DynamoView.xaml.cs
@@ -1444,6 +1444,10 @@ private void DynamoViewModelRequestShowPackageManagerSearch(object s, EventArgs
             {
                 _pkgSearchVM = new PackageManagerSearchViewModel(dynamoViewModel.PackageManagerClientViewModel);
             }
+            else
+            {
+                _pkgSearchVM.InitializeLuceneForPackageManager();
+            }
 
             if (_searchPkgsView == null)
             {

Original file line number	Diff line number	Diff line change
`@@ -1444,6 +1444,10 @@ private void DynamoViewModelRequestShowPackageManagerSearch(object s, EventArgs`
`1444`	`1444`	`{`
`1445`	`1445`	`_pkgSearchVM = new PackageManagerSearchViewModel(dynamoViewModel.PackageManagerClientViewModel);`
`1446`	`1446`	`}`
	`1447`	`+ else`
	`1448`	`+ {`
	`1449`	`+ _pkgSearchVM.InitializeLuceneForPackageManager();`
	`1450`	`+ }`
`1447`	`1451`
`1448`	`1452`	`if (_searchPkgsView == null)`
`1449`	`1453`	`{`