DynamoDS
diff --git a/‎src/Dynamo.All.sln
Copy file name to clipboard
+11Lines changed: 11 additions & 0 deletions b/‎src/Dynamo.All.sln
Copy file name to clipboard
+11Lines changed: 11 additions & 0 deletions
diff --git a/‎src/DynamoCore/Extensions/LinterExtensionBase.cs
Copy file name to clipboard
+3-3Lines changed: 3 additions & 3 deletions b/‎src/DynamoCore/Extensions/LinterExtensionBase.cs
Copy file name to clipboard
+3-3Lines changed: 3 additions & 3 deletions
diff --git a/‎src/DynamoCore/Linting/LinterManager.cs
Copy file name to clipboard
+12-7Lines changed: 12 additions & 7 deletions b/‎src/DynamoCore/Linting/LinterManager.cs
Copy file name to clipboard
+12-7Lines changed: 12 additions & 7 deletions
diff --git a/‎src/DynamoCore/Linting/Rules/GraphLinterRule.cs
Copy file name to clipboard
+5-3Lines changed: 5 additions & 3 deletions b/‎src/DynamoCore/Linting/Rules/GraphLinterRule.cs
Copy file name to clipboard
+5-3Lines changed: 5 additions & 3 deletions
diff --git a/‎src/DynamoCore/Linting/Rules/NodeLinterRule.cs
Copy file name to clipboard
+5-3Lines changed: 5 additions & 3 deletions b/‎src/DynamoCore/Linting/Rules/NodeLinterRule.cs
Copy file name to clipboard
+5-3Lines changed: 5 additions & 3 deletions
diff --git a/‎src/DynamoCore/Properties/AssemblyInfo.cs
Copy file name to clipboard
+2-1Lines changed: 2 additions & 1 deletion b/‎src/DynamoCore/Properties/AssemblyInfo.cs
Copy file name to clipboard
+2-1Lines changed: 2 additions & 1 deletion
diff --git a/‎src/LintingViewExtension/Controls/GraphRuleIssue.cs
Copy file name to clipboard
+26Lines changed: 26 additions & 0 deletions b/‎src/LintingViewExtension/Controls/GraphRuleIssue.cs
Copy file name to clipboard
+26Lines changed: 26 additions & 0 deletions
diff --git a/‎src/LintingViewExtension/Controls/IRuleIssue.cs
Copy file name to clipboard
+31Lines changed: 31 additions & 0 deletions b/‎src/LintingViewExtension/Controls/IRuleIssue.cs
Copy file name to clipboard
+31Lines changed: 31 additions & 0 deletions
diff --git a/‎src/LintingViewExtension/Controls/IssueGroup.xaml
Copy file name to clipboard
+73Lines changed: 73 additions & 0 deletions b/‎src/LintingViewExtension/Controls/IssueGroup.xaml
Copy file name to clipboard
+73Lines changed: 73 additions & 0 deletions
diff --git a/‎src/LintingViewExtension/Controls/IssueGroup.xaml.cs
Copy file name to clipboard
+72Lines changed: 72 additions & 0 deletions b/‎src/LintingViewExtension/Controls/IssueGroup.xaml.cs
Copy file name to clipboard
+72Lines changed: 72 additions & 0 deletions
@@ -237,6 +237,8 @@ Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "NodeAutoCompleteViewExtensi
 EndProject
 Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Md2Html", "Tools\Md2Html\Md2Html.csproj", "{0893F745-CB1A-427A-8E87-CA927273039A}"
 EndProject
+Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "LintingViewExtension", "LintingViewExtension\LintingViewExtension.csproj", "{C86F9058-229D-40A9-95D5-D6F081AA9230}"
+EndProject
 Global
 	GlobalSection(SolutionConfigurationPlatforms) = preSolution
 		Debug|Any CPU = Debug|Any CPU
@@ -869,6 +871,14 @@ Global
 		{0893F745-CB1A-427A-8E87-CA927273039A}.Release|Any CPU.Build.0 = Release|Any CPU
 		{0893F745-CB1A-427A-8E87-CA927273039A}.Release|x64.ActiveCfg = Release|Any CPU
 		{0893F745-CB1A-427A-8E87-CA927273039A}.Release|x64.Build.0 = Release|Any CPU
+		{C86F9058-229D-40A9-95D5-D6F081AA9230}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
+		{C86F9058-229D-40A9-95D5-D6F081AA9230}.Debug|Any CPU.Build.0 = Debug|Any CPU
+		{C86F9058-229D-40A9-95D5-D6F081AA9230}.Debug|x64.ActiveCfg = Debug|x64
+		{C86F9058-229D-40A9-95D5-D6F081AA9230}.Debug|x64.Build.0 = Debug|x64
+		{C86F9058-229D-40A9-95D5-D6F081AA9230}.Release|Any CPU.ActiveCfg = Release|Any CPU
+		{C86F9058-229D-40A9-95D5-D6F081AA9230}.Release|Any CPU.Build.0 = Release|Any CPU
+		{C86F9058-229D-40A9-95D5-D6F081AA9230}.Release|x64.ActiveCfg = Release|x64
+		{C86F9058-229D-40A9-95D5-D6F081AA9230}.Release|x64.Build.0 = Release|x64
 	EndGlobalSection
 	GlobalSection(SolutionProperties) = preSolution
 		HideSolutionNode = FALSE
@@ -946,6 +956,7 @@ Global
 		{10AF430D-0D3A-49CE-A63D-848912959745} = {88D45B00-E564-41DB-B57C-9509646CAA49}
 		{51511AFD-F326-4995-8E27-5D711419EF6F} = {88D45B00-E564-41DB-B57C-9509646CAA49}
 		{0893F745-CB1A-427A-8E87-CA927273039A} = {D114C59C-CF66-4CC2-980F-9301FB4EA4E1}
+		{C86F9058-229D-40A9-95D5-D6F081AA9230} = {88D45B00-E564-41DB-B57C-9509646CAA49}
 	EndGlobalSection
 	GlobalSection(ExtensibilityGlobals) = postSolution
 		SolutionGuid = {89CB19C6-BF0A-4E6A-BFDA-79D143EAB59D}
 
@@ -14,7 +14,7 @@ namespace Dynamo.Extensions
     /// <summary>
     /// Base class for all LinterExtensions
     /// </summary>
-    public abstract class LinterExtensionBase : IExtension
+    internal abstract class LinterExtensionBase : IExtension
     {
         private const string NODE_ADDED_PROPERTY = "NodeAdded";
         private const string NODE_REMOVED_PROPERTY = "NodeRemoved";
@@ -115,7 +115,7 @@ private void EvaluateGraphRules(NodeModel modifiedNode, string changedProperty)
                     !rule.EvaluationTriggerEvents.Contains(changedProperty))
                     continue;
 
-                rule.Evaluate(currentWorkspace, modifiedNode);
+                rule.Evaluate(currentWorkspace, changedProperty, modifiedNode);
             }
         }
 
@@ -137,7 +137,7 @@ private void EvaluateNodeRules(NodeModel modifiedNode, string changedProperty)
                 if (changedProperty != NODE_ADDED_PROPERTY && !rule.EvaluationTriggerEvents.Contains(changedProperty))
                     continue;
 
-                rule.Evaluate(modifiedNode);
+                rule.Evaluate(modifiedNode, changedProperty);
             }
         }
 
 
@@ -46,15 +46,17 @@ public LinterExtensionDescriptor ActiveLinter
             {
                 if (activeLinter == value) return;
 
-                if (activeLinter != null)
+                if (activeLinter != null &&
+                    TryGetLinterExtension(activeLinter, out LinterExtensionBase linterExtension))
                 {
-                    GetLinterExtension(activeLinter).Deactivate();
+                    linterExtension.Deactivate();
                 }
 
-                var linterExt = GetLinterExtension(value);
-                if (linterExt is null) return;
+                if (TryGetLinterExtension(value, out linterExtension))
+                {
+                    linterExtension.Activate();
+                }
 
-                linterExt.Activate();
                 activeLinter = value;
             }
         }
@@ -131,13 +133,16 @@ private void OnRuleEvaluated(IRuleEvaluationResult result)
             }
         }
 
-        private LinterExtensionBase GetLinterExtension(LinterExtensionDescriptor activeLinter)
+
+        internal bool TryGetLinterExtension(LinterExtensionDescriptor activeLinter, out LinterExtensionBase linterExtension)
         {
-            return this.extensionManager.
+            linterExtension =  this.extensionManager.
                 Extensions.
                 OfType<LinterExtensionBase>().
                 Where(x => x.UniqueId == activeLinter.Id).
                 FirstOrDefault();
+
+            return linterExtension != null;
         }
 
         public void Dispose()
 
@@ -19,10 +19,11 @@ public abstract class GraphLinterRule : LinterRule
         /// This will use <see cref="EvaluateFunction(WorkspaceModel, NodeModel)"/> to evaluate the rule.       
         /// </summary>
         /// <param name="workspaceModel"></param>
+        /// <param name="changedEvent"></param>
         /// <param name="modifiedNode"></param>
-        internal void Evaluate(WorkspaceModel workspaceModel, NodeModel modifiedNode = null)
+        internal void Evaluate(WorkspaceModel workspaceModel, string changedEvent, NodeModel modifiedNode = null)
         {
-            var pair = EvaluateFunction(workspaceModel, modifiedNode);
+            var pair = EvaluateFunction(workspaceModel, changedEvent, modifiedNode);
             if (pair is null) return;
 
             var result = new GraphRuleEvaluationResult(this.Id, pair.Item1, this.SeverityCode, pair.Item2);
@@ -33,9 +34,10 @@ internal void Evaluate(WorkspaceModel workspaceModel, NodeModel modifiedNode = n
         /// Function used to evaluate this rule
         /// </summary>
         /// <param name="workspaceModel"></param>
+        /// <param name="changedEvent"></param>
         /// <param name="modifiedNode"></param>
         /// <returns></returns>
-        protected abstract Tuple<RuleEvaluationStatusEnum, HashSet<string>> EvaluateFunction(WorkspaceModel workspaceModel, NodeModel modifiedNode = null);
+        protected abstract Tuple<RuleEvaluationStatusEnum, HashSet<string>> EvaluateFunction(WorkspaceModel workspaceModel, string changedEvent, NodeModel modifiedNode = null);
 
         /// <summary>
         /// The init function is used when the Linter extension implementing this Rule is initialized.
 
@@ -20,9 +20,10 @@ public abstract class NodeLinterRule : LinterRule
         /// This will use <see cref="EvaluateFunction(NodeModel)"/> to evaluate the rule.
         /// </summary>
         /// <param name="nodeModel"></param>
-        internal void Evaluate(NodeModel nodeModel)
+        /// <param name="changedEvent"></param>
+        internal void Evaluate(NodeModel nodeModel, string changedEvent)
         {
-            var status = EvaluateFunction(nodeModel);
+            var status = EvaluateFunction(nodeModel, changedEvent);
             var result = new NodeRuleEvaluationResult(this.Id, status, this.SeverityCode, nodeModel.GUID.ToString());
             OnRuleEvaluated(result);
         }
@@ -31,8 +32,9 @@ internal void Evaluate(NodeModel nodeModel)
         /// Function used to evaluate this rule
         /// </summary>
         /// <param name="nodeModel">Node to evaluate</param>
+        /// <param name="changedEvent"></param>
         /// <returns></returns>
-        protected abstract RuleEvaluationStatusEnum EvaluateFunction(NodeModel nodeModel);
+        protected abstract RuleEvaluationStatusEnum EvaluateFunction(NodeModel nodeModel, string changedEvent);
 
         /// <summary>
         /// The init function is used when the Linter extension implementing this Rule is initialized.
 
@@ -34,4 +34,5 @@
 [assembly: InternalsVisibleTo("PythonNodeModelsWpf")]
 [assembly: InternalsVisibleTo("PythonNodeModels")]
 [assembly: InternalsVisibleTo("LibraryViewExtensionMSWebBrowser")]
-[assembly: InternalsVisibleTo("PythonMigrationViewExtension")]
+[assembly: InternalsVisibleTo("PythonMigrationViewExtension")]
+[assembly: InternalsVisibleTo("LintingViewExtension")]
@@ -0,0 +1,26 @@
+using System.Collections.Generic;
+using System.Collections.ObjectModel;
+using Dynamo.Graph.Nodes;
+using Dynamo.Linting.Rules;
+
+namespace Dynamo.LintingViewExtension.Controls
+{
+    internal class GraphRuleIssue : IRuleIssue
+    {
+        public string Id { get; }
+        public LinterRule Rule { get; }
+        public ObservableCollection<NodeModel> AffectedNodes { get; private set; }
+
+        public GraphRuleIssue(string id, GraphLinterRule rule)
+        {
+            Id = id;
+            Rule = rule;
+            AffectedNodes = new ObservableCollection<NodeModel>();
+        }
+
+        public void AddAffectedNodes(List<NodeModel> nodes)
+        {
+            nodes.ForEach(x => AffectedNodes.Add(x));
+        }
+    }
+}
@@ -0,0 +1,31 @@
+using System.Collections.Generic;
+using System.Collections.ObjectModel;
+using Dynamo.Graph.Nodes;
+using Dynamo.Linting.Rules;
+
+namespace Dynamo.LintingViewExtension
+{
+    public interface IRuleIssue
+    {
+        /// <summary>
+        /// Collection of nodeIds affected by this rule issue
+        /// </summary>
+        ObservableCollection<NodeModel> AffectedNodes { get; }
+
+        /// <summary>
+        /// Id of the rule this issue comes from
+        /// </summary>
+        string Id { get; }
+
+        /// <summary>
+        /// Rule this issue comes from
+        /// </summary>
+        LinterRule Rule { get; }
+
+        /// <summary>
+        /// Adds a list of affected nodes to this issue
+        /// </summary>
+        /// <param name="nodes"></param>
+        void AddAffectedNodes(List<NodeModel> nodes);
+    }
+}
@@ -0,0 +1,73 @@
+<UserControl x:Class="Dynamo.LintingViewExtension.Controls.IssueGroup"
+             xmlns="https://schemas.microsoft.com/winfx/2006/xaml/presentation"
+             xmlns:x="https://schemas.microsoft.com/winfx/2006/xaml"
+             xmlns:mc="https://schemas.openxmlformats.org/markup-compatibility/2006"
+             xmlns:d="https://schemas.microsoft.com/expression/blend/2008"
+             xmlns:local="clr-namespace:Dynamo.LintingViewExtension.Controls"
+             xmlns:converter="clr-namespace:Dynamo.LintingViewExtension.Converters"
+             xmlns:severity="clr-namespace:Dynamo.Linting.Interfaces;assembly=DynamoCore"
+             xmlns:fa="https://schemas.fontawesome.io/icons/"
+             mc:Ignorable="d"
+             d:DesignHeight="450"
+             d:DesignWidth="800">
+
+    <UserControl.Resources>
+        <ResourceDictionary>
+            <converter:SeverityCodeToColorConverter x:Key="SeverityCodeToColorConverter" />
+            <converter:SeverityCodeToIconConverter x:Key="SeverityCodeToIconConverter" />
+            <converter:CollectionToVisibilityConverter x:Key="CollectionToVisibilityConverter" />
+
+            <Style TargetType="{x:Type TextBlock}">
+                <Setter Property="Foreground"
+                        Value="White" />
+                <Setter Property="FontSize"
+                        Value="12" />
+            </Style>
+        </ResourceDictionary>
+    </UserControl.Resources>
+
+    <UserControl.Template>
+        <ControlTemplate TargetType="{x:Type UserControl}">
+            <Grid DataContext="{
+                Binding RelativeSource={
+                RelativeSource FindAncestor, AncestorType=local:IssueGroup}}">
+                <Grid.RowDefinitions>
+                    <RowDefinition Height="Auto" />
+                    <RowDefinition Height="*" />
+                    <RowDefinition Height="Auto" />
+                    <RowDefinition Height="Auto" />
+                </Grid.RowDefinitions>
+                <Grid.ColumnDefinitions>
+                    <ColumnDefinition Width="16" />
+                    <ColumnDefinition Width="*" />
+                </Grid.ColumnDefinitions>
+
+
+                <fa:ImageAwesome Height="15"
+                                 Grid.Column="0"
+                                 Icon="{Binding SeverityCode, Converter={StaticResource SeverityCodeToIconConverter}}"
+                                 Foreground="{Binding SeverityCode, Converter={StaticResource SeverityCodeToColorConverter}}">
+                </fa:ImageAwesome>
+                <TextBlock Text="{Binding Description, FallbackValue='Header description'}"
+                            Grid.Column="1"
+                            TextWrapping="WrapWithOverflow"
+                            VerticalAlignment="Center"
+                            Margin="15 5" />
+
+                <ContentPresenter Grid.Row="1"
+                                  Grid.Column="1"
+                                  Margin="15 5"
+                                  Visibility="{Binding NodeIds, Converter={StaticResource CollectionToVisibilityConverter}}"/>
+
+                <TextBlock Text="{Binding CallToAction, FallbackValue='Call to action'}"
+                           Grid.Row="2"
+                           Grid.Column="1"
+                           TextWrapping="WrapWithOverflow"
+                           FontWeight="Bold"
+                           Margin="15 5" />
+
+                <Separator Grid.Row="3" Grid.ColumnSpan="2"/>
+            </Grid>
+        </ControlTemplate>
+    </UserControl.Template>
+</UserControl>
@@ -0,0 +1,72 @@
+using System.Collections.Generic;
+using System.Windows;
+using System.Windows.Controls;
+using Dynamo.Graph.Nodes;
+using Dynamo.Linting.Interfaces;
+using Dynamo.Linting.Rules;
+
+namespace Dynamo.LintingViewExtension.Controls
+{
+    /// <summary>
+    /// Interaction logic for IssueGroup.xaml
+    /// </summary>
+    public partial class IssueGroup : UserControl
+    {
+        #region DependencyProperties
+
+        internal IEnumerable<NodeModel> IssueNodes
+        {
+            get { return (IEnumerable<NodeModel>)GetValue(IssueNodesProperty); }
+            set { SetValue(IssueNodesProperty, value); }
+        }
+
+        public static readonly DependencyProperty IssueNodesProperty = DependencyProperty.Register(
+            nameof(IssueNodes),
+            typeof(IEnumerable<NodeModel>),
+            typeof(IssueGroup)
+        );
+
+        public string Description
+        {
+            get { return (string)GetValue(DescriptionProperty); }
+            set { SetValue(DescriptionProperty, value); }
+        }
+
+        public static readonly DependencyProperty DescriptionProperty = DependencyProperty.Register(
+            nameof(Description),
+            typeof(string),
+            typeof(IssueGroup)
+        );
+
+        public string CallToAction
+        {
+            get { return (string)GetValue(CallToActionProperty); }
+            set { SetValue(CallToActionProperty, value); }
+        }
+
+        public static readonly DependencyProperty CallToActionProperty = DependencyProperty.Register(
+            nameof(CallToAction),
+            typeof(string),
+            typeof(IssueGroup)
+        );
+
+        public SeverityCodesEnum SeverityCode
+        {
+            get { return (SeverityCodesEnum)GetValue(SeverityCodeProperty); }
+            set { SetValue(SeverityCodeProperty, value); }
+        }
+
+        public static readonly DependencyProperty SeverityCodeProperty = DependencyProperty.Register(
+            nameof(SeverityCode),
+            typeof(SeverityCodesEnum),
+            typeof(IssueGroup)
+        );
+
+        #endregion DependencyProperties
+
+        public IssueGroup()
+        {
+            InitializeComponent();
+        }
+    }
+}
Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@ namespace Dynamo.Extensions`
`14`	`14`	`/// <summary>`
`15`	`15`	`/// Base class for all LinterExtensions`
`16`	`16`	`/// </summary>`
`17`		`- public abstract class LinterExtensionBase : IExtension`
	`17`	`+ internal abstract class LinterExtensionBase : IExtension`
`18`	`18`	`{`
`19`	`19`	`private const string NODE_ADDED_PROPERTY = "NodeAdded";`
`20`	`20`	`private const string NODE_REMOVED_PROPERTY = "NodeRemoved";`
`@@ -115,7 +115,7 @@ private void EvaluateGraphRules(NodeModel modifiedNode, string changedProperty)`
`115`	`115`	`!rule.EvaluationTriggerEvents.Contains(changedProperty))`
`116`	`116`	`continue;`
`117`	`117`
`118`		`- rule.Evaluate(currentWorkspace, modifiedNode);`
	`118`	`+ rule.Evaluate(currentWorkspace, changedProperty, modifiedNode);`
`119`	`119`	`}`
`120`	`120`	`}`
`121`	`121`
`@@ -137,7 +137,7 @@ private void EvaluateNodeRules(NodeModel modifiedNode, string changedProperty)`
`137`	`137`	`if (changedProperty != NODE_ADDED_PROPERTY && !rule.EvaluationTriggerEvents.Contains(changedProperty))`
`138`	`138`	`continue;`
`139`	`139`
`140`		`- rule.Evaluate(modifiedNode);`
	`140`	`+ rule.Evaluate(modifiedNode, changedProperty);`
`141`	`141`	`}`
`142`	`142`	`}`
`143`	`143`
Original file line number	Diff line number	Diff line change
`@@ -46,15 +46,17 @@ public LinterExtensionDescriptor ActiveLinter`
`46`	`46`	`{`
`47`	`47`	`if (activeLinter == value) return;`
`48`	`48`
`49`		`- if (activeLinter != null)`
	`49`	`+ if (activeLinter != null &&`
	`50`	`+ TryGetLinterExtension(activeLinter, out LinterExtensionBase linterExtension))`
`50`	`51`	`{`
`51`		`- GetLinterExtension(activeLinter).Deactivate();`
	`52`	`+ linterExtension.Deactivate();`
`52`	`53`	`}`
`53`	`54`
`54`		`- var linterExt = GetLinterExtension(value);`
`55`		`- if (linterExt is null) return;`
	`55`	`+ if (TryGetLinterExtension(value, out linterExtension))`
	`56`	`+ {`
	`57`	`+ linterExtension.Activate();`
	`58`	`+ }`
`56`	`59`
`57`		`- linterExt.Activate();`
`58`	`60`	`activeLinter = value;`
`59`	`61`	`}`
`60`	`62`	`}`
`@@ -131,13 +133,16 @@ private void OnRuleEvaluated(IRuleEvaluationResult result)`
`131`	`133`	`}`
`132`	`134`	`}`
`133`	`135`
`134`		`- private LinterExtensionBase GetLinterExtension(LinterExtensionDescriptor activeLinter)`
	`136`	`+`
	`137`	`+ internal bool TryGetLinterExtension(LinterExtensionDescriptor activeLinter, out LinterExtensionBase linterExtension)`
`135`	`138`	`{`
`136`		`- return this.extensionManager.`
	`139`	`+ linterExtension = this.extensionManager.`
`137`	`140`	`Extensions.`
`138`	`141`	`OfType<LinterExtensionBase>().`
`139`	`142`	`Where(x => x.UniqueId == activeLinter.Id).`
`140`	`143`	`FirstOrDefault();`
	`144`	`+`
	`145`	`+ return linterExtension != null;`
`141`	`146`	`}`
`142`	`147`
`143`	`148`	`public void Dispose()`