Address Unsaved Changes Edge Case (#11601)

QilongTang · web-flow · commit b1fe891aaa84 · 2021-04-13T07:54:04.000-07:00
* Adress Unsaved Changes Edge Case

* Add unit test
diff --git a/src/DynamoCore/Graph/Workspaces/WorkspaceModel.cs b/src/DynamoCore/Graph/Workspaces/WorkspaceModel.cs
@@ -1298,6 +1298,9 @@ internal void RemoveAndDisposeNode(NodeModel model, bool dispose = true)
             }
 
             OnNodeRemoved(model);
+            // Force this change to address the edge case that user deleting the right edge
+            // node and do not see unsaved changes, e.g. the watch node at end of the graph
+            HasUnsavedChanges = true;
 
             if (dispose)
             {
diff --git a/test/DynamoCoreTests/CoreTests.cs b/test/DynamoCoreTests/CoreTests.cs
@@ -699,6 +699,23 @@ public void UndoMoveDoesNotForceExecution()
             Assert.IsFalse(sumNode.IsModified);
         }
 
+        /// <summary>
+        /// This test is added to test if the HasUnsavedChanges can be set 
+        /// correctly after node removal using an edge case
+        /// </summary>
+        [Test]
+        public void TestHasUnsavedChangesOnNodeRemovalEdgeCase()
+        {
+            string openPath = Path.Combine(TestDirectory, @"core\logic\comparison\testToleranceEquals_defaultTolerance.dyn");
+            OpenModel(openPath);
+            // Default state after graph open
+            Assert.AreEqual(false, CurrentDynamoModel.CurrentWorkspace.HasUnsavedChanges);
+            CurrentDynamoModel.CurrentWorkspace.RecordAndDeleteModels(
+                CurrentDynamoModel.CurrentWorkspace.Nodes.Where(x=>x.GUID.Equals(new Guid("c2f69bf434be47fa8f0a4a0ceca5910b"))).ToList<ModelBase>());
+            // Assert HasUnsavedChanges is true after a downstream node removal
+            Assert.AreEqual(true, CurrentDynamoModel.CurrentWorkspace.HasUnsavedChanges);
+        }
+
         [Test]
         public void TestFileDirtyOnLacingChange()
         {

Original file line number	Diff line number	Diff line change
`@@ -1298,6 +1298,9 @@ internal void RemoveAndDisposeNode(NodeModel model, bool dispose = true)`
`1298`	`1298`	`}`
`1299`	`1299`
`1300`	`1300`	`OnNodeRemoved(model);`
	`1301`	`+ // Force this change to address the edge case that user deleting the right edge`
	`1302`	`+ // node and do not see unsaved changes, e.g. the watch node at end of the graph`
	`1303`	`+ HasUnsavedChanges = true;`
`1301`	`1304`
`1302`	`1305`	`if (dispose)`
`1303`	`1306`	`{`