DYN-6893 input symbol nodes should have default names - pt 1 (#15193)

mjkkirschner · web-flow · commit b120519ecd9e · 2024-05-07T18:14:21.000-04:00
merging this in, will ask for ux review next week.
diff --git a/src/DynamoCore/Graph/Nodes/CustomNodes/Function.cs b/src/DynamoCore/Graph/Nodes/CustomNodes/Function.cs
@@ -5,6 +5,7 @@
 using Dynamo.Engine;
 using Dynamo.Engine.CodeGeneration;
 using Dynamo.Library;
+using Dynamo.Properties;
 using Newtonsoft.Json;
 using ProtoCore;
 using ProtoCore.AST.AssociativeAST;
@@ -388,8 +389,13 @@ public Symbol()
             RegisterAllPorts();
 
             ArgumentLacing = LacingStrategy.Disabled;
-
-            InputSymbol = String.Empty;
+            InputSymbol = new TypedParameter(
+                Resources.InputPortAlternativeName,
+                "var",
+                -1,
+                null,
+                Resources.InputNodeRenameHint)
+                .ToCommentNameString();
 
             ElementResolver = new ElementResolver();
         }
@@ -463,7 +469,7 @@ public string InputSymbol
                 }
 
                 OnNodeModified();
-                RaisePropertyChanged("InputSymbol");
+                RaisePropertyChanged(nameof(InputSymbol));
             }
         }
 
diff --git a/src/DynamoCore/Properties/Resources.Designer.cs b/src/DynamoCore/Properties/Resources.Designer.cs
diff --git a/src/DynamoCore/Properties/Resources.en-US.resx b/src/DynamoCore/Properties/Resources.en-US.resx
@@ -911,4 +911,7 @@ This package likely contains an assembly that is blocked. You will need to load
   <data name="LegacyTraceDataWarning" xml:space="preserve">
     <value>This workspace contains element binding data in a legacy format that is no longer supported in Dynamo 3.0 and higher versions. Element binding data will be saved in the new format the next time you run and save this workspace.</value>
   </data>
+  <data name="InputNodeRenameHint" xml:space="preserve">
+    <value>default input name, rename me!</value>
+  </data>
 </root>
diff --git a/src/DynamoCore/Properties/Resources.resx b/src/DynamoCore/Properties/Resources.resx
@@ -914,4 +914,7 @@ This package likely contains an assembly that is blocked. You will need to load
   <data name="LegacyTraceDataWarning" xml:space="preserve">
     <value>This workspace contains element binding data in a legacy format that is no longer supported in Dynamo 3.0 and higher versions. Element binding data will be saved in the new format the next time you run and save this workspace.</value>
   </data>
-</root>
+  <data name="InputNodeRenameHint" xml:space="preserve">
+    <value>default input name, rename me!</value>
+  </data>
+</root>
diff --git a/src/DynamoCore/PublicAPI.Unshipped.txt b/src/DynamoCore/PublicAPI.Unshipped.txt
@@ -2834,6 +2834,7 @@ static Dynamo.Properties.Resources.IncorrectlyFormattedNodeLibraryWarning.get ->
 static Dynamo.Properties.Resources.IncorrectVersionToOpenFile.get -> string
 static Dynamo.Properties.Resources.InputLabel.get -> string
 static Dynamo.Properties.Resources.InputNodeDescription.get -> string
+static Dynamo.Properties.Resources.InputNodeRenameHint.get -> string
 static Dynamo.Properties.Resources.InputNodeSearchTags.get -> string
 static Dynamo.Properties.Resources.InputPortAlternativeName.get -> string
 static Dynamo.Properties.Resources.InsertDialogBoxText.get -> string
diff --git a/test/DynamoCoreTests/CustomNodes.cs b/test/DynamoCoreTests/CustomNodes.cs
@@ -1423,5 +1423,13 @@ public void LooseCustomNodeShouldNotHavePackageInfoOrPackageMember()
             Assert.IsFalse(nodeInfo.Value.IsPackageMember);
             Assert.IsNull(nodeInfo.Value.PackageInfo);
         }
+        [Test]
+        public void InputNodeShouldHaveNameByDefault()
+        {
+            var input = new Symbol();
+            Assert.NotNull(input.Parameter.Name);
+            Assert.IsNotEmpty(input.Parameter.Name);
+            Assert.AreEqual("input",input.Parameter.Name);
+        }
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -1423,5 +1423,13 @@ public void LooseCustomNodeShouldNotHavePackageInfoOrPackageMember()`
`1423`	`1423`	`Assert.IsFalse(nodeInfo.Value.IsPackageMember);`
`1424`	`1424`	`Assert.IsNull(nodeInfo.Value.PackageInfo);`
`1425`	`1425`	`}`
	`1426`	`+ [Test]`
	`1427`	`+ public void InputNodeShouldHaveNameByDefault()`
	`1428`	`+ {`
	`1429`	`+ var input = new Symbol();`
	`1430`	`+ Assert.NotNull(input.Parameter.Name);`
	`1431`	`+ Assert.IsNotEmpty(input.Parameter.Name);`
	`1432`	`+ Assert.AreEqual("input",input.Parameter.Name);`
	`1433`	`+ }`
`1426`	`1434`	`}`
`1427`	`1435`	`}`