single warning message (#14890)

dnenov · web-flow · commit abbd28f61f69 · 2024-01-26T15:15:49.000-05:00
- trigger warning message only once when the user has attempted to load an existing dll from another path
diff --git a/src/DynamoCoreWpf/ViewModels/PackageManager/PublishPackageViewModel.cs b/src/DynamoCoreWpf/ViewModels/PackageManager/PublishPackageViewModel.cs
@@ -1901,6 +1901,10 @@ private void AddAdditionalFile(string filename)
             }
         }
 
+        // A boolean flag used to trigger only once the message prompt
+        // When the user has attempted to load an existing dll from another path
+        private bool duplicateAssemblyWarningTriggered = false;
+
         private void AddDllFile(string filename)
         {
             try
@@ -1914,13 +1918,14 @@ private void AddDllFile(string filename)
 
                     // The user has attempted to load an existing dll from another path. This is not allowed 
                     // as the existing assembly cannot be modified while Dynamo is active.
-                    if (this.Assemblies.Any(x => assemName == x.Assembly.GetName().Name))
+                    if (this.Assemblies.Any(x => assemName == x.Assembly.GetName().Name) && !duplicateAssemblyWarningTriggered)
                     {
                         MessageBoxService.Show(Owner, string.Format(Resources.PackageDuplicateAssemblyWarning, 
                                         dynamoViewModel.BrandingResourceProvider.ProductName),
                                         Resources.PackageDuplicateAssemblyWarningTitle, 
                                         MessageBoxButton.OK, 
                                         MessageBoxImage.Stop);
+                        duplicateAssemblyWarningTriggered = true;
                         return; // skip loading assembly
                     }
 

Original file line number	Diff line number	Diff line change
`@@ -1901,6 +1901,10 @@ private void AddAdditionalFile(string filename)`
`1901`	`1901`	`}`
`1902`	`1902`	`}`
`1903`	`1903`
	`1904`	`+ // A boolean flag used to trigger only once the message prompt`
	`1905`	`+ // When the user has attempted to load an existing dll from another path`
	`1906`	`+ private bool duplicateAssemblyWarningTriggered = false;`
	`1907`	`+`
`1904`	`1908`	`private void AddDllFile(string filename)`
`1905`	`1909`	`{`
`1906`	`1910`	`try`
`@@ -1914,13 +1918,14 @@ private void AddDllFile(string filename)`
`1914`	`1918`
`1915`	`1919`	`// The user has attempted to load an existing dll from another path. This is not allowed`
`1916`	`1920`	`// as the existing assembly cannot be modified while Dynamo is active.`
`1917`		`- if (this.Assemblies.Any(x => assemName == x.Assembly.GetName().Name))`
	`1921`	`+ if (this.Assemblies.Any(x => assemName == x.Assembly.GetName().Name) && !duplicateAssemblyWarningTriggered)`
`1918`	`1922`	`{`
`1919`	`1923`	`MessageBoxService.Show(Owner, string.Format(Resources.PackageDuplicateAssemblyWarning,`
`1920`	`1924`	`dynamoViewModel.BrandingResourceProvider.ProductName),`
`1921`	`1925`	`Resources.PackageDuplicateAssemblyWarningTitle,`
`1922`	`1926`	`MessageBoxButton.OK,`
`1923`	`1927`	`MessageBoxImage.Stop);`
	`1928`	`+ duplicateAssemblyWarningTriggered = true;`
`1924`	`1929`	`return; // skip loading assembly`
`1925`	`1930`	`}`
`1926`	`1931`