DYN-8457: Fix when inserting groups from Help doc should have correct name #2 (#15939)

zeusongit · web-flow · commit abab223ef0e6 · 2025-03-18T15:34:55.000-04:00
diff --git a/src/DocumentationBrowserViewExtension/DocumentationBrowserViewModel.cs b/src/DocumentationBrowserViewExtension/DocumentationBrowserViewModel.cs
@@ -438,7 +438,7 @@ internal void InsertGraph()
             {
                 if (GraphPath != null)
                 {
-                    var graphName = string.IsNullOrEmpty(CurrentPackageName) ? Path.GetFileNameWithoutExtension(GraphPath) : CurrentPackageName;
+                    var graphName = string.IsNullOrEmpty(CurrentPackageName) ? CurrentGraphName : CurrentPackageName;
                     raiseInsertGraph(this, new InsertDocumentationLinkEventArgs(GraphPath, graphName));
                 }
                 else
diff --git a/test/DynamoCoreWpf2Tests/ViewExtensions/DocumentationBrowserViewExtensionTests.cs b/test/DynamoCoreWpf2Tests/ViewExtensions/DocumentationBrowserViewExtensionTests.cs
@@ -807,7 +807,7 @@ public void AddGraphInSpecificLocationToWorkspace()
             Assert.AreEqual(ViewModel.Model.CurrentWorkspace.Annotations.Count(), 1);
 
             //Validates that correct group name and description was set
-            Assert.AreEqual(ViewModel.Model.CurrentWorkspace.Annotations.FirstOrDefault().AnnotationText, "BasicAddition");
+            Assert.AreEqual(ViewModel.Model.CurrentWorkspace.Annotations.FirstOrDefault().AnnotationText, "CoreNodeModels.Input.DoubleInput");
             Assert.AreEqual(ViewModel.Model.CurrentWorkspace.Annotations.FirstOrDefault().AnnotationDescriptionText, "Inserted Dynamo graph");
         }
 

Original file line number	Diff line number	Diff line change
`@@ -438,7 +438,7 @@ internal void InsertGraph()`
`438`	`438`	`{`
`439`	`439`	`if (GraphPath != null)`
`440`	`440`	`{`
`441`		`- var graphName = string.IsNullOrEmpty(CurrentPackageName) ? Path.GetFileNameWithoutExtension(GraphPath) : CurrentPackageName;`
	`441`	`+ var graphName = string.IsNullOrEmpty(CurrentPackageName) ? CurrentGraphName : CurrentPackageName;`
`442`	`442`	`raiseInsertGraph(this, new InsertDocumentationLinkEventArgs(GraphPath, graphName));`
`443`	`443`	`}`
`444`	`444`	`else`
Original file line number	Diff line number	Diff line change
`@@ -807,7 +807,7 @@ public void AddGraphInSpecificLocationToWorkspace()`
`807`	`807`	`Assert.AreEqual(ViewModel.Model.CurrentWorkspace.Annotations.Count(), 1);`
`808`	`808`
`809`	`809`	`//Validates that correct group name and description was set`
`810`		`- Assert.AreEqual(ViewModel.Model.CurrentWorkspace.Annotations.FirstOrDefault().AnnotationText, "BasicAddition");`
	`810`	`+ Assert.AreEqual(ViewModel.Model.CurrentWorkspace.Annotations.FirstOrDefault().AnnotationText, "CoreNodeModels.Input.DoubleInput");`
`811`	`811`	`Assert.AreEqual(ViewModel.Model.CurrentWorkspace.Annotations.FirstOrDefault().AnnotationDescriptionText, "Inserted Dynamo graph");`
`812`	`812`	`}`
`813`	`813`