DYN-8461: Publishing a new version of a package should reflect correct version number (#15914)

zeusongit · web-flow · commit a9a909a01e53 · 2025-03-10T13:57:53.000-04:00
diff --git a/src/DynamoCoreWpf/Views/PackageManager/Controls/NumericUpDownControl.xaml.cs b/src/DynamoCoreWpf/Views/PackageManager/Controls/NumericUpDownControl.xaml.cs
@@ -141,10 +141,8 @@ private void inputField_PreviewTextInput(object sender, TextCompositionEventArgs
         // Handles the direct input of text (via keyboard)
         private void inputField_TextChanged(object sender, TextChangedEventArgs e)
         {
-            if (Int32.TryParse(inputField.Text, out int value))
-            {
-                Value = value.ToString();
-            };
+            Int32.TryParse(inputField.Text, out int value);
+            Value = value.ToString();
         }
 
         // When user clicks on the watermark label at first, hide the watermark and pass the focus to the input textbox
diff --git a/test/DynamoCoreWpf2Tests/PackageManager/PackageManagerUITests.cs b/test/DynamoCoreWpf2Tests/PackageManager/PackageManagerUITests.cs
@@ -204,6 +204,18 @@ public void PackagePublishNumericUpDownAllowsOnlyPositiveIntegerValues()
 
             isValidOutput = updownControl.IsValidInput("1");
             Assert.IsTrue(isValidOutput, "Should allow positive integers in numeric input.");
+
+            // Arrange
+            var inputField = updownControl.inputField;
+
+            // Act & Assert
+            Assert.AreEqual("0", updownControl.Value);
+
+            inputField.Text = "1";
+            Assert.AreEqual("1", updownControl.Value);
+
+            inputField.Text = "";
+            Assert.AreEqual("0", updownControl.Value);
         }
 
         [Test]

Original file line number	Diff line number	Diff line change
`@@ -141,10 +141,8 @@ private void inputField_PreviewTextInput(object sender, TextCompositionEventArgs`
`141`	`141`	`// Handles the direct input of text (via keyboard)`
`142`	`142`	`private void inputField_TextChanged(object sender, TextChangedEventArgs e)`
`143`	`143`	`{`
`144`		`- if (Int32.TryParse(inputField.Text, out int value))`
`145`		`- {`
`146`		`- Value = value.ToString();`
`147`		`- };`
	`144`	`+ Int32.TryParse(inputField.Text, out int value);`
	`145`	`+ Value = value.ToString();`
`148`	`146`	`}`
`149`	`147`
`150`	`148`	`// When user clicks on the watermark label at first, hide the watermark and pass the focus to the input textbox`