DYN-8632 : limit some commands during dna (#16182)

BogdanZavu · zavub · web-flow · commit a469919df6d5 · 2025-05-01T10:05:58.000-04:00
Co-authored-by: Bogdan Zavu &lt;bogdan.zavu@autodesk.com&gt;
diff --git a/src/DynamoCore/Graph/Nodes/NodeModel.cs b/src/DynamoCore/Graph/Nodes/NodeModel.cs
@@ -1007,6 +1007,23 @@ internal bool IsTransient
             set;
         }
 
+        /// <summary>
+        /// Return a value indicating whether this node is connected to a transient node.
+        /// </summary>
+        internal bool HasTransientConnections()
+        {
+            var allPorts = InPorts.Concat(OutPorts);
+            foreach (var port in allPorts)
+            {
+                if (port?.HasTransientConnections() is true)
+                {
+                    return true;
+                }
+            }
+
+            return false;
+        }
+
         /// <summary>
         /// The default behavior for ModelBase objects is to not serialize the X and Y
         /// properties. This overload allows the serialization of the X property
diff --git a/src/DynamoCore/Graph/Nodes/PortModel.cs b/src/DynamoCore/Graph/Nodes/PortModel.cs
@@ -331,6 +331,21 @@ public bool IsConnected
 
         internal bool IsProxyPort { get; set; } = false;
 
+        /// <summary>
+        /// Return a value indicating whether this port is connected to a transient node.
+        /// </summary>
+        internal bool HasTransientConnections()
+        {
+            foreach(var connector in Connectors)
+            {
+                var connectedNode = PortType == PortType.Input ? connector?.Start?.Owner : connector?.End?.Owner;
+                if (connectedNode?.IsTransient is true)
+                    return true;
+            }
+
+            return false;
+        }
+
         [JsonConstructor]
         internal PortModel(string name, string toolTip)
         {
diff --git a/src/DynamoCore/Models/DynamoModelCommands.cs b/src/DynamoCore/Models/DynamoModelCommands.cs
@@ -586,6 +586,12 @@ private void DeleteModelImpl(DeleteModelCommand command)
                 modelsToDelete.AddRange(command.ModelGuids.Select(guid => CurrentWorkspace.GetModelInternal(guid)));
             }
 
+            if (!command.CanDeleteTransientNodes)
+            {
+                // Remove transient nodes from the list of models to delete.
+                modelsToDelete.RemoveAll(model => (model as NodeModel)?.IsTransient == true);
+            }
+
             DeleteModelInternal(modelsToDelete);
         }
 
diff --git a/src/DynamoCore/Models/RecordableCommands.cs b/src/DynamoCore/Models/RecordableCommands.cs
@@ -1689,6 +1689,8 @@ protected override void SerializeCore(XmlElement element)
         [DataContract]
         public class DeleteModelCommand : ModelBasedRecordableCommand
         {
+            internal bool CanDeleteTransientNodes { get; set; } = false;
+
             #region Public Class Methods
 
             /// <summary>
@@ -1710,6 +1712,16 @@ public DeleteModelCommand(Guid modelGuid) : base(new[] { modelGuid }) { }
             /// <param name="modelGuids"></param>
             public DeleteModelCommand(IEnumerable<Guid> modelGuids) : base(modelGuids) { }
 
+            /// <summary>
+            ///
+            /// </summary>
+            /// <param name="modelGuids"></param>
+            /// <param name="canDeleteTransientNodes"></param>
+            internal DeleteModelCommand(IEnumerable<Guid> modelGuids, bool canDeleteTransientNodes) : base(modelGuids)
+            {
+                CanDeleteTransientNodes = canDeleteTransientNodes;
+            }
+
             internal static DeleteModelCommand DeserializeCore(XmlElement element)
             {
                 var helper = new XmlElementHelper(element);
diff --git a/src/DynamoCoreWpf/Commands/PortCommands.cs b/src/DynamoCoreWpf/Commands/PortCommands.cs
@@ -47,7 +47,7 @@ public DelegateCommand NodePortContextMenuCommand
             {
                 if (nodePortContextMenuCommand == null)
                 {
-                    nodePortContextMenuCommand = new DelegateCommand(NodePortContextMenu);
+                    nodePortContextMenuCommand = new DelegateCommand(NodePortContextMenu, CanShowContextMenu);
                 }
                 return nodePortContextMenuCommand;
             }
diff --git a/src/DynamoCoreWpf/ViewModels/Core/PortViewModel.cs b/src/DynamoCoreWpf/ViewModels/Core/PortViewModel.cs
@@ -542,6 +542,12 @@ private void Connect(object parameter)
 
         protected bool CanConnect(object parameter)
         {
+            if (node?.IsTransient is true ||
+                PortModel?.HasTransientConnections() is true)
+            {
+                return false;
+            }
+
             return true;
         }
 
@@ -602,6 +608,17 @@ private void NodePortContextMenu(object obj)
             wsViewModel.OnRequestPortContextMenu(ShowHideFlags.Show, this);
         }
 
+        private bool CanShowContextMenu(object obj)
+        {
+            if (node?.IsTransient is true ||
+                PortModel?.HasTransientConnections() is true)
+            {
+                return false;
+            }
+
+            return true;
+        }
+
         private bool CanAutoComplete(object parameter)
         {
             DynamoViewModel dynamoViewModel = node.DynamoViewModel;
diff --git a/src/DynamoCoreWpf/Views/Core/NodeView.xaml.cs b/src/DynamoCoreWpf/Views/Core/NodeView.xaml.cs
@@ -799,6 +799,14 @@ private void StashNodeViewCustomizationMenuItems()
         /// </summary>
         private void DisplayNodeContextMenu(object sender, RoutedEventArgs e)
         {
+            if (ViewModel?.NodeModel?.IsTransient is true ||
+                ViewModel?.NodeModel?.HasTransientConnections() is true)
+            {
+                e.Handled = true;
+                return;
+            }
+
+
             Guid nodeGuid = ViewModel.NodeModel.GUID;
             ViewModel.WorkspaceViewModel.HideAllPopupCommand.Execute(sender);
             ViewModel.DynamoViewModel.ExecuteCommand(
diff --git a/src/NodeAutoCompleteViewExtension/ViewModels/NodeAutoCompleteBarViewModel.cs b/src/NodeAutoCompleteViewExtension/ViewModels/NodeAutoCompleteBarViewModel.cs
@@ -803,7 +803,7 @@ internal void DeleteTransientNodes()
             var transientNodes = wsViewModel.Nodes.Where(x => x.IsTransient).ToList();
             if (transientNodes.Any())
             {
-                dynamoViewModel.Model.ExecuteCommand(new DynamoModel.DeleteModelCommand(transientNodes.Select(x => x.Id)));
+                dynamoViewModel.Model.ExecuteCommand(new DynamoModel.DeleteModelCommand(transientNodes.Select(x => x.Id), true));
 
                 //remove the initial layout of the transient nodes from the undo stack
                 wsViewModel.Model.UndoRecorder.PopFromUndoGroup();

Original file line number	Diff line number	Diff line change
`@@ -586,6 +586,12 @@ private void DeleteModelImpl(DeleteModelCommand command)`
`586`	`586`	`modelsToDelete.AddRange(command.ModelGuids.Select(guid => CurrentWorkspace.GetModelInternal(guid)));`
`587`	`587`	`}`
`588`	`588`
	`589`	`+ if (!command.CanDeleteTransientNodes)`
	`590`	`+ {`
	`591`	`+ // Remove transient nodes from the list of models to delete.`
	`592`	`+ modelsToDelete.RemoveAll(model => (model as NodeModel)?.IsTransient == true);`
	`593`	`+ }`
	`594`	`+`
`589`	`595`	`DeleteModelInternal(modelsToDelete);`
`590`	`596`	`}`
`591`	`597`
Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,7 @@ public DelegateCommand NodePortContextMenuCommand`
`47`	`47`	`{`
`48`	`48`	`if (nodePortContextMenuCommand == null)`
`49`	`49`	`{`
`50`		`- nodePortContextMenuCommand = new DelegateCommand(NodePortContextMenu);`
	`50`	`+ nodePortContextMenuCommand = new DelegateCommand(NodePortContextMenu, CanShowContextMenu);`
`51`	`51`	`}`
`52`	`52`	`return nodePortContextMenuCommand;`
`53`	`53`	`}`
Original file line number	Diff line number	Diff line change
`@@ -803,7 +803,7 @@ internal void DeleteTransientNodes()`
`803`	`803`	`var transientNodes = wsViewModel.Nodes.Where(x => x.IsTransient).ToList();`
`804`	`804`	`if (transientNodes.Any())`
`805`	`805`	`{`
`806`		`- dynamoViewModel.Model.ExecuteCommand(new DynamoModel.DeleteModelCommand(transientNodes.Select(x => x.Id)));`
	`806`	`+ dynamoViewModel.Model.ExecuteCommand(new DynamoModel.DeleteModelCommand(transientNodes.Select(x => x.Id), true));`
`807`	`807`
`808`	`808`	`//remove the initial layout of the transient nodes from the undo stack`
`809`	`809`	`wsViewModel.Model.UndoRecorder.PopFromUndoGroup();`