DYN-4451 bug instalation spinner packages (#12931)

filipeotero · web-flow · commit 9afca3ebbcc5 · 2022-05-26T11:16:38.000-04:00
* Bug fix packages always spinning when localizaed

* adding unit tests
diff --git a/src/DynamoCoreWpf/Views/PackageManager/PackageManagerSearchView.xaml b/src/DynamoCoreWpf/Views/PackageManager/PackageManagerSearchView.xaml
@@ -966,35 +966,35 @@
                             CornerRadius="3,0,0,3" />
                     </Grid>
                     <DataTemplate.Triggers>
-                        <DataTrigger Binding="{Binding ElementName=downloadState, Path=Text}" Value="Unknown">
+                        <DataTrigger Binding="{Binding ElementName=downloadState, Path=Text}" Value="{x:Static p:Resources.PackageStateUnknown}">
                             <DataTrigger.Setters>
                                 <Setter TargetName="downloadStatusFlag" Property="Background" Value="#CC000000" />
                             </DataTrigger.Setters>
                         </DataTrigger>
-                        <DataTrigger Binding="{Binding ElementName=downloadState, Path=Text}" Value="Downloaded">
+                        <DataTrigger Binding="{Binding ElementName=downloadState, Path=Text}" Value="{x:Static p:Resources.PackageDownloadStateDownloaded}">
                             <DataTrigger.Setters>
                                 <Setter TargetName="downloadStatusFlag" Property="Background" Value="Gray" />
                             </DataTrigger.Setters>
                         </DataTrigger>
-                        <DataTrigger Binding="{Binding ElementName=downloadState, Path=Text}" Value="Downloading">
+                        <DataTrigger Binding="{Binding ElementName=downloadState, Path=Text}" Value="{x:Static p:Resources.PackageDownloadStateDownloading}">
                             <DataTrigger.Setters>
                                 <Setter TargetName="downloadStatusFlag" Property="Background" Value="Gray" />
                             </DataTrigger.Setters>
                         </DataTrigger>
-                        <DataTrigger Binding="{Binding ElementName=downloadState, Path=Text}" Value="Error">
+                        <DataTrigger Binding="{Binding ElementName=downloadState, Path=Text}" Value="{x:Static p:Resources.PackageDownloadStateError}">
                             <DataTrigger.Setters>
                                 <Setter TargetName="downloadStatusFlag" Property="Background" Value="LightCoral" />
                                 <Setter TargetName="downloadCompletedIcon" Property="Source" Value="/DynamoCoreWpf;component/UI/Images/package_error.png" />
                             </DataTrigger.Setters>
                         </DataTrigger>
-                        <DataTrigger Binding="{Binding ElementName=downloadState, Path=Text}" Value="Installed">
+                        <DataTrigger Binding="{Binding ElementName=downloadState, Path=Text}" Value="{x:Static p:Resources.PackageDownloadStateInstalled}">
                             <DataTrigger.Setters>
                                 <Setter TargetName="downloadStatusFlag" Property="Background" Value="LightBlue" />
                                 <Setter TargetName="downloadCompletedIcon" Property="Visibility" Value="Visible" />
                                 <Setter TargetName="downloadingIcon" Property="Visibility" Value="Collapsed" />
                             </DataTrigger.Setters>
                         </DataTrigger>
-                        <DataTrigger Binding="{Binding ElementName=downloadState, Path=Text}" Value="Installing">
+                        <DataTrigger Binding="{Binding ElementName=downloadState, Path=Text}" Value="{x:Static p:Resources.PackageDownloadStateInstalling}">
                             <DataTrigger.Setters>
                                 <Setter TargetName="downloadStatusFlag" Property="Background" Value="Gray" />
                             </DataTrigger.Setters>
diff --git a/test/DynamoCoreWpfTests/PackageManager/PackageManagerSearchElementViewModelTests.cs b/test/DynamoCoreWpfTests/PackageManager/PackageManagerSearchElementViewModelTests.cs
@@ -8,6 +8,7 @@
 using Dynamo.ViewModels;
 using System.Collections.Generic;
 using static Dynamo.PackageManager.PackageManagerSearchViewModel;
+using Dynamo.Controls;
 
 namespace Dynamo.PackageManager.Wpf.Tests
 {
@@ -102,6 +103,57 @@ public void TestPackageManagerSearchElementCanInstall()
             packageManagerSearchViewModel.ClearSearchResults();
         }
 
+
+        /// <summary>
+        /// A test to ensure that the label converted is equal the resources when localized
+        /// </summary>
+        [Test]
+        public void TestPackageManagerInstallStatusByResourceName()
+        {
+            var name1 = "package";
+            var version = "1.0.0";         
+
+            var dHandle1 = new PackageDownloadHandle()
+            {
+                Id = name1,
+                VersionName = version,
+                Name = name1
+            };
+
+            dHandle1.DownloadState = PackageDownloadHandle.State.Installed;
+
+            var download1State = new PackageDownloadStateToStringConverter().Convert(dHandle1.DownloadState, null, null, null).ToString();
+            Assert.IsTrue(download1State.Equals(Dynamo.Wpf.Properties.Resources.PackageDownloadStateInstalled));
+
+            dHandle1.DownloadState = PackageDownloadHandle.State.Installing;
+
+            download1State = new PackageDownloadStateToStringConverter().Convert(dHandle1.DownloadState, null, null, null).ToString();
+            Assert.IsTrue(download1State.Equals(Dynamo.Wpf.Properties.Resources.PackageDownloadStateInstalling));
+
+            dHandle1.DownloadState = PackageDownloadHandle.State.Downloaded;
+
+            download1State = new PackageDownloadStateToStringConverter().Convert(dHandle1.DownloadState, null, null, null).ToString();
+            Assert.IsTrue(download1State.Equals(Dynamo.Wpf.Properties.Resources.PackageDownloadStateDownloaded));
+            
+            dHandle1.DownloadState = PackageDownloadHandle.State.Downloading;
+
+            download1State = new PackageDownloadStateToStringConverter().Convert(dHandle1.DownloadState, null, null, null).ToString();
+            Assert.IsTrue(download1State.Equals(Dynamo.Wpf.Properties.Resources.PackageDownloadStateDownloading));
+
+            dHandle1.DownloadState = PackageDownloadHandle.State.Error;
+
+            download1State = new PackageDownloadStateToStringConverter().Convert(dHandle1.DownloadState, null, null, null).ToString();
+            Assert.IsTrue(download1State.Equals(Dynamo.Wpf.Properties.Resources.PackageDownloadStateError));
+
+            dHandle1.DownloadState = PackageDownloadHandle.State.Uninitialized;
+
+            download1State = new PackageDownloadStateToStringConverter().Convert(dHandle1.DownloadState, null, null, null).ToString();
+            Assert.IsTrue(download1State.Equals(Dynamo.Wpf.Properties.Resources.PackageDownloadStateStarting));
+
+            download1State = new PackageDownloadStateToStringConverter().Convert(null, null, null, null).ToString();
+            Assert.IsTrue(download1State.Equals(Dynamo.Wpf.Properties.Resources.PackageStateUnknown));
+        }
+
         /// <summary>
         /// This unit test will validate that after we set the filters in the package search, we will get an intersection of the results (instead of a union)
         /// </summary>
