DYN-7570 Purple package nodes overlay for non-custom nodes (#15532)

dnenov · web-flow · commit 99dc05a6aed9 · 2024-10-09T12:52:40.000-04:00
diff --git a/src/DynamoCore/Graph/Nodes/NodeModelExtensions.cs b/src/DynamoCore/Graph/Nodes/NodeModelExtensions.cs
@@ -177,7 +177,7 @@ internal static string GetOriginalName(this NodeModel node)
         internal static string GetPackageName(this NodeModel node, Workspaces.PackageInfo packageInfo)
         {
             // Only return package name if the node comes from a package
-            if (node == null || !node.IsCustomFunction || packageInfo == null) return string.Empty;
+            if (node == null || packageInfo == null) return string.Empty;
 
             return packageInfo?.Name;
         }
diff --git a/src/DynamoCoreWpf/ViewModels/Core/NodeViewModel.cs b/src/DynamoCoreWpf/ViewModels/Core/NodeViewModel.cs
@@ -1356,11 +1356,11 @@ Pass through all possible states in reverse order
                 } 
             }
 
-            if (this.NodeModel.IsCustomFunction)
+            if (this.NodeModel.IsCustomFunction || !string.IsNullOrEmpty(this.PackageName))
             {
                 result = nodeCustomColor;
                 if(result != null)
-                {
+                {   
                     if (ImgGlyphOneSource == null)
                     {
                         ImgGlyphOneSource = packageGlyph;

Original file line number	Diff line number	Diff line change
`@@ -177,7 +177,7 @@ internal static string GetOriginalName(this NodeModel node)`
`177`	`177`	`internal static string GetPackageName(this NodeModel node, Workspaces.PackageInfo packageInfo)`
`178`	`178`	`{`
`179`	`179`	`// Only return package name if the node comes from a package`
`180`		`- if (node == null \|\| !node.IsCustomFunction \|\| packageInfo == null) return string.Empty;`
	`180`	`+ if (node == null \|\| packageInfo == null) return string.Empty;`
`181`	`181`
`182`	`182`	`return packageInfo?.Name;`
`183`	`183`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1356,11 +1356,11 @@ Pass through all possible states in reverse order`
`1356`	`1356`	`}`
`1357`	`1357`	`}`
`1358`	`1358`
`1359`		`- if (this.NodeModel.IsCustomFunction)`
	`1359`	`+ if (this.NodeModel.IsCustomFunction \|\| !string.IsNullOrEmpty(this.PackageName))`
`1360`	`1360`	`{`
`1361`	`1361`	`result = nodeCustomColor;`
`1362`	`1362`	`if(result != null)`
`1363`		`- {`
	`1363`	`+ {`
`1364`	`1364`	`if (ImgGlyphOneSource == null)`
`1365`	`1365`	`{`
`1366`	`1366`	`ImgGlyphOneSource = packageGlyph;`