DYN-8947 - Add transient state to connectors (#16247)

johnpierson · Copilot · web-flow · commit 951cefe31a93 · 2025-06-06T08:11:16.000-06:00
Co-authored-by: Copilot &lt;175728472+Copilot@users.noreply.github.com&gt;
diff --git a/src/DynamoCore/Graph/Connectors/ConnectorModel.cs b/src/DynamoCore/Graph/Connectors/ConnectorModel.cs
@@ -47,6 +47,21 @@ public bool IsHidden
                 RaisePropertyChanged(nameof(IsHidden));
             }
         }
+
+        private bool isTransient = false;
+        /// <summary>
+        /// IsTransient flag controlling the transient state of the connector
+        /// </summary>
+        internal bool IsTransient
+        {
+            get { return isTransient; }
+            set
+            {
+                isTransient = value;
+                RaisePropertyChanged(nameof(IsTransient));
+            }
+        }
+        
         /// <summary>
         /// Returns start port model.
         /// </summary>
diff --git a/src/DynamoCoreWpf/PublicAPI.Unshipped.txt b/src/DynamoCoreWpf/PublicAPI.Unshipped.txt
@@ -139,6 +139,8 @@ Dynamo.Controls.ConnectionStateToBrushConverter.NoneBrush.get -> System.Windows.
 Dynamo.Controls.ConnectionStateToBrushConverter.NoneBrush.set -> void
 Dynamo.Controls.ConnectionStateToBrushConverter.SelectionBrush.get -> System.Windows.Media.SolidColorBrush
 Dynamo.Controls.ConnectionStateToBrushConverter.SelectionBrush.set -> void
+Dynamo.Controls.ConnectionStateToBrushConverter.TransientBrush.get -> System.Windows.Media.SolidColorBrush
+Dynamo.Controls.ConnectionStateToBrushConverter.TransientBrush.set -> void
 Dynamo.Controls.ConnectionStateToColorConverter
 Dynamo.Controls.ConnectionStateToColorConverter.ConnectionStateToColorConverter() -> void
 Dynamo.Controls.ConnectionStateToColorConverter.Convert(object value, System.Type targetType, object parameter, System.Globalization.CultureInfo culture) -> object
@@ -151,6 +153,8 @@ Dynamo.Controls.ConnectionStateToColorConverter.None.get -> System.Windows.Media
 Dynamo.Controls.ConnectionStateToColorConverter.None.set -> void
 Dynamo.Controls.ConnectionStateToColorConverter.Selection.get -> System.Windows.Media.Color
 Dynamo.Controls.ConnectionStateToColorConverter.Selection.set -> void
+Dynamo.Controls.ConnectionStateToColorConverter.Transient.get -> System.Windows.Media.Color
+Dynamo.Controls.ConnectionStateToColorConverter.Transient.set -> void
 Dynamo.Controls.ConnectionStateToVisibilityCollapsedConverter
 Dynamo.Controls.ConnectionStateToVisibilityCollapsedConverter.ConnectionStateToVisibilityCollapsedConverter() -> void
 Dynamo.Controls.ConnectionStateToVisibilityCollapsedConverter.Convert(object value, System.Type targetType, object parameter, System.Globalization.CultureInfo culture) -> object
@@ -2943,6 +2947,7 @@ Dynamo.ViewModels.PreviewState
 Dynamo.ViewModels.PreviewState.ExecutionPreview = 1 -> Dynamo.ViewModels.PreviewState
 Dynamo.ViewModels.PreviewState.Hover = 2 -> Dynamo.ViewModels.PreviewState
 Dynamo.ViewModels.PreviewState.None = 3 -> Dynamo.ViewModels.PreviewState
+Dynamo.ViewModels.PreviewState.Transient = 4 -> Dynamo.ViewModels.PreviewState
 Dynamo.ViewModels.PreviewState.Selection = 0 -> Dynamo.ViewModels.PreviewState
 Dynamo.ViewModels.PythonTemplatePathEventArgs
 Dynamo.ViewModels.PythonTemplatePathEventArgs.Cancel.get -> bool
diff --git a/src/DynamoCoreWpf/UI/Converters.cs b/src/DynamoCoreWpf/UI/Converters.cs
@@ -800,6 +800,7 @@ public class ConnectionStateToBrushConverter : IValueConverter
         public SolidColorBrush ExecutionPreviewBrush { get; set; }
         public SolidColorBrush NoneBrush { get; set; }
         public SolidColorBrush SelectionBrush { get; set; }
+        public SolidColorBrush TransientBrush { get; set; }
 
         public SolidColorBrush HoverBrush { get; set; }
 
@@ -808,6 +809,8 @@ public object Convert(object value, Type targetType, object parameter, CultureIn
             var state = (PreviewState)value;
             switch (state)
             {
+                case PreviewState.Transient:
+                    return TransientBrush;
                 case PreviewState.ExecutionPreview:
                     return ExecutionPreviewBrush;
                 case PreviewState.None:
@@ -833,12 +836,15 @@ public class ConnectionStateToColorConverter : IValueConverter
         public Color None { get; set; }
         public Color Selection { get; set; }
         public Color Hover { get; set; }
+        public Color Transient { get; set; }
 
         public object Convert(object value, Type targetType, object parameter, CultureInfo culture)
         {
             var state = (PreviewState)value;
             switch (state)
             {
+                case PreviewState.Transient:
+                    return Transient;
                 case PreviewState.ExecutionPreview:
                     return ExecutionPreview;
                 case PreviewState.None:
diff --git a/src/DynamoCoreWpf/UI/Themes/Modern/Connectors.xaml b/src/DynamoCoreWpf/UI/Themes/Modern/Connectors.xaml
@@ -1,4 +1,4 @@
-﻿<ResourceDictionary   xmlns="https://schemas.microsoft.com/winfx/2006/xaml/presentation"
+<ResourceDictionary   xmlns="https://schemas.microsoft.com/winfx/2006/xaml/presentation"
                       xmlns:x="https://schemas.microsoft.com/winfx/2006/xaml" 
                       xmlns:viewModels="clr-namespace:Dynamo.ViewModels;assembly=DynamoCoreWpf"
                       xmlns:ui="clr-namespace:Dynamo.UI;assembly=DynamoCoreWpf"
@@ -168,4 +168,4 @@
         </DataTemplate.Triggers>
     </DataTemplate>
 
-</ResourceDictionary>
+</ResourceDictionary>
diff --git a/src/DynamoCoreWpf/UI/Themes/Modern/DynamoConverters.xaml b/src/DynamoCoreWpf/UI/Themes/Modern/DynamoConverters.xaml
@@ -35,13 +35,15 @@
                                               ExecutionPreview="#F2930C"
                                               Hover="#808080"
                                               None="#444"
-                                              Selection="#6AC0E7" />
+                                              Selection="#6AC0E7"
+                                              Transient="#D5BCF7"/>
 
     <controls:ConnectionStateToBrushConverter x:Key="ConnectionStateToBrushConverter"
                                               ExecutionPreviewBrush="#F2930C"
                                               HoverBrush="#808080"
                                               NoneBrush="#444"
-                                              SelectionBrush="#6AC0E7" />
+                                              SelectionBrush="#6AC0E7"
+                                              TransientBrush="#D5BCF7"/>
 
     <controls:ConnectionStateToVisibilityCollapsedConverter x:Key="ConnectionStateToVisibilityCollapsedConverter" />
     <controls:AttachmentToPathConverter x:Key="AttachmentToPathConverter" />
diff --git a/src/DynamoCoreWpf/ViewModels/Core/ConnectorViewModel.cs b/src/DynamoCoreWpf/ViewModels/Core/ConnectorViewModel.cs
@@ -20,7 +20,7 @@
 
 namespace Dynamo.ViewModels
 {
-    public enum PreviewState { Selection, ExecutionPreview, Hover, None }
+    public enum PreviewState { Selection, ExecutionPreview, Hover, None, Transient  }
 
     public partial class ConnectorViewModel : ViewModelBase
     {
@@ -38,6 +38,7 @@ public partial class ConnectorViewModel : ViewModelBase
         private bool isConnecting = false;
         private bool isCollapsed = false;
         private bool isHidden = false;
+        private bool isTransient = false;
         private bool isTemporarilyVisible = false;
         private string connectorDataToolTip;
         private bool canShowConnectorTooltip = true;
@@ -199,6 +200,22 @@ public bool IsHidden
             }
         }
 
+        internal bool IsTransient
+        {
+            get => isTransient;
+            set
+            {
+                if (isTransient == value)
+                {
+                    return;
+                }
+
+                isTransient = value;
+                RaisePropertyChanged(nameof(IsTransient));
+                RaisePropertyChanged(nameof(PreviewState));
+            }
+        }
+
         /// <summary>
         /// Property which overrides 'isDisplayed==false' condition. When this prop is set to true, wires are set to 
         /// 40% opacity.
@@ -505,6 +522,11 @@ public PreviewState PreviewState
                     return PreviewState.None;
                 }
 
+                if (IsTransient)
+                {
+                    return PreviewState.Transient;
+                }
+
                 if (Nodevm.ShowExecutionPreview || NodeEnd.ShowExecutionPreview)
                 {
                     return PreviewState.ExecutionPreview;
diff --git a/src/NodeAutoCompleteViewExtension/ViewModels/NodeAutoCompleteBarViewModel.cs b/src/NodeAutoCompleteViewExtension/ViewModels/NodeAutoCompleteBarViewModel.cs
@@ -282,10 +282,10 @@ internal void ConsolidateTransientNodes()
             }
 
             //set the last connector to be connected
-            var transientConnectors = node.WorkspaceViewModel.Connectors.Where(c => c.IsConnecting).ToList();
+            var transientConnectors = node.WorkspaceViewModel.Connectors.Where(c => c.IsTransient).ToList();
             foreach (var connector in transientConnectors)
             {
-                connector.IsConnecting = false;
+                connector.IsTransient = false;
             }
 
             NodeAutoCompleteUtilities.PostAutoLayoutNodes(node.WorkspaceViewModel.Model, node.NodeModel, transientNodes.Select(x => x.NodeModel), true, true, false, null);
@@ -869,7 +869,7 @@ internal void AddCluster(ClusterResultItem clusterResultItem)
                 {
                     entryConnector.IsHidden = true;
                     var entryConnectorViewModel = workspaceViewModel.Connectors.First(c => c.ConnectorModel.Equals(entryConnector));
-                    entryConnectorViewModel.IsConnecting = true;
+                    entryConnectorViewModel.IsTransient = true;
                     createdClusterItems.Add(entryConnector);
                 }
             }
@@ -893,6 +893,10 @@ internal void AddCluster(ClusterResultItem clusterResultItem)
                             {
                                 newConnector.IsHidden = true; // Hide the connector initially
                                 createdClusterItems.Add(newConnector);
+
+                                // toggle to be transient for preview purposes
+                                var newConnectorViewModel = workspaceViewModel.Connectors.First(c => c.ConnectorModel.Equals(newConnector));
+                                newConnectorViewModel.IsTransient = true;
                             }
                         }
                     }

Original file line number	Diff line number	Diff line change
`@@ -282,10 +282,10 @@ internal void ConsolidateTransientNodes()`
`282`	`282`	`}`
`283`	`283`
`284`	`284`	`//set the last connector to be connected`
`285`		`- var transientConnectors = node.WorkspaceViewModel.Connectors.Where(c => c.IsConnecting).ToList();`
	`285`	`+ var transientConnectors = node.WorkspaceViewModel.Connectors.Where(c => c.IsTransient).ToList();`
`286`	`286`	`foreach (var connector in transientConnectors)`
`287`	`287`	`{`
`288`		`- connector.IsConnecting = false;`
	`288`	`+ connector.IsTransient = false;`
`289`	`289`	`}`
`290`	`290`
`291`	`291`	`NodeAutoCompleteUtilities.PostAutoLayoutNodes(node.WorkspaceViewModel.Model, node.NodeModel, transientNodes.Select(x => x.NodeModel), true, true, false, null);`
`@@ -869,7 +869,7 @@ internal void AddCluster(ClusterResultItem clusterResultItem)`
`869`	`869`	`{`
`870`	`870`	`entryConnector.IsHidden = true;`
`871`	`871`	`var entryConnectorViewModel = workspaceViewModel.Connectors.First(c => c.ConnectorModel.Equals(entryConnector));`
`872`		`- entryConnectorViewModel.IsConnecting = true;`
	`872`	`+ entryConnectorViewModel.IsTransient = true;`
`873`	`873`	`createdClusterItems.Add(entryConnector);`
`874`	`874`	`}`
`875`	`875`	`}`
`@@ -893,6 +893,10 @@ internal void AddCluster(ClusterResultItem clusterResultItem)`
`893`	`893`	`{`
`894`	`894`	`newConnector.IsHidden = true; // Hide the connector initially`
`895`	`895`	`createdClusterItems.Add(newConnector);`
	`896`	`+`
	`897`	`+ // toggle to be transient for preview purposes`
	`898`	`+ var newConnectorViewModel = workspaceViewModel.Connectors.First(c => c.ConnectorModel.Equals(newConnector));`
	`899`	`+ newConnectorViewModel.IsTransient = true;`
`896`	`900`	`}`
`897`	`901`	`}`
`898`	`902`	`}`