CARVIEW |
Select Language
HTTP/2 200
date: Thu, 31 Jul 2025 03:41:02 GMT
content-type: text/html; charset=utf-8
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-repository-download: git clone https://github.com/DynamoDS/Dynamo.git
etag: W/"261335f911a750e715ab9a7d4a604b09"
cache-control: max-age=0, private, must-revalidate
strict-transport-security: max-age=31536000; includeSubdomains; preload
x-frame-options: deny
x-content-type-options: nosniff
x-xss-protection: 0
referrer-policy: no-referrer-when-downgrade
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=Mz%2BQRt%2FqbDoQS66hR8AxbS2n%2BddHM6cZlkjN2uhJdLY2c0GVZeYmBFvNnNL6YnHyKijUg%2FTe%2FP0Imzxkl1%2Bsbs4OEweAK0XuOQ3gE11dyP78Oh04C5LUDJa7HKlEuUnSbA4cHwUe8bv56roH3K9QX5Hs3iXx64fYg53w7%2BdvwDNKk%2BPDxEYnjBP6gpNdNS0TsMVfB077ahbiS%2F3VWg0Jk%2BKH%2BdbpGO4YWqb8X2pMHQwNv68j%2BWmHmnLiV%2FmRsR4srtuMSfhkbHHgbiwOXcgSfA%3D%3D--E22JFNBk5Z%2BMU%2FYp--Rd6MstA39FhQKBfRyDveGw%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.2057942891.1753933261; Path=/; Domain=github.com; Expires=Fri, 31 Jul 2026 03:41:01 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Fri, 31 Jul 2026 03:41:01 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: A4BE:2291D2:1DE53A:2BD62A:688AE5CD
Package B should not overwrite CustomNodes defined in Package A (#9841) · DynamoDS/Dynamo@8d47577 · GitHub
Copy file name to clipboardExpand all lines: src/DynamoCore/Core/CustomNodeDefinition.cs
Copy file name to clipboardExpand all lines: src/DynamoCore/Core/CustomNodeManager.cs
Copy file name to clipboardExpand all lines: src/DynamoCore/Graph/Workspaces/PackageDependencyInfo.cs
Copy file name to clipboardExpand all lines: src/DynamoCore/Properties/Resources.Designer.cs
Copy file name to clipboardExpand all lines: src/DynamoCore/Properties/Resources.en-US.resx
Copy file name to clipboardExpand all lines: src/DynamoCore/Properties/Resources.resx
Copy file name to clipboardExpand all lines: src/DynamoCoreWpf/Properties/Resources.Designer.cs
Copy file name to clipboardExpand all lines: src/DynamoCoreWpf/Properties/Resources.en-US.resx
Copy file name to clipboardExpand all lines: src/DynamoCoreWpf/Properties/Resources.resx
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 659
Commit 8d47577
authored
Package B should not overwrite CustomNodes defined in Package A (#9841)
* remove testMode
fix tests
pass PackageInfo around
add PackageInfo to customNodeInfo class
use it to throw exceptions
change message when installing package that already is installed.
* add new tests
finish removing test mode
add new package
* update test
* update test and package json
* try using package manger to keep packageInfo up to date on customNodeInfo objects
use correct customNodeLoading method from Package object when publishing a package
update test
* add logging for different case to setInfo
* update message for feedback when package overwrites non package custom node
address some review comments
add some tech debt test cases1 parent 9c9e47a commit 8d47577Copy full SHA for 8d47577
File tree
Expand file treeCollapse file tree
21 files changed
+923
-58
lines changedFilter options
- src
- DynamoCoreWpf
- Properties
- ViewModels/PackageManager
- DynamoCore
- Core
- Graph/Workspaces
- Properties
- DynamoPackages
- test
- DynamoCoreTests
- DynamoCoreWpfTests
- Libraries/PackageManagerTests
- ViewExtensionLibraryTests
- pkgs/PackageThatWillBeModified
- dyf
Expand file treeCollapse file tree
21 files changed
+923
-58
lines changedsrc/DynamoCore/Core/CustomNodeDefinition.cs
Copy file name to clipboardExpand all lines: src/DynamoCore/Core/CustomNodeDefinition.cs+8-2Lines changed: 8 additions & 2 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
5 | 5 |
| |
6 | 6 |
| |
7 | 7 |
| |
| 8 | + | |
8 | 9 |
| |
9 | 10 |
| |
10 | 11 |
| |
| |||
298 | 299 |
| |
299 | 300 |
| |
300 | 301 |
| |
301 |
| - | |
302 | 302 |
| |
303 | 303 |
| |
304 | 304 |
| |
305 | 305 |
| |
306 |
| - | |
307 | 306 |
| |
308 | 307 |
| |
309 | 308 |
| |
| |||
340 | 339 |
| |
341 | 340 |
| |
342 | 341 |
| |
| 342 | + | |
| 343 | + | |
| 344 | + | |
| 345 | + | |
| 346 | + | |
| 347 | + | |
| 348 | + | |
343 | 349 |
| |
344 | 350 |
|
src/DynamoCore/Core/CustomNodeManager.cs
Copy file name to clipboardExpand all lines: src/DynamoCore/Core/CustomNodeManager.cs+106-27Lines changed: 106 additions & 27 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
120 | 120 |
| |
121 | 121 |
| |
122 | 122 |
| |
123 |
| - | |
| 123 | + | |
124 | 124 |
| |
125 | 125 |
| |
126 | 126 |
| |
| |||
129 | 129 |
| |
130 | 130 |
| |
131 | 131 |
| |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
132 | 140 |
| |
| 141 | + | |
133 | 142 |
| |
134 | 143 |
| |
135 | 144 |
| |
| |||
342 | 351 |
| |
343 | 352 |
| |
344 | 353 |
| |
345 |
| - | |
| 354 | + | |
346 | 355 |
| |
347 | 356 |
| |
348 | 357 |
| |
| |||
398 | 407 |
| |
399 | 408 |
| |
400 | 409 |
| |
401 |
| - | |
| 410 | + | |
| 411 | + | |
| 412 | + | |
| 413 | + | |
| 414 | + | |
| 415 | + | |
| 416 | + | |
| 417 | + | |
| 418 | + | |
| 419 | + | |
| 420 | + | |
| 421 | + | |
| 422 | + | |
| 423 | + | |
| 424 | + | |
| 425 | + | |
| 426 | + | |
| 427 | + | |
| 428 | + | |
| 429 | + | |
| 430 | + | |
| 431 | + | |
| 432 | + | |
| 433 | + | |
| 434 | + | |
| 435 | + | |
| 436 | + | |
402 | 437 |
| |
403 | 438 |
| |
404 | 439 |
| |
| |||
440 | 475 |
| |
441 | 476 |
| |
442 | 477 |
| |
443 |
| - | |
444 |
| - | |
| 478 | + | |
| 479 | + | |
445 | 480 |
| |
446 |
| - | |
| 481 | + | |
447 | 482 |
| |
448 | 483 |
| |
449 | 484 |
| |
450 | 485 |
| |
451 | 486 |
| |
452 | 487 |
| |
453 | 488 |
| |
| 489 | + | |
454 | 490 |
| |
455 | 491 |
| |
456 | 492 |
| |
457 | 493 |
| |
458 | 494 |
| |
| 495 | + | |
| 496 | + | |
| 497 | + | |
| 498 | + | |
| 499 | + | |
| 500 | + | |
| 501 | + | |
| 502 | + | |
| 503 | + | |
| 504 | + | |
| 505 | + | |
| 506 | + | |
| 507 | + | |
| 508 | + | |
| 509 | + | |
| 510 | + | |
| 511 | + | |
459 | 512 |
| |
460 |
| - | |
| 513 | + | |
| 514 | + | |
461 | 515 |
| |
462 |
| - | |
| 516 | + | |
463 | 517 |
| |
464 | 518 |
| |
465 | 519 |
| |
466 | 520 |
| |
467 |
| - | |
468 |
| - | |
| 521 | + | |
| 522 | + | |
| 523 | + | |
| 524 | + | |
| 525 | + | |
| 526 | + | |
| 527 | + | |
| 528 | + | |
| 529 | + | |
| 530 | + | |
| 531 | + | |
| 532 | + | |
| 533 | + | |
| 534 | + | |
| 535 | + | |
| 536 | + | |
| 537 | + | |
| 538 | + | |
| 539 | + | |
| 540 | + | |
| 541 | + | |
| 542 | + | |
| 543 | + | |
| 544 | + | |
| 545 | + | |
| 546 | + | |
| 547 | + | |
| 548 | + | |
| 549 | + | |
469 | 550 |
| |
470 |
| - | |
471 |
| - | |
472 | 551 |
| |
473 |
| - | |
474 | 552 |
| |
475 | 553 |
| |
476 | 554 |
| |
| |||
663 | 741 |
| |
664 | 742 |
| |
665 | 743 |
| |
666 |
| - | |
| 744 | + | |
667 | 745 |
| |
668 | 746 |
| |
669 | 747 |
| |
| |||
675 | 753 |
| |
676 | 754 |
| |
677 | 755 |
| |
678 |
| - | |
| 756 | + | |
679 | 757 |
| |
680 | 758 |
| |
681 | 759 |
| |
| |||
709 | 787 |
| |
710 | 788 |
| |
711 | 789 |
| |
712 |
| - | |
| 790 | + | |
713 | 791 |
| |
714 | 792 |
| |
715 | 793 |
| |
716 | 794 |
| |
717 |
| - | |
| 795 | + | |
718 | 796 |
| |
719 | 797 |
| |
720 | 798 |
| |
721 | 799 |
| |
722 |
| - | |
| 800 | + | |
723 | 801 |
| |
724 | 802 |
| |
725 | 803 |
| |
726 |
| - | |
| 804 | + | |
727 | 805 |
| |
728 | 806 |
| |
729 | 807 |
| |
| |||
734 | 812 |
| |
735 | 813 |
| |
736 | 814 |
| |
737 |
| - | |
738 |
| - | |
| 815 | + | |
| 816 | + | |
739 | 817 |
| |
740 | 818 |
| |
741 | 819 |
| |
742 | 820 |
| |
743 |
| - | |
| 821 | + | |
| 822 | + | |
744 | 823 |
| |
745 | 824 |
| |
746 | 825 |
| |
| |||
782 | 861 |
| |
783 | 862 |
| |
784 | 863 |
| |
785 |
| - | |
| 864 | + | |
786 | 865 |
| |
787 | 866 |
| |
788 | 867 |
| |
| |||
791 | 870 |
| |
792 | 871 |
| |
793 | 872 |
| |
794 |
| - | |
| 873 | + | |
795 | 874 |
| |
796 | 875 |
| |
797 | 876 |
| |
| |||
821 | 900 |
| |
822 | 901 |
| |
823 | 902 |
| |
824 |
| - | |
| 903 | + | |
825 | 904 |
| |
826 | 905 |
| |
827 | 906 |
| |
| |||
838 | 917 |
| |
839 | 918 |
| |
840 | 919 |
| |
841 |
| - | |
| 920 | + | |
842 | 921 |
| |
843 | 922 |
| |
844 | 923 |
| |
| |||
1264 | 1343 |
| |
1265 | 1344 |
| |
1266 | 1345 |
| |
1267 |
| - | |
| 1346 | + | |
1268 | 1347 |
| |
1269 | 1348 |
| |
1270 | 1349 |
| |
|
src/DynamoCore/Graph/Workspaces/PackageDependencyInfo.cs
Copy file name to clipboardExpand all lines: src/DynamoCore/Graph/Workspaces/PackageDependencyInfo.cs+1-1Lines changed: 1 addition & 1 deletion
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
6 | 6 |
| |
7 | 7 |
| |
8 | 8 |
| |
9 |
| - | |
| 9 | + | |
10 | 10 |
| |
11 | 11 |
| |
12 | 12 |
| |
|
src/DynamoCore/Properties/Resources.Designer.cs
Copy file name to clipboardExpand all lines: src/DynamoCore/Properties/Resources.Designer.cs+9Lines changed: 9 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
src/DynamoCore/Properties/Resources.en-US.resx
Copy file name to clipboardExpand all lines: src/DynamoCore/Properties/Resources.en-US.resx+3Lines changed: 3 additions & 0 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
706 | 706 |
| |
707 | 707 |
| |
708 | 708 |
| |
| 709 | + | |
| 710 | + | |
| 711 | + | |
709 | 712 |
|
src/DynamoCore/Properties/Resources.resx
Copy file name to clipboardExpand all lines: src/DynamoCore/Properties/Resources.resx+3Lines changed: 3 additions & 0 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
706 | 706 |
| |
707 | 707 |
| |
708 | 708 |
| |
| 709 | + | |
| 710 | + | |
| 711 | + | |
709 | 712 |
|
src/DynamoCoreWpf/Properties/Resources.Designer.cs
Copy file name to clipboardExpand all lines: src/DynamoCoreWpf/Properties/Resources.Designer.cs+9Lines changed: 9 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
src/DynamoCoreWpf/Properties/Resources.en-US.resx
Copy file name to clipboardExpand all lines: src/DynamoCoreWpf/Properties/Resources.en-US.resx+3Lines changed: 3 additions & 0 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
2216 | 2216 |
| |
2217 | 2217 |
| |
2218 | 2218 |
| |
| 2219 | + | |
| 2220 | + | |
| 2221 | + | |
2219 | 2222 |
|
src/DynamoCoreWpf/Properties/Resources.resx
Copy file name to clipboardExpand all lines: src/DynamoCoreWpf/Properties/Resources.resx+3Lines changed: 3 additions & 0 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
2219 | 2219 |
| |
2220 | 2220 |
| |
2221 | 2221 |
| |
| 2222 | + | |
| 2223 | + | |
| 2224 | + | |
2222 | 2225 |
|
You can’t perform that action at this time.
0 commit comments