8888: DYN-9176 : optimize graph execution for dna (#16374)

BogdanZavu · zavub · web-flow · commit 76dd8a9d00a9 · 2025-07-14T12:42:19.000-04:00
Co-authored-by: Bogdan Zavu &lt;bogdan.zavu@autodesk.com&gt;
diff --git a/src/DynamoCore/Graph/Workspaces/HomeWorkspaceModel.cs b/src/DynamoCore/Graph/Workspaces/HomeWorkspaceModel.cs
@@ -474,7 +474,7 @@ protected override void NodeModified(NodeModel node)
         {
             base.NodeModified(node);
 
-            if (!silenceNodeModifications)
+            if (!silenceNodeModifications && !node.IsTransient)
             {
                 RequestRun();
             }
diff --git a/src/DynamoCore/Graph/Workspaces/LayoutExtensions.cs b/src/DynamoCore/Graph/Workspaces/LayoutExtensions.cs
@@ -752,7 +752,7 @@ private static void SaveLayoutGraphForNodeAutoComplete(WorkspaceModel workspace,
                         node.Y = n.Y + n.NotesHeight + offsetY;
                     }
                     node.ReportPosition();
-                    workspace.HasUnsavedChanges = true;
+                    //workspace.HasUnsavedChanges = true;
 
                     double noteOffset = -n.NotesHeight;
                     foreach (NoteModel note in n.LinkedNotes)
diff --git a/src/DynamoCore/Graph/Workspaces/WorkspaceModel.cs b/src/DynamoCore/Graph/Workspaces/WorkspaceModel.cs
@@ -1633,12 +1633,12 @@ internal void AddAndRegisterNode(NodeModel node, bool centered = false)
 
             AddNode(node);
 
-            HasUnsavedChanges = true;
-
-            if (node is CodeBlockNodeModel cbn
-                && string.IsNullOrEmpty(cbn.Code)) return;
-
-            RequestRun();
+            if (!node.IsTransient)
+            {
+                HasUnsavedChanges = true;
+                if (node is CodeBlockNodeModel cbn && string.IsNullOrEmpty(cbn.Code)) return;
+                RequestRun();
+            }
         }
 
         protected virtual void RegisterNode(NodeModel node)
@@ -1670,6 +1670,11 @@ internal virtual void RequestRun()
         /// </summary>
         protected virtual void NodeModified(NodeModel node)
         {
+            if (node.IsTransient)
+            {
+                return;
+            }
+
             HasUnsavedChanges = true;
         }
 
@@ -1689,7 +1694,10 @@ internal void RemoveAndDisposeNode(NodeModel model, bool dispose = true)
             OnNodeRemoved(model);
             // Force this change to address the edge case that user deleting the right edge
             // node and do not see unsaved changes, e.g. the watch node at end of the graph
-            HasUnsavedChanges = true;
+            if (!model.IsTransient)
+            {
+                HasUnsavedChanges = true;
+            }
 
             if (dispose)
             {
diff --git a/src/NodeAutoCompleteViewExtension/ViewModels/NodeAutoCompleteBarViewModel.cs b/src/NodeAutoCompleteViewExtension/ViewModels/NodeAutoCompleteBarViewModel.cs
@@ -323,11 +323,7 @@ internal void ConsolidateTransientNodes()
 
             NodeAutoCompleteUtilities.PostAutoLayoutNodes(node.WorkspaceViewModel.Model, node.NodeModel, transientNodes.Select(x => x.NodeModel), true, true, PortViewModel.PortType, null);
 
-            if (PortViewModel.PortType == PortType.Input)
-            {
-                node.NodeModel.MarkNodeAsModified();
-            }
-
+            node.WorkspaceViewModel.Model.HasUnsavedChanges = true;
             (node.WorkspaceViewModel.Model as HomeWorkspaceModel)?.MarkNodesAsModifiedAndRequestRun(transientNodes.Select(x => x.NodeModel));
 
             //add the new items to the undo recorder (this ensures the elements are valid at this point in time before any other manipulation occurs)

Original file line number	Diff line number	Diff line change
`@@ -474,7 +474,7 @@ protected override void NodeModified(NodeModel node)`
`474`	`474`	`{`
`475`	`475`	`base.NodeModified(node);`
`476`	`476`
`477`		`- if (!silenceNodeModifications)`
	`477`	`+ if (!silenceNodeModifications && !node.IsTransient)`
`478`	`478`	`{`
`479`	`479`	`RequestRun();`
`480`	`480`	`}`
Original file line number	Diff line number	Diff line change
`@@ -752,7 +752,7 @@ private static void SaveLayoutGraphForNodeAutoComplete(WorkspaceModel workspace,`
`752`	`752`	`node.Y = n.Y + n.NotesHeight + offsetY;`
`753`	`753`	`}`
`754`	`754`	`node.ReportPosition();`
`755`		`- workspace.HasUnsavedChanges = true;`
	`755`	`+ //workspace.HasUnsavedChanges = true;`
`756`	`756`
`757`	`757`	`double noteOffset = -n.NotesHeight;`
`758`	`758`	`foreach (NoteModel note in n.LinkedNotes)`