DYN-8778 - alert user to login (#16367)

johnpierson · chubakueno · web-flow · commit 740423e85eef · 2025-07-11T11:14:36.000-06:00
Co-authored-by: chubakueno &lt;luis.rivera.sw@gmail.com&gt;
diff --git a/src/DynamoCore/Properties/Resources.en-US.resx b/src/DynamoCore/Properties/Resources.en-US.resx
@@ -876,13 +876,13 @@ This package likely contains an assembly that is blocked. You will need to load
     <value>Loading Node Library...</value>
   </data>
   <data name="AutocompleteNoRecommendationsTitle" xml:space="preserve">
-    <value>No recommendations</value>
+    <value>No suggestions available</value>
   </data>
   <data name="AutocompleteLowConfidenceTitle" xml:space="preserve">
     <value>Low confidence</value>
   </data>
   <data name="AutocompleteNoRecommendationsMessage" xml:space="preserve">
-    <value>There are no recommendations yet. You can try switching to node type match autocomplete.</value>
+    <value>The model is continuously improving - check back soon</value>
   </data>
   <data name="AutocompleteLowConfidenceMessage" xml:space="preserve">
     <value>No confident suggestions available. The model is continuously improving - check back soon.</value>
diff --git a/src/DynamoCore/Properties/Resources.resx b/src/DynamoCore/Properties/Resources.resx
@@ -879,13 +879,13 @@ This package likely contains an assembly that is blocked. You will need to load
     <value>Loading Node Library...</value>
   </data>
   <data name="AutocompleteNoRecommendationsTitle" xml:space="preserve">
-    <value>No recommendations</value>
+    <value>No suggestions available</value>
   </data>
   <data name="AutocompleteLowConfidenceTitle" xml:space="preserve">
     <value>Low confidence</value>
   </data>
   <data name="AutocompleteNoRecommendationsMessage" xml:space="preserve">
-    <value>There are no recommendations yet. You can try switching to node type match autocomplete.</value>
+    <value>The model is continuously improving - check back soon</value>
   </data>
   <data name="AutocompleteLowConfidenceMessage" xml:space="preserve">
     <value>No confident suggestions available. The model is continuously improving - check back soon.</value>
diff --git a/src/DynamoCoreWpf/Properties/Resources.Designer.cs b/src/DynamoCoreWpf/Properties/Resources.Designer.cs
diff --git a/src/DynamoCoreWpf/Properties/Resources.en-US.resx b/src/DynamoCoreWpf/Properties/Resources.en-US.resx
@@ -4176,12 +4176,6 @@ To make this file into a new template, save it to a different folder, then move
     <value>Node Icon Data is dumped to \"{0}\".</value>
     <comment>Debug menu | Dump all node icons</comment>
   </data>
-  <data name="AutocompletePlaceholder" xml:space="preserve">
-    <value>The model is continuously improving - check back soon</value>
-  </data>
-  <data name="AutocompleteNoSuggestions" xml:space="preserve">
-    <value>No suggestions available</value>
-  </data>
   <data name="GroupOptionalInportsText" xml:space="preserve">
     <value>Optional</value>
   </data>
diff --git a/src/DynamoCoreWpf/Properties/Resources.resx b/src/DynamoCoreWpf/Properties/Resources.resx
@@ -4160,12 +4160,6 @@ To make this file into a new template, save it to a different folder, then move
     <value>Node Icon Data is dumped to \"{0}\".</value>
     <comment>Debug menu | Dump all node icons</comment>
   </data>
-  <data name="AutocompletePlaceholder" xml:space="preserve">
-    <value>The model is continuously improving - check back soon</value>
-  </data>
-  <data name="AutocompleteNoSuggestions" xml:space="preserve">
-    <value>No suggestions available</value>
-  </data>
   <data name="GroupOptionalInportsText" xml:space="preserve">
     <value>Optional</value>
   </data>
diff --git a/src/DynamoCoreWpf/PublicAPI.Unshipped.txt b/src/DynamoCoreWpf/PublicAPI.Unshipped.txt
@@ -4549,8 +4549,6 @@ static Dynamo.Wpf.Properties.Resources.AddFileToPackageDialogTitle.get -> string
 static Dynamo.Wpf.Properties.Resources.AddStyleButton.get -> string
 static Dynamo.Wpf.Properties.Resources.AddToLibraryButton.get -> string
 static Dynamo.Wpf.Properties.Resources.AgreeToMLAutocompleteTOUText.get -> string
-static Dynamo.Wpf.Properties.Resources.AutocompleteNoSuggestions.get -> string
-static Dynamo.Wpf.Properties.Resources.AutocompletePlaceholder.get -> string
 static Dynamo.Wpf.Properties.Resources.Autodesk360SignInButtonTitleToolTip.get -> string
 static Dynamo.Wpf.Properties.Resources.AutodeskSignIn.get -> string
 static Dynamo.Wpf.Properties.Resources.Automatic.get -> string
diff --git a/src/NodeAutoCompleteViewExtension/ViewModels/NodeAutoCompleteBarViewModel.cs b/src/NodeAutoCompleteViewExtension/ViewModels/NodeAutoCompleteBarViewModel.cs
@@ -151,9 +151,12 @@ internal IEnumerable<DNADropdownViewModel> DropdownResults
                 RaisePropertyChanged(nameof(HasPrevious));
                 RaisePropertyChanged(nameof(HasNext));
                 RaisePropertyChanged(nameof(FilteredView));
+                RaisePropertyChanged(nameof(HasUnfilteredResults));
             }
         }
 
+        public bool HasUnfilteredResults => DropdownResults != null && DropdownResults.Any();
+
         /// <summary>
         /// Return the filter associated currently with dropdown results.
         /// </summary>
@@ -554,19 +557,7 @@ private IEnumerable<SingleResultItem> GetNodeAutocompleMLResults()
             MLNodeAutoCompletionResponse MLresults = null;
 
             // Get results from the ML API.
-            try
-            {
-                MLresults = GetGenericAutocompleteResult<MLNodeAutoCompletionResponse>(nodeAutocompleteMLEndpoint);
-            }
-            catch (Exception ex)
-            {
-                dynamoViewModel.Model.Logger.Log("Unable to fetch ML Node autocomplete results: " + ex.Message);
-                DisplayAutocompleteMLStaticPage = true;
-                AutocompleteMLTitle = Resources.LoginNeededTitle;
-                AutocompleteMLMessage = Resources.LoginNeededMessage;
-                Analytics.TrackEvent(Actions.View, Categories.NodeAutoCompleteOperations, "UnabletoFetch");
-                return new List<SingleResultItem>();
-            }
+            MLresults = GetGenericAutocompleteResult<MLNodeAutoCompletionResponse>(nodeAutocompleteMLEndpoint);
 
             // no results
             if (MLresults == null || MLresults.Results.Count() == 0)
@@ -1015,19 +1006,33 @@ internal void PopulateAutoComplete()
                 List<SingleResultItem> fullSingleResults = null;
                 MLNodeClusterAutoCompletionResponse fullResults = null;
 
-                if (IsSingleAutocomplete || !IsDisplayingMLRecommendation)
+                try
                 {
-                    fullSingleResults = GetSingleAutocompleteResults().ToList();
-                    fullResults = new MLNodeClusterAutoCompletionResponse
+                    if (IsSingleAutocomplete || !IsDisplayingMLRecommendation)
                     {
-                        Version = "0.0",
-                        NumberOfResults = fullSingleResults.Count,
-                        Results = fullSingleResults,
-                    };
+                        fullSingleResults = GetSingleAutocompleteResults().ToList();
+                        fullResults = new MLNodeClusterAutoCompletionResponse
+                        {
+                            Version = "0.0",
+                            NumberOfResults = fullSingleResults.Count,
+                            Results = fullSingleResults,
+                        };
+                    }
+                    else
+                    {
+                        fullResults = GetGenericAutocompleteResult<MLNodeClusterAutoCompletionResponse>(nodeClusterAutocompleteMLEndpoint);
+                    }
                 }
-                else
+                catch (Exception ex)
                 {
-                    fullResults = GetGenericAutocompleteResult<MLNodeClusterAutoCompletionResponse>(nodeClusterAutocompleteMLEndpoint);
+                    dynamoViewModel.Model.Logger.Log("Unable to fetch ML Node autocomplete results: " + ex.Message);
+                    DisplayAutocompleteMLStaticPage = true;
+                    AutocompleteMLTitle = Resources.LoginNeededTitle;
+                    AutocompleteMLMessage = Resources.LoginNeededMessage;
+                    Analytics.TrackEvent(Actions.View, Categories.NodeAutoCompleteOperations, "UnabletoFetch");
+                    DropdownResults = new List<DNADropdownViewModel>();
+                    IsDropDownOpen = true;
+                    return;
                 }
 
                 dynamoViewModel.UIDispatcher.BeginInvoke(() =>
diff --git a/src/NodeAutoCompleteViewExtension/Views/NodeAutoCompleteBarView.xaml b/src/NodeAutoCompleteViewExtension/Views/NodeAutoCompleteBarView.xaml
@@ -7,6 +7,7 @@
              xmlns:local="clr-namespace:Dynamo.PackageManager.UI;assembly=DynamoCoreWpf"
              xmlns:dynconverters="clr-namespace:Dynamo.Controls;assembly=DynamoCoreWpf"
              xmlns:resxother="clr-namespace:Dynamo.Wpf.Properties;assembly=DynamoCoreWpf"
+             xmlns:properties="clr-namespace:Dynamo.Properties;assembly=DynamoCore"
              mc:Ignorable="d"
              WindowStyle="None"
              AllowsTransparency="True"
@@ -79,13 +80,13 @@
                                           ContentTemplate="{TemplateBinding SelectionBoxItemTemplate}"
                                           ContentTemplateSelector="{TemplateBinding ItemTemplateSelector}"
                                           IsHitTestVisible="False" />
-                                <TextBlock x:Name="BoxPlaceholder"
-                                 Text="{x:Static resxother:Resources.AutocompleteNoSuggestions}"
-                                 Foreground="LightGray"
-                                 VerticalAlignment="Center"
-                                 FontSize="12"
-                                 Margin="6,0,0,0"
-                                 Visibility="Collapsed"/>
+                                <TextBlock x:Name="TitlePlaceholder"
+                                           Text="{Binding AutocompleteMLTitle}"
+                                           Foreground="LightGray"
+                                           VerticalAlignment="Center"
+                                           FontSize="12"
+                                           Margin="6,0,0,0"
+                                           Visibility="Collapsed"/>
                                 <TextBox x:Name="PART_EditableTextBox"
                                  Margin="3,3,23,3"
                                  Padding="10"
@@ -115,20 +116,20 @@
                                         BorderThickness="0,6,0,0" />
                                         <ContentControl x:Name="SearchSlot"
                                     Content="{TemplateBinding Tag}"
-                                    Visibility="{Binding Content, RelativeSource={RelativeSource Self}, Converter={StaticResource NullToVisibiltyConverter}}"
+                                    Visibility="{Binding HasUnfilteredResults, Converter={StaticResource BooleanToVisibilityConverter}}"
                                     Margin="0,6,0,0"
                                     VerticalAlignment="Top"/>
-                                        <TextBlock x:Name="NoItemsPlaceholder"
+                                        <TextBlock x:Name="MessagePlaceholder"
                                            FontSize="12"
-                                           Text="{x:Static resxother:Resources.AutocompletePlaceholder}"
+                                           Text="{Binding AutocompleteMLMessage}"
                                            Foreground="LightGray"
                                            HorizontalAlignment="Center"
                                            VerticalAlignment="Center"
                                            MaxWidth="{TemplateBinding ActualWidth}"
                                            TextWrapping="Wrap"
                                            TextAlignment="Center"
-                                           Visibility="Visible"
-                                           Margin="6"/>
+                                           Visibility="Collapsed"
+                                           Margin="4"/>
                                         <ScrollViewer Margin="0,36,0,0" SnapsToDevicePixels="True">
                                             <StackPanel KeyboardNavigation.DirectionalNavigation="Contained"
                                                 IsItemsHost="True" />
@@ -140,18 +141,21 @@
                                 <Trigger Property="HasItems" Value="false">
                                     <Setter TargetName="DropDownBorder" Property="MinHeight" Value="70" />
                                     <Setter Property="ScrollViewer.Visibility" Value="Collapsed" />
-                                    <Setter TargetName="NoItemsPlaceholder" Property="Visibility" Value="Visible" />
-                                    <Setter TargetName="SearchSlot" Property="Visibility" Value="Collapsed" />
-                                    <Setter TargetName="BoxPlaceholder" Property="Visibility" Value="Visible"/>
                                     <Setter TargetName="ContentSite" Property="Visibility" Value="Collapsed"/>
+                                    <Setter TargetName="TitlePlaceholder" Property="Visibility" Value="Collapsed"/>
+                                    <Setter TargetName="MessagePlaceholder" Property="Visibility" Value="Collapsed"/>
                                 </Trigger>
                                 <Trigger Property="HasItems" Value="true">
                                     <Setter Property="ScrollViewer.Visibility" Value="Visible" />
-                                    <Setter TargetName="NoItemsPlaceholder" Property="Visibility" Value="Collapsed" />
-                                    <Setter TargetName="SearchSlot" Property="Visibility" Value="Visible" />
-                                    <Setter TargetName="BoxPlaceholder" Property="Visibility" Value="Collapsed"/>
                                     <Setter TargetName="ContentSite" Property="Visibility" Value="Visible"/>
+                                    <Setter TargetName="TitlePlaceholder" Property="Visibility" Value="Collapsed"/>
+                                    <Setter TargetName="MessagePlaceholder" Property="Visibility" Value="Collapsed"/>
                                 </Trigger>
+                                <DataTrigger Binding="{Binding DisplayAutocompleteMLStaticPage}" Value="True">
+                                    <Setter TargetName="TitlePlaceholder" Property="Visibility" Value="Visible"/>
+                                    <Setter TargetName="MessagePlaceholder" Property="Visibility" Value="Visible"/>
+                                    <Setter TargetName="ContentSite" Property="Visibility" Value="Collapsed"/>
+                                </DataTrigger>
                                 <Trigger Property="IsGrouping" Value="true">
                                     <Setter Property="ScrollViewer.CanContentScroll" Value="false" />
                                 </Trigger>
