Heterogeneous list update gives infinite loop (#9334)

reddyashish · web-flow · commit 67a19a74e69b · 2018-12-20T17:18:59.000-05:00
* Add check for invalid cutom node name https://jira.autodesk.com/browse/QNTM-3928 * Removing trailing spaces * Moving the function to utilities class * Revert "Merge branch 'master' of https://github.com/DynamoDS/Dynamo" This reverts commit 085fb51, reversing changes made to d055de4. * Revert "Revert "Merge branch 'master' of https://github.com/DynamoDS/Dynamo"" This reverts commit 12538ab. * Adding tests - QNTM-3928 * Comments * Moving the test to NodeViewCustomizationTests.cs * Deleting changes to SerializationTests.cs * Create SerializationTests.cs * Update SerializationTests.cs * moving the test to UtilityTests.ca * Heterogeneous list update gives infinite loop DYN-1198 * Moving the test dyn file
diff --git a/src/Engine/ProtoCore/Lang/Replication/Replicator.cs b/src/Engine/ProtoCore/Lang/Replication/Replicator.cs
@@ -212,35 +212,32 @@ public static List<List<StackValue>> ComputeAllReducedParams(
                 var indices = ri.Zipped ? ri.ZipIndecies : new List<int> { ri.CartesianIndex };
                 foreach (int index in indices)
                 {
-                    //This should generally be a collection, so we need to do a one phase unboxing
-                    var targets = reducedParams.Select(r => r[index]).ToList();
-                    foreach (var target in targets)
+                    StackValue target = basicList[index];
+
+                    if (!target.IsArray)
                     {
-                        if (!target.IsArray)
-                        {
                             System.Console.WriteLine("WARNING: Replication unbox requested on Singleton. Trap: 437AD20D-9422-40A3-BFFD-DA4BAD7F3E5F");
                             continue;
-                        }
+                    }
 
-                        var array = runtimeCore.Heap.ToHeapObject<DSArray>(target);
-                        if (array.Count == 0)
-                        {
+                    var array = runtimeCore.Heap.ToHeapObject<DSArray>(target);
+                    if (array.Count == 0)
+                    {
                             continue;
-                        }
+                    }
 
-                        var arrayStats = ArrayUtils.GetTypeExamplesForLayer(target, runtimeCore).Values;
+                    var arrayStats = ArrayUtils.GetTypeExamplesForLayer(target, runtimeCore).Values;
 
-                        List<List<StackValue>> clonedList = new List<List<StackValue>>(reducedParams);
-                        reducedParams.Clear();
+                    List<List<StackValue>> clonedList = new List<List<StackValue>>(reducedParams);
+                    reducedParams.Clear();
 
-                        foreach (StackValue sv in arrayStats)
+                    foreach (StackValue sv in arrayStats)
+                    {
+                        foreach (List<StackValue> lst in clonedList)
                         {
-                            foreach (List<StackValue> lst in clonedList)
-                            {
-                                List<StackValue> newArgs = new List<StackValue>(lst);
-                                newArgs[index] = sv;
-                                reducedParams.Add(newArgs);
-                            }
+                            List<StackValue> newArgs = new List<StackValue>(lst);
+                            newArgs[index] = sv;
+                            reducedParams.Add(newArgs);
                         }
                     }
                 }
diff --git a/test/DynamoCoreTests/DSEvaluationModelTest.cs b/test/DynamoCoreTests/DSEvaluationModelTest.cs
@@ -8,7 +8,6 @@
 using Dynamo.Graph.Nodes.ZeroTouch;
 using NUnit.Framework;
 
-
 namespace Dynamo.Tests
 {
     [Category("DSExecution")]
@@ -1173,6 +1172,20 @@ public void TestMAGN9507()
             OpenModel(dynFilePath);
             AssertPreviewValue("3bf992eb-ecc9-4fcc-a90b-9b1ee7e925e9", 3);
         }
+
+        [Test, Category("UnitTests")]
+        public void TestHeterogenousList()
+        {
+            // open test graph
+            RunModel(@"core\dsevaluation\test_hetereogenous_list.dyn");
+
+            var guidX = "d7c44c9098d647e0bbd4be8fa2c842eb";
+            var guidY = "a5463d1fb5d0457da51e563a5707d1cd";
+            var guidZ = "d35348ab082c451aac9fc2e8a04f7263";
+            AssertPreviewValue(guidX, new object[] { null, null, null, 5 });
+            AssertPreviewValue(guidY, new object[] { null, null, null, 10.2 });
+            AssertPreviewValue(guidZ, new object[] { null, null, null, 15.2 });
+        }
     }
 
     [Category("DSCustomNode")]
diff --git a/test/core/dsevaluation/test_hetereogenous_list.dyn b/test/core/dsevaluation/test_hetereogenous_list.dyn
