DYN-8558 : transient node from the get go (#16168)

BogdanZavu · zavub · web-flow · commit 5c263c91b242 · 2025-04-25T14:44:24.000-04:00
Co-authored-by: Bogdan Zavu &lt;bogdan.zavu@autodesk.com&gt;
diff --git a/src/DynamoCore/Models/DynamoModelCommands.cs b/src/DynamoCore/Models/DynamoModelCommands.cs
@@ -96,6 +96,7 @@ private void CreateNodeImpl(CreateNodeCommand command)
 
             node.X = command.X;
             node.Y = command.Y;
+            node.IsTransient = command.IsTransient;
 
             AddNodeToCurrentWorkspace(node, centered: command.DefaultPosition);
             CurrentWorkspace.RecordCreatedModel(node);
diff --git a/src/DynamoCore/Models/RecordableCommands.cs b/src/DynamoCore/Models/RecordableCommands.cs
@@ -791,12 +791,13 @@ protected override void SerializeCore(XmlElement element)
         [DataContract]
         public class CreateNodeCommand : ModelBasedRecordableCommand
         {
-            private void SetProperties(double x, double y, bool defaultPosition, bool transformCoordinates)
+            private void SetProperties(double x, double y, bool defaultPosition, bool transformCoordinates, bool isTransient)
             {
                 X = x;
                 Y = y;
                 DefaultPosition = defaultPosition;
                 TransformCoordinates = transformCoordinates;
+                IsTransient = isTransient;
             }
 
             #region Public Class Methods
@@ -813,7 +814,7 @@ public CreateNodeCommand(
                 : base(node != null ? new[] { node.GUID } : new[] { Guid.Empty })
             {
                 Node = node;
-                SetProperties(x, y, defaultPosition, transformCoordinates);
+                SetProperties(x, y, defaultPosition, transformCoordinates, false);
             }
 
             /// <summary>
@@ -829,7 +830,7 @@ private CreateNodeCommand(
                 : base(new[] { Guid.Empty })
             {
                 NodeXml = node;
-                SetProperties(x, y, defaultPosition, transformCoordinates);
+                SetProperties(x, y, defaultPosition, transformCoordinates, false);
             }
 
             /// <summary>
@@ -846,7 +847,7 @@ public CreateNodeCommand(IEnumerable<Guid> nodeId, string nodeName,
                 : base(nodeId)
             {
                 Name = nodeName;
-                SetProperties(x, y, defaultPosition, transformCoordinates);
+                SetProperties(x, y, defaultPosition, transformCoordinates, false);
             }
 
             /// <summary>
@@ -864,7 +865,26 @@ public CreateNodeCommand(string nodeId, string nodeName,
                 : base(new[] { Guid.Parse(nodeId) })
             {
                 Name = nodeName;
-                SetProperties(x, y, defaultPosition, transformCoordinates);
+                SetProperties(x, y, defaultPosition, transformCoordinates, false);
+            }
+
+            /// <summary>
+            ///
+            /// </summary>
+            /// <param name="nodeId"></param>
+            /// <param name="nodeName"></param>
+            /// <param name="x"></param>
+            /// <param name="y"></param>
+            /// <param name="defaultPosition"></param>
+            /// <param name="transformCoordinates"></param>
+            /// <param name="isTransient"></param>
+            [JsonConstructor]
+            internal CreateNodeCommand(string nodeId, string nodeName,
+                double x, double y, bool defaultPosition, bool transformCoordinates, bool isTransient)
+                : base(new[] { Guid.Parse(nodeId) })
+            {
+                Name = nodeName;
+                SetProperties(x, y, defaultPosition, transformCoordinates, isTransient);
             }
 
             internal static CreateNodeCommand DeserializeCore(XmlElement element)
@@ -899,6 +919,8 @@ internal static CreateNodeCommand DeserializeCore(XmlElement element)
             // If it was deserialized
             internal XmlElement NodeXml { get; private set; }
 
+            // Node will be creted in transient state.
+            internal bool IsTransient { get; private set; } = false;
 
             [DataMember]
             internal double X { get; private set; }
diff --git a/src/NodeAutoCompleteViewExtension/ViewModels/NodeAutoCompleteBarViewModel.cs b/src/NodeAutoCompleteViewExtension/ViewModels/NodeAutoCompleteBarViewModel.cs
@@ -207,6 +207,8 @@ internal void ConsolidateTransientNodes()
 
             NodeAutoCompleteUtilities.PostAutoLayoutNodes(node.WorkspaceViewModel.Model, node.NodeModel, transientNodes.Select(x => x.NodeModel), true, true, false, null);
 
+            (node.WorkspaceViewModel.Model as HomeWorkspaceModel)?.MarkNodesAsModifiedAndRequestRun(transientNodes.Select(x => x.NodeModel));
+
             ToggleUndoRedoLocked(false);
         }
 
@@ -848,7 +850,7 @@ internal void AddCluster(ClusterResultItem ClusterResultItem)
                     var typeInfo = wsViewModel.NodeAutoCompleteSearchViewModel.GetInfoFromTypeId(newNode.Type.Id);
 
                     //create node with guid from the cluster response for matching later
-                    dynamoViewModel.Model.ExecuteCommand(new DynamoModel.CreateNodeCommand(Guid.NewGuid().ToString(), typeInfo.FullName, xoffset, node.NodeModel.Y, false, false));
+                    dynamoViewModel.Model.ExecuteCommand(new DynamoModel.CreateNodeCommand(Guid.NewGuid().ToString(), typeInfo.FullName, xoffset, node.NodeModel.Y, false, false, true));
 
                     //disallow the node creation command from the undo group, we group node creation and wires below
                     wsViewModel.Model.UndoRecorder.PopFromUndoGroup();
@@ -857,7 +859,6 @@ internal void AddCluster(ClusterResultItem ClusterResultItem)
                     createdNodes.Add(newNode.Id,nodeFromCluster);
                     newNodesAndWires.Add(nodeFromCluster.NodeModel);
 
-                    nodeFromCluster.IsTransient = true;
                     nodeFromCluster.IsHidden = true;
                     clusterMapping.Add(newNode.Id, nodeFromCluster);
                 }
