CARVIEW |
Select Language
HTTP/2 200
date: Sun, 27 Jul 2025 05:58:28 GMT
content-type: text/html; charset=utf-8
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-repository-download: git clone https://github.com/DynamoDS/Dynamo.git
etag: W/"80b66f6c153dc254f9eceefa17b530f1"
cache-control: max-age=0, private, must-revalidate
strict-transport-security: max-age=31536000; includeSubdomains; preload
x-frame-options: deny
x-content-type-options: nosniff
x-xss-protection: 0
referrer-policy: no-referrer-when-downgrade
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=XcXFKTYbB%2FZbHPZgY%2FDpDF%2F%2FK13LRD0xnvpst7AeVA19ya1sJg58HZR41X3wTCCPMNRyq68QzdkpJHGZ0FbWyzO0mBAwxGq0NIOFlFCEN7bKLSv07aviR1fuqJFU%2BLqNa1CF%2FmaI67MCMFkOUvj1q6lsUDN7l3eD%2FL8YqggpDTT0BvlRwYKTHPYinHxHvRwIsK1HOd2SalIi7XFIEZksXktGOjiLMZMM%2BdlPByDZw6uRCgEMQ%2BETPyGC630cpMxLiJidr34lAnIzeHVob6T%2B1g%3D%3D--IJEa8ei3oEvoMLUk--%2BI4xpk2e3iiG0xaXrBFH%2Bg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1004854918.1753595907; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 05:58:27 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 05:58:27 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: EC5C:1A1F38:B4B7AD:F03AF0:6885C003
DYN-4964-WorkingRange-Popup (#13656) · DynamoDS/Dynamo@58c4470 · GitHub
Copy file name to clipboardExpand all lines: src/DynamoCore/Configuration/IPreferences.cs
Copy file name to clipboardExpand all lines: src/DynamoCore/Configuration/PreferenceSettings.cs
Copy file name to clipboardExpand all lines: src/DynamoCoreWpf/DynamoCoreWpf.csproj
Copy file name to clipboardExpand all lines: src/DynamoCoreWpf/Properties/Resources.Designer.cs
Copy file name to clipboardExpand all lines: src/DynamoCoreWpf/Properties/Resources.en-US.resx
Copy file name to clipboardExpand all lines: src/DynamoCoreWpf/Properties/Resources.resx
Copy file name to clipboardExpand all lines: src/DynamoCoreWpf/UI/Converters.cs
Copy file name to clipboard
Copy file name to clipboardExpand all lines: src/DynamoCoreWpf/ViewModels/Core/DynamoViewModel.cs
Copy file name to clipboard
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 658
Commit 58c4470
authored
DYN-4964-WorkingRange-Popup (#13656)
* DYN-4964-WorkingRange-Popup
I've added a new button in the Workspace that when is clicked will show a popup containing the working ranges and the one currently selected.
This new button will show a different image when the mouse is hover and when is clicked, also I've added a tooltip.
For implementing this functionality I've added a new Popup (GeometryScalingPopup.xaml) and it's corresponding ViewModel. Finally I've added a converter that will receive as a parameter the current Working Range and will return a Brush with a specific color so the checkmark will be visible or not.
* DYN-4964-WorkingRange-Popup CodeReview1
Added functionality for the new DefaultGeometryScaling property that will be serialized in the DynamoSettings.xml.
Also I've disconnected the functionality of selecting the Geometry Scale for the current Workspace in the Preferences panel, now will be selected from the Dynamo workspace and will be serialized in the dyn file (as currently is happening).
* DYN-4964-WorkingRange-Popup CodeReview1
Updated the string shown in Preferences panel (Geometry Scaling section) and the tooltip showed when the mouse is over the new Workspace button.
* Build Fix
When merging master to my branch there were some changed that I didn't noticed in the PR so I'm reverting back those changes.
* DYN-4964-WorkingRange-Popup CodeReview 2
Fixed several comments also several methods were removed (like RadioGeometryScaling_Checked method) or moved
The property GeoScalingViewModel was moved from DynamoViewModel to WorkspaceViewModel..
The property CurrentGeometryScaling was deleted due that was duplicating a functionality.
* DYN-4964-WorkingRange-Popup CodeReview 2
When changing the Workspace Geometry Scaling it was not running the graph so I did some changes so it will be running the graph every time is updated.
* DYN-4964-WorkingRange-Popup CodeReview 2
Add functionality for when a custom node is created the Workspace Scale Factor is set.
Updating and removing some comments and also I started to add the unit test.
* DYN-4964-WorkingRange-Popup CodeReview2
Updating Unit Test
* DYN-4964-WorkingRange-Popup Fixing Tests
I did the next fixes:
The test TestImportCopySettings() was failing due that was reading the DynamoSettings-NewSettings.xml and comparing against the properties in PreferencesSetting so the DefaultScaleFactor was missing in the DynamoSettings-NewSettings.xml file.
The test PreferencesGeoScaling_RunGraph_Automatic due that was opening the Preferences panel and changing the Geometry Scaling value for the workspace but now that this value was moved to the Workspace in a Popup then the code needed some changes so we can change the Geometry Scaling value using the Popup.1 parent 7262a78 commit 58c4470Copy full SHA for 58c4470
File tree
Expand file treeCollapse file tree
22 files changed
+568
-142
lines changedFilter options
- src
- DynamoCoreWpf
- Properties
- UI
- Images/Canvas
- ViewModels
- Core
- Menu
- Views
- Core
- Menu
- DynamoCore/Configuration
- test
- DynamoCoreTests/Configuration
- DynamoCoreWpfTests
- settings
Expand file treeCollapse file tree
22 files changed
+568
-142
lines changedsrc/DynamoCore/Configuration/IPreferences.cs
Copy file name to clipboardExpand all lines: src/DynamoCore/Configuration/IPreferences.cs+6-1Lines changed: 6 additions & 1 deletion
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
1 |
| - | |
| 1 | + | |
2 | 2 |
| |
3 | 3 |
| |
4 | 4 |
| |
| |||
40 | 40 |
| |
41 | 41 |
| |
42 | 42 |
| |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
43 | 48 |
| |
44 | 49 |
| |
45 | 50 |
| |
|
src/DynamoCore/Configuration/PreferenceSettings.cs
Copy file name to clipboardExpand all lines: src/DynamoCore/Configuration/PreferenceSettings.cs+19Lines changed: 19 additions & 0 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
51 | 51 |
| |
52 | 52 |
| |
53 | 53 |
| |
| 54 | + | |
54 | 55 |
| |
55 | 56 |
| |
56 | 57 |
| |
| |||
230 | 231 |
| |
231 | 232 |
| |
232 | 233 |
| |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
| 247 | + | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
233 | 252 |
| |
234 | 253 |
| |
235 | 254 |
| |
|
src/DynamoCoreWpf/DynamoCoreWpf.csproj
Copy file name to clipboardExpand all lines: src/DynamoCoreWpf/DynamoCoreWpf.csproj+10Lines changed: 10 additions & 0 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
19 | 19 |
| |
20 | 20 |
| |
21 | 21 |
| |
| 22 | + | |
| 23 | + | |
22 | 24 |
| |
23 | 25 |
| |
24 | 26 |
| |
| |||
308 | 310 |
| |
309 | 311 |
| |
310 | 312 |
| |
| 313 | + | |
311 | 314 |
| |
312 | 315 |
| |
313 | 316 |
| |
| |||
358 | 361 |
| |
359 | 362 |
| |
360 | 363 |
| |
| 364 | + | |
| 365 | + | |
| 366 | + | |
361 | 367 |
| |
362 | 368 |
| |
363 | 369 |
| |
| |||
519 | 525 |
| |
520 | 526 |
| |
521 | 527 |
| |
| 528 | + | |
| 529 | + | |
| 530 | + | |
522 | 531 |
| |
523 | 532 |
| |
524 | 533 |
| |
| |||
684 | 693 |
| |
685 | 694 |
| |
686 | 695 |
| |
| 696 | + | |
687 | 697 |
| |
688 | 698 |
| |
689 | 699 |
| |
|
src/DynamoCoreWpf/Properties/Resources.Designer.cs
Copy file name to clipboardExpand all lines: src/DynamoCoreWpf/Properties/Resources.Designer.cs+10-1Lines changed: 10 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
src/DynamoCoreWpf/Properties/Resources.en-US.resx
Copy file name to clipboardExpand all lines: src/DynamoCoreWpf/Properties/Resources.en-US.resx+4-1Lines changed: 4 additions & 1 deletion
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
2375 | 2375 |
| |
2376 | 2376 |
| |
2377 | 2377 |
| |
2378 |
| - | |
| 2378 | + | |
2379 | 2379 |
| |
2380 | 2380 |
| |
2381 | 2381 |
| |
| |||
3482 | 3482 |
| |
3483 | 3483 |
| |
3484 | 3484 |
| |
| 3485 | + | |
| 3486 | + | |
| 3487 | + | |
3485 | 3488 |
| |
3486 | 3489 |
| |
3487 | 3490 |
| |
|
src/DynamoCoreWpf/Properties/Resources.resx
Copy file name to clipboardExpand all lines: src/DynamoCoreWpf/Properties/Resources.resx+4-1Lines changed: 4 additions & 1 deletion
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
2591 | 2591 |
| |
2592 | 2592 |
| |
2593 | 2593 |
| |
2594 |
| - | |
| 2594 | + | |
2595 | 2595 |
| |
2596 | 2596 |
| |
2597 | 2597 |
| |
| |||
3469 | 3469 |
| |
3470 | 3470 |
| |
3471 | 3471 |
| |
| 3472 | + | |
| 3473 | + | |
| 3474 | + | |
3472 | 3475 |
| |
3473 | 3476 |
| |
3474 | 3477 |
| |
|
src/DynamoCoreWpf/UI/Converters.cs
Copy file name to clipboardExpand all lines: src/DynamoCoreWpf/UI/Converters.cs+18Lines changed: 18 additions & 0 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
3424 | 3424 |
| |
3425 | 3425 |
| |
3426 | 3426 |
| |
| 3427 | + | |
| 3428 | + | |
| 3429 | + | |
| 3430 | + | |
| 3431 | + | |
| 3432 | + | |
| 3433 | + | |
| 3434 | + | |
| 3435 | + | |
| 3436 | + | |
| 3437 | + | |
| 3438 | + | |
| 3439 | + | |
| 3440 | + | |
| 3441 | + | |
| 3442 | + | |
| 3443 | + | |
| 3444 | + | |
3427 | 3445 |
| |
3428 | 3446 |
| |
3429 | 3447 |
| |
|
src/DynamoCoreWpf/UI/Images/Canvas/canvas-button-geometry-scaling.png
Copy file name to clipboard1.63 KB
Loading
src/DynamoCoreWpf/ViewModels/Core/DynamoViewModel.cs
Copy file name to clipboardExpand all lines: src/DynamoCoreWpf/ViewModels/Core/DynamoViewModel.cs+25-1Lines changed: 25 additions & 1 deletion
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
42 | 42 |
| |
43 | 43 |
| |
44 | 44 |
| |
| 45 | + | |
45 | 46 |
| |
46 | 47 |
| |
47 | 48 |
| |
| |||
98 | 99 |
| |
99 | 100 |
| |
100 | 101 |
| |
| 102 | + | |
| 103 | + | |
101 | 104 |
| |
102 | 105 |
| |
103 | 106 |
| |
| |||
743 | 746 |
| |
744 | 747 |
| |
745 | 748 |
| |
| 749 | + | |
746 | 750 |
| |
747 | 751 |
| |
748 | 752 |
| |
| |||
2207 | 2211 |
| |
2208 | 2212 |
| |
2209 | 2213 |
| |
| 2214 | + | |
| 2215 | + | |
2210 | 2216 |
| |
2211 | 2217 |
| |
2212 | 2218 |
| |
| |||
2514 | 2520 |
| |
2515 | 2521 |
| |
2516 | 2522 |
| |
2517 |
| - | |
| 2523 | + | |
2518 | 2524 |
| |
2519 | 2525 |
| |
2520 | 2526 |
| |
2521 | 2527 |
| |
| 2528 | + | |
| 2529 | + | |
2522 | 2530 |
| |
2523 | 2531 |
| |
2524 | 2532 |
| |
| |||
2563 | 2571 |
| |
2564 | 2572 |
| |
2565 | 2573 |
| |
| 2574 | + | |
| 2575 | + | |
| 2576 | + | |
| 2577 | + | |
| 2578 | + | |
2566 | 2579 |
| |
2567 | 2580 |
| |
2568 | 2581 |
| |
| |||
3163 | 3176 |
| |
3164 | 3177 |
| |
3165 | 3178 |
| |
| 3179 | + | |
| 3180 | + | |
| 3181 | + | |
| 3182 | + | |
| 3183 | + | |
| 3184 | + | |
| 3185 | + | |
| 3186 | + | |
| 3187 | + | |
| 3188 | + | |
| 3189 | + | |
3166 | 3190 |
| |
3167 | 3191 |
| |
3168 | 3192 |
| |
|
src/DynamoCoreWpf/ViewModels/Core/GeometryScalingViewModel.cs
Copy file name to clipboard+80Lines changed: 80 additions & 0 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + |
You can’t perform that action at this time.
0 commit comments