Warning fix (#14174)

dnenov · web-flow · commit 422841759cce · 2023-07-19T05:03:27.000+08:00
- a small fix around a limitation in how warnings were read
- now captures the case where a warning does not have an href tag to it
- will now display the full multiline text of a warning that does not have an href tag
diff --git a/src/DocumentationBrowserViewExtension/NodeDocumentationHtmlGenerator.cs b/src/DocumentationBrowserViewExtension/NodeDocumentationHtmlGenerator.cs
@@ -172,14 +172,27 @@ private static string CreateHelp(OpenNodeAnnotationEventArgs e)
                 {
                     sb.AppendLine("<br>");
                     sb.AppendLine($"<strong>{"Message"}</strong>");
-                    sb.AppendLine($"<p>{GetNthRowFromStringSplit(e.NodeInfos.ElementAt(i).Message, 0)}</p>");
 
-                    var help = e.NodeInfos.ElementAt(i).Message.Split(new string[] {". "}, StringSplitOptions.None);
-                    var html = help[1].Split(new string[] {"href="}, StringSplitOptions.None)[1];
-                    var helpHtml =
-                        DocumentationBrowserUtils.GetContentFromEmbeddedResource($"{RESOURCE_PREFIX + html}");
+                    var message = e.NodeInfos.ElementAt(i).Message;
 
-                    sb.AppendLine(helpHtml);
+                    if (message.Contains("href="))
+                    {
+                        sb.AppendLine($"<p>{GetNthRowFromStringSplit(e.NodeInfos.ElementAt(i).Message, 0)}</p>");
+
+                        var help = e.NodeInfos.ElementAt(i).Message.Split(new string[] {". "}, StringSplitOptions.None);
+                        var html = help[1].Split(new string[] {"href="}, StringSplitOptions.None)[1];
+                        var helpHtml =
+                            DocumentationBrowserUtils.GetContentFromEmbeddedResource($"{RESOURCE_PREFIX + html}");
+
+                        sb.AppendLine(helpHtml);
+                    }
+                    else
+                    {
+                        foreach(var line in message.Split(new string[] { "\r\n" }, StringSplitOptions.None))
+                        {
+                            sb.AppendLine($"<p>{line}</p>");
+                        }
+                    }
                 }
                 catch (Exception ex)
                 {
