DYN-8268: fix noNetworkMode for PM client (#15809)

pinzart90 · web-flow · commit 41d891223825 · 2025-02-06T17:22:34.000-05:00
diff --git a/src/DynamoPackages/PackageManagerClient.cs b/src/DynamoPackages/PackageManagerClient.cs
@@ -57,8 +57,6 @@ internal PackageManagerClient(IGregClient client, IPackageUploadBuilder builder,
             this.uploadBuilder = builder;
             this.client = client;
             this.packageMaintainers = new Dictionary<string, bool>();
-
-            this.LoadCompatibilityMap();  // Load the compatibility map
         }
 
         internal bool Upvote(string packageId)
@@ -370,7 +368,7 @@ internal static Dictionary<string, Dictionary<string, string>> GetCompatibilityM
         /// <summary>
         /// Method to load the map once, making it accessible to all elements
         /// </summary>
-        private void LoadCompatibilityMap()
+        internal void LoadCompatibilityMap()
         {
             if (compatibilityMap == null)  // Load only if not already loaded
             {
diff --git a/src/DynamoPackages/PackageManagerExtension.cs b/src/DynamoPackages/PackageManagerExtension.cs
@@ -161,8 +161,16 @@ public void Startup(StartupParams startupParams)
                 new GregClient(startupParams.AuthProvider, url),
                 uploadBuilder, packageUploadDirectory);
 
-            LoadPackages(startupParams.Preferences, startupParams.PathManager);
             noNetworkMode = startupParams.NoNetworkMode;
+
+            //we don't ask dpm for the compatibility map in offline mode.
+            if (!noNetworkMode)
+            {
+                // Load the compatibility map
+                PackageManagerClient.LoadCompatibilityMap();
+            }
+
+            LoadPackages(startupParams.Preferences, startupParams.PathManager);
         }
 
         /// <summary>

Original file line number	Diff line number	Diff line change
`@@ -57,8 +57,6 @@ internal PackageManagerClient(IGregClient client, IPackageUploadBuilder builder,`
`57`	`57`	`this.uploadBuilder = builder;`
`58`	`58`	`this.client = client;`
`59`	`59`	`this.packageMaintainers = new Dictionary<string, bool>();`
`60`		`-`
`61`		`- this.LoadCompatibilityMap(); // Load the compatibility map`
`62`	`60`	`}`
`63`	`61`
`64`	`62`	`internal bool Upvote(string packageId)`
`@@ -370,7 +368,7 @@ internal static Dictionary<string, Dictionary<string, string>> GetCompatibilityM`
`370`	`368`	`/// <summary>`
`371`	`369`	`/// Method to load the map once, making it accessible to all elements`
`372`	`370`	`/// </summary>`
`373`		`- private void LoadCompatibilityMap()`
	`371`	`+ internal void LoadCompatibilityMap()`
`374`	`372`	`{`
`375`	`373`	`if (compatibilityMap == null) // Load only if not already loaded`
`376`	`374`	`{`