Revert UI Blocking Function calls (#14766)

QilongTang · web-flow · commit 3f18208fe57a · 2023-12-16T00:28:42.000+08:00
diff --git a/src/DynamoCoreWpf/Views/Menu/PreferencesView.xaml.cs b/src/DynamoCoreWpf/Views/Menu/PreferencesView.xaml.cs
@@ -98,7 +98,6 @@ public PreferencesView(DynamoView dynamoView)
             stylesCustomColors = new ObservableCollection<CustomColorItem>();
             UpdateZoomScaleValueLabel(LibraryZoomScalingSlider, lblZoomScalingValue);
             UpdateZoomScaleValueLabel(PythonZoomScalingSlider, lblPythonScalingValue);
-            dynamoView.EnableEnvironment(false);
         }
 
         /// <summary>
@@ -172,7 +171,6 @@ private void CloseButton_Click(object sender, RoutedEventArgs e)
 
             dynViewModel.PreferencesViewModel.TrustedPathsViewModel.PropertyChanged -= TrustedPathsViewModel_PropertyChanged;
             dynViewModel.CheckCustomGroupStylesChanges(originalCustomGroupStyles);
-            (this.Owner as DynamoView).EnableEnvironment(true);
 
             Close();
         }
diff --git a/src/DynamoCoreWpf/Views/PackageManager/PackageManagerView.xaml.cs b/src/DynamoCoreWpf/Views/PackageManager/PackageManagerView.xaml.cs
@@ -68,7 +68,6 @@ public PackageManagerView(DynamoView dynamoView, PackageManagerViewModel package
                 Categories.PackageManager);
 
             this.dynamoView = dynamoView;
-            dynamoView.EnableEnvironment(false);
         }
 
         private void OnRequestShowFileDialog(object sender, PackagePathEventArgs e)
@@ -131,7 +130,6 @@ private void PackageManagerPanel_MouseDown(object sender, MouseButtonEventArgs e
         private void CloseButton_Click(object sender, RoutedEventArgs e)
         {
             Analytics.TrackEvent(Actions.Close, Categories.PackageManager);
-            (this.Owner as DynamoView).EnableEnvironment(true);
 
             Close();
         }

Original file line number	Diff line number	Diff line change
`@@ -98,7 +98,6 @@ public PreferencesView(DynamoView dynamoView)`
`98`	`98`	`stylesCustomColors = new ObservableCollection<CustomColorItem>();`
`99`	`99`	`UpdateZoomScaleValueLabel(LibraryZoomScalingSlider, lblZoomScalingValue);`
`100`	`100`	`UpdateZoomScaleValueLabel(PythonZoomScalingSlider, lblPythonScalingValue);`
`101`		`- dynamoView.EnableEnvironment(false);`
`102`	`101`	`}`
`103`	`102`
`104`	`103`	`/// <summary>`
`@@ -172,7 +171,6 @@ private void CloseButton_Click(object sender, RoutedEventArgs e)`
`172`	`171`
`173`	`172`	`dynViewModel.PreferencesViewModel.TrustedPathsViewModel.PropertyChanged -= TrustedPathsViewModel_PropertyChanged;`
`174`	`173`	`dynViewModel.CheckCustomGroupStylesChanges(originalCustomGroupStyles);`
`175`		`- (this.Owner as DynamoView).EnableEnvironment(true);`
`176`	`174`
`177`	`175`	`Close();`
`178`	`176`	`}`
Original file line number	Diff line number	Diff line change
`@@ -68,7 +68,6 @@ public PackageManagerView(DynamoView dynamoView, PackageManagerViewModel package`
`68`	`68`	`Categories.PackageManager);`
`69`	`69`
`70`	`70`	`this.dynamoView = dynamoView;`
`71`		`- dynamoView.EnableEnvironment(false);`
`72`	`71`	`}`
`73`	`72`
`74`	`73`	`private void OnRequestShowFileDialog(object sender, PackagePathEventArgs e)`
`@@ -131,7 +130,6 @@ private void PackageManagerPanel_MouseDown(object sender, MouseButtonEventArgs e`
`131`	`130`	`private void CloseButton_Click(object sender, RoutedEventArgs e)`
`132`	`131`	`{`
`133`	`132`	`Analytics.TrackEvent(Actions.Close, Categories.PackageManager);`
`134`		`- (this.Owner as DynamoView).EnableEnvironment(true);`
`135`	`133`
`136`	`134`	`Close();`
`137`	`135`	`}`