DYN-3777: disable linter choice in forbidden workspaces (#11759)

BogdanZavu · web-flow · commit 358809cc49d0 · 2021-06-16T12:12:07.000-04:00
* disable linter choice in forbidden workspaces

* add description
diff --git a/src/LintingViewExtension/LinterView.xaml b/src/LintingViewExtension/LinterView.xaml
@@ -149,6 +149,7 @@
                 </Grid.ColumnDefinitions>
                 <ComboBox Grid.Column="0"
                           Name="LinterSelector"
+                          IsEnabled="{Binding CanChangeLinter, Mode=OneWay}"
                           DisplayMemberPath="Name"
                           SelectedItem="{Binding ActiveLinter, Mode=TwoWay}"
                           Style="{StaticResource SComboBox}"
diff --git a/src/LintingViewExtension/LinterViewModel.cs b/src/LintingViewExtension/LinterViewModel.cs
@@ -89,6 +89,7 @@ public LinterViewModel(LinterManager linterManager, ViewLoadedParams viewLoadedP
             GraphIssues = new ObservableCollection<IRuleIssue>();
             this.linterManager.RuleEvaluationResults.CollectionChanged += RuleEvaluationResultsCollectionChanged;
             this.linterManager.PropertyChanged += OnLinterManagerPropertyChange;
+            viewLoadedParams.CurrentWorkspaceChanged += OnCurrentWorkspaceChanged;
         }
 
         #region Private methods
@@ -258,7 +259,12 @@ private void RuleEvaluationResultsCollectionChanged(object sender, NotifyCollect
             }
         }
 
-        private void OnLinterManagerPropertyChange(object sender, System.ComponentModel.PropertyChangedEventArgs e )
+        private void OnCurrentWorkspaceChanged(IWorkspaceModel obj)
+        {
+            RaisePropertyChanged(nameof(CanChangeLinter));
+        }
+
+        private void OnLinterManagerPropertyChange(object sender, System.ComponentModel.PropertyChangedEventArgs e)
         {
             if (e.PropertyName == nameof(linterManager.ActiveLinter))
             {
@@ -285,6 +291,14 @@ public void Dispose()
         {
             this.linterManager.RuleEvaluationResults.CollectionChanged -= RuleEvaluationResultsCollectionChanged;
             this.linterManager.PropertyChanged -= OnLinterManagerPropertyChange;
+            viewLoadedParams.CurrentWorkspaceChanged -= OnCurrentWorkspaceChanged;
+        }
+
+        /// <summary>
+        /// Check to see if we can set an active linter for the current workspace
+        /// </summary>
+        public bool CanChangeLinter { 
+            get => viewLoadedParams.CurrentWorkspaceModel is HomeWorkspaceModel ? true : false; 
         }
         #endregion
     }

Original file line number	Diff line number	Diff line change
`@@ -89,6 +89,7 @@ public LinterViewModel(LinterManager linterManager, ViewLoadedParams viewLoadedP`
`89`	`89`	`GraphIssues = new ObservableCollection<IRuleIssue>();`
`90`	`90`	`this.linterManager.RuleEvaluationResults.CollectionChanged += RuleEvaluationResultsCollectionChanged;`
`91`	`91`	`this.linterManager.PropertyChanged += OnLinterManagerPropertyChange;`
	`92`	`+ viewLoadedParams.CurrentWorkspaceChanged += OnCurrentWorkspaceChanged;`
`92`	`93`	`}`
`93`	`94`
`94`	`95`	`#region Private methods`
`@@ -258,7 +259,12 @@ private void RuleEvaluationResultsCollectionChanged(object sender, NotifyCollect`
`258`	`259`	`}`
`259`	`260`	`}`
`260`	`261`
`261`		`- private void OnLinterManagerPropertyChange(object sender, System.ComponentModel.PropertyChangedEventArgs e )`
	`262`	`+ private void OnCurrentWorkspaceChanged(IWorkspaceModel obj)`
	`263`	`+ {`
	`264`	`+ RaisePropertyChanged(nameof(CanChangeLinter));`
	`265`	`+ }`
	`266`	`+`
	`267`	`+ private void OnLinterManagerPropertyChange(object sender, System.ComponentModel.PropertyChangedEventArgs e)`
`262`	`268`	`{`
`263`	`269`	`if (e.PropertyName == nameof(linterManager.ActiveLinter))`
`264`	`270`	`{`
`@@ -285,6 +291,14 @@ public void Dispose()`
`285`	`291`	`{`
`286`	`292`	`this.linterManager.RuleEvaluationResults.CollectionChanged -= RuleEvaluationResultsCollectionChanged;`
`287`	`293`	`this.linterManager.PropertyChanged -= OnLinterManagerPropertyChange;`
	`294`	`+ viewLoadedParams.CurrentWorkspaceChanged -= OnCurrentWorkspaceChanged;`
	`295`	`+ }`
	`296`	`+`
	`297`	`+ /// <summary>`
	`298`	`+ /// Check to see if we can set an active linter for the current workspace`
	`299`	`+ /// </summary>`
	`300`	`+ public bool CanChangeLinter {`
	`301`	`+ get => viewLoadedParams.CurrentWorkspaceModel is HomeWorkspaceModel ? true : false;`
`288`	`302`	`}`
`289`	`303`	`#endregion`
`290`	`304`	`}`