Update RecordableCommands.cs (#11630)

aparajit-pratap · web-flow · commit 103493f7fb62 · 2021-04-19T18:43:09.000-04:00
* Update RecordableCommands.cs

Add documentation for exceptions thrown by `UpdateModelValue` API

* add tests
diff --git a/src/DynamoCore/Models/RecordableCommands.cs b/src/DynamoCore/Models/RecordableCommands.cs
@@ -1715,6 +1715,10 @@ protected override void SerializeCore(XmlElement element)
         /// <summary>
         /// A command used to update the value of a property on a model object.
         /// </summary>
+        /// <exception cref="System.InvalidOperationException">This exception is 
+        /// thrown if the node model is not found in the workspace.</exception>
+        /// /// <exception cref="System.ArgumentNullException">This exception is 
+        /// thrown if the node model or list of node models passed is null or empty.</exception>
         [DataContract]
         public class UpdateModelValueCommand : ModelBasedRecordableCommand
         {
diff --git a/test/DynamoCoreTests/CoreTests.cs b/test/DynamoCoreTests/CoreTests.cs
@@ -421,6 +421,27 @@ public void CanCopyAndPasteAndUndoShowLabels()
             Assert.IsFalse(addNode.DisplayLabels);
         }
 
+        [Test]
+        [Category("")]
+        public void UpdateModelValue_MissingNode_ThrowsException()
+        {
+            var addNode = new DSFunction(CurrentDynamoModel.LibraryServices.GetFunctionDescriptor("+"));
+
+            CurrentDynamoModel.CurrentWorkspace.AddAndRegisterNode(addNode, false);
+            CurrentDynamoModel.CurrentWorkspace.RemoveAndDisposeNode(addNode);
+
+            var command = new DynCmd.UpdateModelValueCommand(Guid.Empty, addNode.GUID, "Code", "");
+            Assert.Throws<InvalidOperationException>(() => CurrentDynamoModel.ExecuteCommand(command));
+        }
+
+        [Test]
+        [Category("")]
+        public void UpdateModelValue_EmptyList_ThrowsException()
+        {
+            var command = new DynCmd.UpdateModelValueCommand(Guid.Empty, new Guid[] { }, "", "");
+            Assert.Throws<ArgumentNullException>(() => CurrentDynamoModel.ExecuteCommand(command));
+        }
+
         [Test]
         [Category("UnitTests")]
         public void CanCopyAndPasteAndUndoInputState()
