test: improved test coverage for Inventory

AlmasB · AlmasB · commit 3ff7d2e2f455 · 2022-03-06T18:52:49.000Z
diff --git a/fxgl-gameplay/src/main/kotlin/com/almasb/fxgl/inventory/Inventory.kt b/fxgl-gameplay/src/main/kotlin/com/almasb/fxgl/inventory/Inventory.kt
@@ -112,10 +112,9 @@ class Inventory<T>(
         if (isFull)
             return false
 
-        // TODO: if == 0?
         // adding a new item, so check if quantity > 0
-        if (quantity < 0) {
-            log.warning("Attempted to add a new item with negative quantity. Ignoring")
+        if (quantity <= 0) {
+            log.warning("Attempted to add a *NEW* item with 0 or negative quantity. Ignoring")
             return false
         }
 
diff --git a/fxgl-gameplay/src/test/kotlin/com/almasb/fxgl/inventory/InventoryTest.kt b/fxgl-gameplay/src/test/kotlin/com/almasb/fxgl/inventory/InventoryTest.kt
@@ -239,6 +239,22 @@ class InventoryTest {
         assertTrue(inventory.incrementQuantity("Hello", -10))
     }
 
+    @Test
+    fun `Cannot add a new item with 0 or negative amount`() {
+        inventory = Inventory(5)
+
+        assertFalse(inventory.add("Hello", quantity = 0))
+        assertFalse(inventory.add("Hello", quantity = -1))
+    }
+
+    @Test
+    fun `Cannot increment qty of existing item by 0`() {
+        inventory = Inventory(5)
+        inventory.add("Hello")
+
+        assertFalse(inventory.incrementQuantity("Hello", 0))
+    }
+
     @Test
     fun `Transfer from another inventory`() {
         inventory = Inventory(5)
@@ -269,4 +285,22 @@ class InventoryTest {
         assertTrue(result)
         assertTrue(!inventory.hasItem("Hello"))
     }
+
+    @Test
+    fun `Transfer from inventory does not work if no item in inventory`() {
+        inventory = Inventory(5)
+        val other = Inventory<String>(2)
+
+        assertFalse(other.transferFrom(inventory, "Hello"))
+    }
+
+    @Test
+    fun `Transfer from inventory does not work if inventory is full`() {
+        inventory = Inventory(5)
+        inventory.add("Hello")
+
+        val other = Inventory<String>(0)
+
+        assertFalse(other.transferFrom(inventory, "Hello"))
+    }
 }
