| CARVIEW |
Select Language
HTTP/2 200
server: nginx
date: Sat, 11 Oct 2025 16:28:11 GMT
content-type: text/html;charset=utf-8
vary: Accept-Encoding
etag: W/"anonymous/Fri, 02 Oct 2020 17:45:49 GMT/81efa10b32d939349aa0f23538586e4b"
cache-control: must-revalidate
alt-svc: h3=":443"; ma=86400
x-nc: HIT
content-encoding: gzip
Changeset 49088 – WordPress Trac
Changeset 49088
- Timestamp:
- 10/02/2020 05:45:49 PM (5 years ago)
- Author:
- TimothyBlynJacobs
- Message:
-
REST API: Allow for string ids in the search controller.
Previously, the search controller infrastructure required that the id property was an integer. This prevents data models that use a string id from utilizing the search infrastructure.
This commit lifts the restraint that search handlers return integer ids. This will allow for the Post Formats search handler coming in 5.6 to use slugs instead of creating fake ids.
Props stoyangeorgiev.
Fixes #51131.
- Location:
- trunk/src/wp-includes/rest-api
- Files:
-
- 2 edited
-
endpoints/class-wp-rest-search-controller.php (modified) (3 diffs)
-
search/class-wp-rest-search-handler.php (modified) (2 diffs)
Legend:
- Unmodified
- Added
- Removed
-
trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-search-controller.php
r47122 r49088 141 141 } 142 142 143 $ids = array_map( 'absint', $result[ WP_REST_Search_Handler::RESULT_IDS ] );143 $ids = $result[ WP_REST_Search_Handler::RESULT_IDS ]; 144 144 145 145 $results = array(); … … 187 187 * @since 5.0.0 188 188 * 189 * @param int 189 * @param int|string $id ID of the item to prepare. 190 190 * @param WP_REST_Request $request Request object. 191 191 * @return WP_REST_Response Response object. … … 246 246 self::PROP_ID => array( 247 247 'description' => __( 'Unique identifier for the object.' ), 248 'type' => 'integer',248 'type' => array( 'integer', 'string' ), 249 249 'context' => array( 'view', 'embed' ), 250 250 'readonly' => true, -
trunk/src/wp-includes/rest-api/search/class-wp-rest-search-handler.php
r46586 r49088 80 80 * @since 5.0.0 81 81 * 82 * @param int 83 * @param array $fields Fields to include for the item.82 * @param int|string $id Item ID. 83 * @param array $fields Fields to include for the item. 84 84 * @return array Associative array containing all fields for the item. 85 85 */ … … 91 91 * @since 5.0.0 92 92 * 93 * @param int $id Item ID.93 * @param int|string $id Item ID. 94 94 * @return array Links for the given item. 95 95 */
Note: See TracChangeset
for help on using the changeset viewer.